From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kever Yang Subject: Re: [PATCH v2 7/9] Makefile.spl: Create u-boot-spl-rockchip.bin for rk3399 Date: Tue, 7 May 2019 14:34:40 +0800 Message-ID: <52ca4f72-fa9c-487a-eb10-a509b5e72539@rock-chips.com> References: <20190428090913.10568-1-jagan@amarulasolutions.com> <20190428090913.10568-8-jagan@amarulasolutions.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190428090913.10568-8-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Jagan Teki , Simon Glass , Philipp Tomsich , Akash Gajjar , Tom Rini , Manivannan Sadhasivam Cc: Paul Kocialkowski , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-amarula-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org, u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org List-Id: linux-rockchip.vger.kernel.org SGkgSmFnYW4sCgpPbiAwNC8yOC8yMDE5IDA1OjA5IFBNLCBKYWdhbiBUZWtpIHdyb3RlOgo+IFJv Y2tjaGlwIHBsYXRmb3JtIHdvdWxkIHJlcXVpcmUgYW4gZXhwbGljaXQgY2FsbCB0byBta2ltYWdl IGZvcgo+IGNyZWF0aW5nIGJvb3RhYmxlIGltYWdlcyB3aGljaCBpbmRlZWQgc3BlY2lmaWMgdG8g U29DIGZhbWlseQo+IGFsb25nIHdpdGggYm9vdCBkZXZpY2VzLgo+Cj4gRXhhbXBsZSBvZiBjcmVh dGluZyBib290YWJsZSBpbWFnZSBmb3IgcmszMzk5IGZhbWlseSB3aXRoIFNECj4gYm9vdCBkZXZp Y2UgYXMKPgo+IOKCuSBta2ltYWdlIC1uIHJrMzM5OSAtVCBya3NkIC1kIC4vc3BsL3UtYm9vdC1z cGwtZHRiLmJpbiB1LWJvb3Qtc3BsLXJvY2tjaGlwLmJpbgo+Cj4gVGhpcyBwYXRjaCB3b3VsZCBk byB0aGUgc2FtZSB0aGluayB2aWEgTWFrZWZpbGUuc3BsIGZvciByazMzOTkuCj4KPiBUaGlzIHdv dWxkIGJlIGFuIGluaXRpYWwgdmVyc2lvbiBhbmQgaXQgY2FuIGVhc2lseSBleHBhbmQgZnVydGhl ciB0byBzdXBwb3J0Cj4gb3RoZXIgZmFtaWxpZXMgb2YgU29DJ3Mgd2l0aCB2YXJpZXR5IG9mIGJv b3Qgc3RhZ2VzIGxpa2UgVFBMLCBTUEwuCgrCoMKgwqAgcmszMzk5IG1heSBoYXZlIFRQTCBsaWtl IG90aGVyIFNvQ3MsIGZvciB0aGVyZSB3aWxsIGJlIGltYWdlIHR5cGVzOgoKU1BMK3UtYm9vdC5i aW4KClNQTCt1LWJvb3QuaXRiCgpUUEwrU1BMK3UtYm9vdC5pdGIKClNlZW1zIHRoaXMgcGF0Y2gg YW5kIDkvOSBvZiB0aGlzIHBhdGNoIHNldCBvbmx5IGNvdmVyIFNQTCt1LWJvb3QuaXRiPwoKSXMg aXQgcG9zc2libGUgdG8gbWFrZSBpdCBtb3JlIGdlbmVyaWM/CgoKVGhhbmtzLAoKLSBLZXZlcgoK Pgo+IFNpZ25lZC1vZmYtYnk6IEphZ2FuIFRla2kgPGphZ2FuQGFtYXJ1bGFzb2x1dGlvbnMuY29t Pgo+IC0tLQo+ICBhcmNoL2FybS9tYWNoLXJvY2tjaGlwL0tjb25maWcgfCAgOCArKysrKysrKwo+ ICBkb2MvUkVBRE1FLnJvY2tjaGlwICAgICAgICAgICAgfCAgMyArLS0KPiAgc2NyaXB0cy9NYWtl ZmlsZS5zcGwgICAgICAgICAgIHwgMjEgKysrKysrKysrKysrKysrKysrKysrCj4gIDMgZmlsZXMg Y2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQg YS9hcmNoL2FybS9tYWNoLXJvY2tjaGlwL0tjb25maWcgYi9hcmNoL2FybS9tYWNoLXJvY2tjaGlw L0tjb25maWcKPiBpbmRleCBkYmU3ZjExZDM5Li4yODZjODcwMTM1IDEwMDY0NAo+IC0tLSBhL2Fy Y2gvYXJtL21hY2gtcm9ja2NoaXAvS2NvbmZpZwo+ICsrKyBiL2FyY2gvYXJtL21hY2gtcm9ja2No aXAvS2NvbmZpZwo+IEBAIC0yMjIsNiArMjIyLDE0IEBAIGNvbmZpZyBST0NLQ0hJUF9TUExfUkVT RVJWRV9JUkFNCj4gIGNvbmZpZyBST0NLQ0hJUF9CUk9NX0hFTFBFUgo+ICAJYm9vbAo+ICAKPiAr Y29uZmlnIFNQTF9ST0NLQ0hJUF9JTUdfTkFNRQo+ICsJc3RyaW5nICJTUEwgUm9ja2NoaXAgaW1h Z2UgbmFtZSIKPiArCWRlZmF1bHQgInJrMzM5OSIgaWYgUk9DS0NISVBfUkszMzk5Cj4gKwloZWxw Cj4gKwkgIFRvIGNyZWF0ZSBTUEwgaW1hZ2UgZm9yIHJvY2tjaGlwIHRhcmdldHMgdGhlIGltYWdl IG5hbWUgd291bGQKPiArCSAgZGVwZW5kcyBvbiB0aGUgU29DIGZhbWlseSB0aGF0IHdvdWxkIHBh c3MgYXMgYW4gYXJndW1lbnQgYXMKPiArCSAgJy1uIHJrMzM5OScgdG8gbWtpbWFnZSBmb3IgY3Jl YXRpbmcgUm9ja2NoaXAgU1BMIGJvb3QgaW1hZ2UuCj4gKwo+ICBjb25maWcgU1BMX1JPQ0tDSElQ X0VBUkxZUkVUVVJOX1RPX0JST00KPiAgICAgICAgICBib29sICJTUEwgcmVxdWlyZXMgZWFybHkt cmV0dXJuIChmb3IgUkszMTg4LXN0eWxlIEJST00pIHRvIEJST00iCj4gIAlkZXBlbmRzIG9uIFNQ TCAmJiBFTkFCTEVfQVJNX1NPQ19CT09UMF9IT09LCj4gZGlmZiAtLWdpdCBhL2RvYy9SRUFETUUu cm9ja2NoaXAgYi9kb2MvUkVBRE1FLnJvY2tjaGlwCj4gaW5kZXggYzRlNWY4M2RhNy4uY2NiYWFh YTlhNyAxMDA2NDQKPiAtLS0gYS9kb2MvUkVBRE1FLnJvY2tjaGlwCj4gKysrIGIvZG9jL1JFQURN RS5yb2NrY2hpcAo+IEBAIC00MjEsMTEgKzQyMSwxMCBAQCBPcHRpb24gMjogUGFja2FnZSB0aGUg aW1hZ2Ugd2l0aCBTUEw6Cj4gICAgLSBQcmVmaXggcmszMzk5IGhlYWRlciB0byBTUEwgaW1hZ2UK PiAgCj4gICAgICA9PiBjZCAvcGF0aC90by91LWJvb3QKPiAtICAgID0+IC4vdG9vbHMvbWtpbWFn ZSAtbiByazMzOTkgLVQgcmtzZCAtZCBzcGwvdS1ib290LXNwbC1kdGIuYmluIG91dAo+ICAKPiAg ICAtIFdyaXRlIHByZWZpeGVkIFNQTCBhdCA2NHRoIHNlY3Rvcgo+ICAKPiAtICAgID0+IHN1ZG8g ZGQgaWY9b3V0IG9mPS9kZXYvc2RjIHNlZWs9NjQKPiArICAgID0+IHN1ZG8gZGQgaWY9c3BsL3Ut Ym9vdC1zcGwtcm9ja2NoaXAuYmluIG9mPS9kZXYvc2RjIHNlZWs9NjQKPiAgCj4gICAgLSBXcml0 ZSBVLUJvb3QgcHJvcGVyIGF0IDE2Mzg0IHNlY3Rvcgo+ICAKPiBkaWZmIC0tZ2l0IGEvc2NyaXB0 cy9NYWtlZmlsZS5zcGwgYi9zY3JpcHRzL01ha2VmaWxlLnNwbAo+IGluZGV4IDU0YjE2MGQ3MmIu LjQ5YzA2NDFhYTIgMTAwNjQ0Cj4gLS0tIGEvc2NyaXB0cy9NYWtlZmlsZS5zcGwKPiArKysgYi9z Y3JpcHRzL01ha2VmaWxlLnNwbAo+IEBAIC0yMzUsNiArMjM1LDEwIEBAIEFMTC0kKENPTkZJR19B UkNIX1pZTlFNUCkJKz0gJChvYmopL2Jvb3QuYmluCj4gIAo+ICBBTEwtJChDT05GSUdfQVJDSF9N RURJQVRFSykJKz0gJChvYmopL3UtYm9vdC1zcGwtbXRrLmJpbgo+ICAKPiAraWZkZWYgQ09ORklH X1JPQ0tDSElQX1JLMzM5OQo+ICtBTEwtJChDT05GSUdfQVJDSF9ST0NLQ0hJUCkJKz0gJChvYmop L3UtYm9vdC1zcGwtcm9ja2NoaXAuYmluCj4gK2VuZGlmCj4gKwo+ICBhbGw6CSQoQUxMLXkpCj4g IAo+ICBxdWlldF9jbWRfY2F0ID0gQ0FUICAgICAkQAo+IEBAIC0zNjksNiArMzczLDIzIEBAIE1L SU1BR0VGTEFHU191LWJvb3Qtc3BsLW10ay5iaW4gPSAtVCBtdGtfaW1hZ2UgXAo+ICAkKG9iaikv dS1ib290LXNwbC1tdGsuYmluOiAkKG9iaikvdS1ib290LXNwbC5iaW4gRk9SQ0UKPiAgCSQoY2Fs bCBpZl9jaGFuZ2VkLG1raW1hZ2UpCj4gIAo+ICsjIFJvY2tjaGlwIHNwZWNpZmljIFNQTCBidWls ZAo+ICtpZmVxICgkKENPTkZJR19ST0NLQ0hJUF9SSzMzOTkpLHkpCj4gKwo+ICtpZmVxICgkKENP TkZJR19TUElfRkxBU0hfU1VQUE9SVCkseSkKPiArUk9DS0NISVBfSU1HX1RZUEUgOj0gcmtzcGkK PiArZWxzZQo+ICtST0NLQ0hJUF9JTUdfVFlQRSA6PSBya3NkCj4gK2VuZGlmCj4gKwo+ICtNS0lN QUdFRkxBR1NfdS1ib290LXNwbC1yb2NrY2hpcC5iaW4gPSAtbiAkKENPTkZJR19TUExfUk9DS0NI SVBfSU1HX05BTUUpIFwKPiArCS1UICQoUk9DS0NISVBfSU1HX1RZUEUpIC1kICQoTUtJTUFHRU9V VFBVVCkKPiArCj4gKyQob2JqKS91LWJvb3Qtc3BsLXJvY2tjaGlwLmJpbjogJChvYmopL3UtYm9v dC1zcGwuYmluIEZPUkNFCj4gKwkkKGNhbGwgaWZfY2hhbmdlZCxta2ltYWdlKQo+ICsKPiArZW5k aWYgIyBDT05GSUdfUk9DS0NISVBfUkszMzk5Cj4gKwo+ICAjIFJ1bGUgdG8gbGluayB1LWJvb3Qt c3BsCj4gICMgTWF5IGJlIG92ZXJyaWRkZW4gYnkgYXJjaC8kKEFSQ0gpL2NvbmZpZy5tawo+ICBx dWlldF9jbWRfdS1ib290LXNwbCA/PSBMRCAgICAgICRACgoKCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QK TGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kever Yang Date: Tue, 7 May 2019 14:34:40 +0800 Subject: [U-Boot] [PATCH v2 7/9] Makefile.spl: Create u-boot-spl-rockchip.bin for rk3399 In-Reply-To: <20190428090913.10568-8-jagan@amarulasolutions.com> References: <20190428090913.10568-1-jagan@amarulasolutions.com> <20190428090913.10568-8-jagan@amarulasolutions.com> Message-ID: <52ca4f72-fa9c-487a-eb10-a509b5e72539@rock-chips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de Hi Jagan, On 04/28/2019 05:09 PM, Jagan Teki wrote: > Rockchip platform would require an explicit call to mkimage for > creating bootable images which indeed specific to SoC family > along with boot devices. > > Example of creating bootable image for rk3399 family with SD > boot device as > > ₹ mkimage -n rk3399 -T rksd -d ./spl/u-boot-spl-dtb.bin u-boot-spl-rockchip.bin > > This patch would do the same think via Makefile.spl for rk3399. > > This would be an initial version and it can easily expand further to support > other families of SoC's with variety of boot stages like TPL, SPL.     rk3399 may have TPL like other SoCs, for there will be image types: SPL+u-boot.bin SPL+u-boot.itb TPL+SPL+u-boot.itb Seems this patch and 9/9 of this patch set only cover SPL+u-boot.itb? Is it possible to make it more generic? Thanks, - Kever > > Signed-off-by: Jagan Teki > --- > arch/arm/mach-rockchip/Kconfig | 8 ++++++++ > doc/README.rockchip | 3 +-- > scripts/Makefile.spl | 21 +++++++++++++++++++++ > 3 files changed, 30 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig > index dbe7f11d39..286c870135 100644 > --- a/arch/arm/mach-rockchip/Kconfig > +++ b/arch/arm/mach-rockchip/Kconfig > @@ -222,6 +222,14 @@ config ROCKCHIP_SPL_RESERVE_IRAM > config ROCKCHIP_BROM_HELPER > bool > > +config SPL_ROCKCHIP_IMG_NAME > + string "SPL Rockchip image name" > + default "rk3399" if ROCKCHIP_RK3399 > + help > + To create SPL image for rockchip targets the image name would > + depends on the SoC family that would pass as an argument as > + '-n rk3399' to mkimage for creating Rockchip SPL boot image. > + > config SPL_ROCKCHIP_EARLYRETURN_TO_BROM > bool "SPL requires early-return (for RK3188-style BROM) to BROM" > depends on SPL && ENABLE_ARM_SOC_BOOT0_HOOK > diff --git a/doc/README.rockchip b/doc/README.rockchip > index c4e5f83da7..ccbaaaa9a7 100644 > --- a/doc/README.rockchip > +++ b/doc/README.rockchip > @@ -421,11 +421,10 @@ Option 2: Package the image with SPL: > - Prefix rk3399 header to SPL image > > => cd /path/to/u-boot > - => ./tools/mkimage -n rk3399 -T rksd -d spl/u-boot-spl-dtb.bin out > > - Write prefixed SPL at 64th sector > > - => sudo dd if=out of=/dev/sdc seek=64 > + => sudo dd if=spl/u-boot-spl-rockchip.bin of=/dev/sdc seek=64 > > - Write U-Boot proper at 16384 sector > > diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl > index 54b160d72b..49c0641aa2 100644 > --- a/scripts/Makefile.spl > +++ b/scripts/Makefile.spl > @@ -235,6 +235,10 @@ ALL-$(CONFIG_ARCH_ZYNQMP) += $(obj)/boot.bin > > ALL-$(CONFIG_ARCH_MEDIATEK) += $(obj)/u-boot-spl-mtk.bin > > +ifdef CONFIG_ROCKCHIP_RK3399 > +ALL-$(CONFIG_ARCH_ROCKCHIP) += $(obj)/u-boot-spl-rockchip.bin > +endif > + > all: $(ALL-y) > > quiet_cmd_cat = CAT $@ > @@ -369,6 +373,23 @@ MKIMAGEFLAGS_u-boot-spl-mtk.bin = -T mtk_image \ > $(obj)/u-boot-spl-mtk.bin: $(obj)/u-boot-spl.bin FORCE > $(call if_changed,mkimage) > > +# Rockchip specific SPL build > +ifeq ($(CONFIG_ROCKCHIP_RK3399),y) > + > +ifeq ($(CONFIG_SPI_FLASH_SUPPORT),y) > +ROCKCHIP_IMG_TYPE := rkspi > +else > +ROCKCHIP_IMG_TYPE := rksd > +endif > + > +MKIMAGEFLAGS_u-boot-spl-rockchip.bin = -n $(CONFIG_SPL_ROCKCHIP_IMG_NAME) \ > + -T $(ROCKCHIP_IMG_TYPE) -d $(MKIMAGEOUTPUT) > + > +$(obj)/u-boot-spl-rockchip.bin: $(obj)/u-boot-spl.bin FORCE > + $(call if_changed,mkimage) > + > +endif # CONFIG_ROCKCHIP_RK3399 > + > # Rule to link u-boot-spl > # May be overridden by arch/$(ARCH)/config.mk > quiet_cmd_u-boot-spl ?= LD $@