From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1168332AbcKAJsN (ORCPT ); Tue, 1 Nov 2016 05:48:13 -0400 Received: from mail-lf0-f41.google.com ([209.85.215.41]:36339 "EHLO mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034522AbcKAJsK (ORCPT ); Tue, 1 Nov 2016 05:48:10 -0400 Subject: Re: [RFC PATCH v2 3/5] ARM64: dts: meson-gxl: Add ethernet nodes with internal PHY To: Neil Armstrong , f.fainelli@gmail.com, khilman@baylibre.com, carlo@caione.org, andrew@lunn.ch References: <1477932987-27871-1-git-send-email-narmstrong@baylibre.com> <1477932987-27871-4-git-send-email-narmstrong@baylibre.com> Cc: netdev@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org From: Sergei Shtylyov Message-ID: <52cb99f1-93ef-ea53-63c1-a661c2790538@cogentembedded.com> Date: Tue, 1 Nov 2016 12:48:06 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1477932987-27871-4-git-send-email-narmstrong@baylibre.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 10/31/2016 7:56 PM, Neil Armstrong wrote: > Add Ethernet node with Internal PHY selection for the Amlogic GXL SoCs > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 45 ++++++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > index d1bf381..71670c3 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > @@ -47,6 +47,24 @@ > > / { > compatible = "amlogic,meson-gxl"; > + > + No need for these empty lines. > +}; > + > +ðmac { > + reg = <0x0 0xc9410000 0x0 0x10000 > + 0x0 0xc8834540 0x0 0x4>; > + > + clocks = <&clkc CLKID_ETH>, > + <&clkc CLKID_FCLK_DIV2>, > + <&clkc CLKID_MPLL2>; > + clock-names = "stmmaceth", "clkin0", "clkin1"; > + > + mdio0: mdio0 { Should be "mdio0: mdio {" in oprder to comply woth the DT spec. > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "snps,dwmac-mdio"; > + }; > }; > > &aobus { [...] MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [RFC PATCH v2 3/5] ARM64: dts: meson-gxl: Add ethernet nodes with internal PHY Date: Tue, 1 Nov 2016 12:48:06 +0300 Message-ID: <52cb99f1-93ef-ea53-63c1-a661c2790538@cogentembedded.com> References: <1477932987-27871-1-git-send-email-narmstrong@baylibre.com> <1477932987-27871-4-git-send-email-narmstrong@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Neil Armstrong , f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org, andrew-g2DYL2Zd6BY@public.gmane.org Return-path: In-Reply-To: <1477932987-27871-4-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Hello. On 10/31/2016 7:56 PM, Neil Armstrong wrote: > Add Ethernet node with Internal PHY selection for the Amlogic GXL SoCs > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 45 ++++++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > index d1bf381..71670c3 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > @@ -47,6 +47,24 @@ > > / { > compatible = "amlogic,meson-gxl"; > + > + No need for these empty lines. > +}; > + > +ðmac { > + reg = <0x0 0xc9410000 0x0 0x10000 > + 0x0 0xc8834540 0x0 0x4>; > + > + clocks = <&clkc CLKID_ETH>, > + <&clkc CLKID_FCLK_DIV2>, > + <&clkc CLKID_MPLL2>; > + clock-names = "stmmaceth", "clkin0", "clkin1"; > + > + mdio0: mdio0 { Should be "mdio0: mdio {" in oprder to comply woth the DT spec. > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "snps,dwmac-mdio"; > + }; > }; > > &aobus { [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Tue, 1 Nov 2016 12:48:06 +0300 Subject: [RFC PATCH v2 3/5] ARM64: dts: meson-gxl: Add ethernet nodes with internal PHY In-Reply-To: <1477932987-27871-4-git-send-email-narmstrong@baylibre.com> References: <1477932987-27871-1-git-send-email-narmstrong@baylibre.com> <1477932987-27871-4-git-send-email-narmstrong@baylibre.com> Message-ID: <52cb99f1-93ef-ea53-63c1-a661c2790538@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 10/31/2016 7:56 PM, Neil Armstrong wrote: > Add Ethernet node with Internal PHY selection for the Amlogic GXL SoCs > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 45 ++++++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > index d1bf381..71670c3 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > @@ -47,6 +47,24 @@ > > / { > compatible = "amlogic,meson-gxl"; > + > + No need for these empty lines. > +}; > + > +ðmac { > + reg = <0x0 0xc9410000 0x0 0x10000 > + 0x0 0xc8834540 0x0 0x4>; > + > + clocks = <&clkc CLKID_ETH>, > + <&clkc CLKID_FCLK_DIV2>, > + <&clkc CLKID_MPLL2>; > + clock-names = "stmmaceth", "clkin0", "clkin1"; > + > + mdio0: mdio0 { Should be "mdio0: mdio {" in oprder to comply woth the DT spec. > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "snps,dwmac-mdio"; > + }; > }; > > &aobus { [...] MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Tue, 1 Nov 2016 12:48:06 +0300 Subject: [RFC PATCH v2 3/5] ARM64: dts: meson-gxl: Add ethernet nodes with internal PHY In-Reply-To: <1477932987-27871-4-git-send-email-narmstrong@baylibre.com> References: <1477932987-27871-1-git-send-email-narmstrong@baylibre.com> <1477932987-27871-4-git-send-email-narmstrong@baylibre.com> Message-ID: <52cb99f1-93ef-ea53-63c1-a661c2790538@cogentembedded.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org Hello. On 10/31/2016 7:56 PM, Neil Armstrong wrote: > Add Ethernet node with Internal PHY selection for the Amlogic GXL SoCs > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 45 ++++++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > index d1bf381..71670c3 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi > @@ -47,6 +47,24 @@ > > / { > compatible = "amlogic,meson-gxl"; > + > + No need for these empty lines. > +}; > + > +ðmac { > + reg = <0x0 0xc9410000 0x0 0x10000 > + 0x0 0xc8834540 0x0 0x4>; > + > + clocks = <&clkc CLKID_ETH>, > + <&clkc CLKID_FCLK_DIV2>, > + <&clkc CLKID_MPLL2>; > + clock-names = "stmmaceth", "clkin0", "clkin1"; > + > + mdio0: mdio0 { Should be "mdio0: mdio {" in oprder to comply woth the DT spec. > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "snps,dwmac-mdio"; > + }; > }; > > &aobus { [...] MBR, Sergei