From: Julien Grall <julien.grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH v2 2/6] xen/arm: make processor a per cpu variable
Date: Tue, 20 Feb 2018 10:39:58 +0000 [thread overview]
Message-ID: <52f098ab-14a9-09b1-68ca-be5a36d52123@arm.com> (raw)
In-Reply-To: <1519077510-22405-2-git-send-email-sstabellini@kernel.org>
Hi Stefano,
On 19/02/18 21:58, Stefano Stabellini wrote:
> There can be processors of different kinds on a single system. Make
> processor a per_cpu variable pointing to the right processor type for
> each core.
>
> Suggested-by: Julien Grall <julien.grall@arm.com>
> Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
Reviewed-by: Julien Grall <julien.grall@arm.com>
>
> ---
> Changes in v2:
> - add patch
> ---
> xen/arch/arm/processor.c | 8 ++++----
> xen/arch/arm/smpboot.c | 2 ++
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/xen/arch/arm/processor.c b/xen/arch/arm/processor.c
> index 8c425ce..ce43850 100644
> --- a/xen/arch/arm/processor.c
> +++ b/xen/arch/arm/processor.c
> @@ -18,7 +18,7 @@
> */
> #include <asm/procinfo.h>
>
> -static const struct processor *processor = NULL;
> +static DEFINE_PER_CPU(struct processor *, processor);
>
> void __init processor_setup(void)
> {
> @@ -28,15 +28,15 @@ void __init processor_setup(void)
> if ( !procinfo )
> return;
>
> - processor = procinfo->processor;
> + this_cpu(processor) = procinfo->processor;
> }
>
> void processor_vcpu_initialise(struct vcpu *v)
> {
> - if ( !processor || !processor->vcpu_initialise )
> + if ( !this_cpu(processor) || !this_cpu(processor)->vcpu_initialise )
> return;
>
> - processor->vcpu_initialise(v);
> + this_cpu(processor)->vcpu_initialise(v);
> }
>
> /*
> diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
> index 7ea4e41..122c0b5 100644
> --- a/xen/arch/arm/smpboot.c
> +++ b/xen/arch/arm/smpboot.c
> @@ -32,6 +32,7 @@
> #include <xen/console.h>
> #include <asm/cpuerrata.h>
> #include <asm/gic.h>
> +#include <asm/procinfo.h>
> #include <asm/psci.h>
> #include <asm/acpi.h>
>
> @@ -300,6 +301,7 @@ void start_secondary(unsigned long boot_phys_offset,
> set_processor_id(cpuid);
>
> identify_cpu(¤t_cpu_data);
> + processor_setup();
>
> init_traps();
>
>
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-20 10:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 21:58 [PATCH v2 0/6] unsafe big.LITTLE support Stefano Stabellini
2018-02-19 21:58 ` [PATCH v2 1/6] xen/arm: Park CPUs with a MIDR different from the boot CPU Stefano Stabellini
2018-02-19 21:58 ` [PATCH v2 2/6] xen/arm: make processor a per cpu variable Stefano Stabellini
2018-02-20 10:39 ` Julien Grall [this message]
2018-02-19 21:58 ` [PATCH v2 3/6] xen/arm: read ACTLR on the pcpu where the vcpu will run Stefano Stabellini
2018-02-20 10:56 ` Julien Grall
2018-02-19 21:58 ` [PATCH v2 4/6] xen/arm: make vpidr per vcpu Stefano Stabellini
2018-02-20 11:02 ` Julien Grall
2018-02-20 20:47 ` Stefano Stabellini
2018-02-19 21:58 ` [PATCH v2 5/6] xen/arm: read cacheline size when needed Stefano Stabellini
2018-02-20 11:33 ` Julien Grall
2018-02-20 21:03 ` Stefano Stabellini
2018-02-20 21:16 ` Julien Grall
2018-02-20 21:49 ` Julien Grall
2018-02-20 23:28 ` Stefano Stabellini
2018-02-21 7:58 ` Julien Grall
2018-02-19 21:58 ` [PATCH v2 6/6] xen/arm: update the docs about heterogeneous computing Stefano Stabellini
2018-02-20 11:38 ` Julien Grall
2018-02-20 16:40 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52f098ab-14a9-09b1-68ca-be5a36d52123@arm.com \
--to=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.