From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47253)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bIbzu-0005Vi-Nx
	for qemu-devel@nongnu.org; Thu, 30 Jun 2016 09:27:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bIbzp-0007sJ-NY
	for qemu-devel@nongnu.org; Thu, 30 Jun 2016 09:27:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49812)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bIbzp-0007sE-HY
	for qemu-devel@nongnu.org; Thu, 30 Jun 2016 09:27:09 -0400
References: <1467291213-13393-1-git-send-email-armbru@redhat.com>
	<1467291213-13393-2-git-send-email-armbru@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <52f14da8-1ddc-fd17-2ddd-4eedddcec4e9@redhat.com>
Date: Thu, 30 Jun 2016 15:27:05 +0200
MIME-Version: 1.0
In-Reply-To: <1467291213-13393-2-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC v3 1/5] tests: New make target
 check-source
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, silbe@linux.vnet.ibm.com



On 30/06/2016 14:53, Markus Armbruster wrote:
> +bad-header-comment := /* FIXME Does not pass make check-headers$(bad-header-with-y), yet!
> +bad-headers := $(shell cd $(SRC_PATH) && fgrep -l '$(bad-header-comment)' $(src-headers))
> +bad-headers += $(shell fgrep -l '$(bad-header-comment)' $(gen-headers))
> +# Headers that require -DNEED_CPU_H etc.
> +target-header-comment := /* NOTE: May only be included into target-dependent code */

Perhaps accept a "FIXME" as well here?  You don't have to use the right
one in the patch of course.

> diff --git a/target-sparc/cpu-qom.h b/target-sparc/cpu-qom.h
> index f63af72..30d112c 100644
> --- a/target-sparc/cpu-qom.h
> +++ b/target-sparc/cpu-qom.h
> @@ -17,6 +17,9 @@
>   * License along with this library; if not, see
>   * <http://www.gnu.org/licenses/lgpl-2.1.html>
>   */
> +
> +/* NOTE: May only be included into target-dependent code */

This shouldn't be true for cpu-qom.h.

Perhaps
Paolo

>  #ifndef QEMU_SPARC_CPU_QOM_H
>  #define QEMU_SPARC_CPU_QOM_H
>