From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D005C56202 for ; Fri, 20 Nov 2020 12:39:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1736E22227 for ; Fri, 20 Nov 2020 12:39:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BS5wsslV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1736E22227 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kg5hS-0005sk-GJ for qemu-devel@archiver.kernel.org; Fri, 20 Nov 2020 07:39:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kg5g7-0005Jr-Mi for qemu-devel@nongnu.org; Fri, 20 Nov 2020 07:38:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:42204) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kg5g4-00074h-Cs for qemu-devel@nongnu.org; Fri, 20 Nov 2020 07:38:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605875890; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1eRmgc9NWMA+7Ia1akiwuPm5DmB9nTXwclHpxwf/iBo=; b=BS5wsslVj/lRm4l3F4V+ZtZaJfZoD0FU4Yoi53PsM47RSJi1aNunVT12FfqmO4ZHNgY50/ 4SnZV+j9Wp+RpOMhZBOuFUq54wwv3tCQ6TAhkmkdyNqg54H4zCJU9tFX3IBjYmPKBFPSIN x7a8dua3GlG2H9E1DPGVab8mswWWgas= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-348-6c9WKqgnOkOXVwkMhgcXnQ-1; Fri, 20 Nov 2020 07:38:08 -0500 X-MC-Unique: 6c9WKqgnOkOXVwkMhgcXnQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 12DDF1876528 for ; Fri, 20 Nov 2020 12:38:08 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-135.ams2.redhat.com [10.36.112.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5C18D19C47; Fri, 20 Nov 2020 12:38:07 +0000 (UTC) Subject: Re: [PATCH] qtest: do not return freed argument vector from qtest_rsp To: Paolo Bonzini , qemu-devel@nongnu.org References: <20201120073149.99079-1-pbonzini@redhat.com> From: Thomas Huth Message-ID: <52f3190b-7a4a-046f-5708-c07093612895@redhat.com> Date: Fri, 20 Nov 2020 13:38:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201120073149.99079-1-pbonzini@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kamil Dudka Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 20/11/2020 08.31, Paolo Bonzini wrote: > If expected_args is 0, qtest frees the argument vector and then returns it > nevertheless. Coverity complains; in practice this is not an issue because > expected_args == 0 means that the caller is not interested in the argument > vector, but it would be a potential problem if somebody wanted to add > commands with optional arguments to qtest. > > Suggested-by: Kamil Dudka > Signed-off-by: Paolo Bonzini > --- > tests/qtest/libqtest.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c > index be0fb430dd..e49f3a1e45 100644 > --- a/tests/qtest/libqtest.c > +++ b/tests/qtest/libqtest.c > @@ -545,6 +545,7 @@ redo: > } > } else { > g_strfreev(words); > + words = NULL; > } > > return words; > Reviewed-by: Thomas Huth