From: Andrew Bennieston <andrew.bennieston@citrix.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: xen-devel@lists.xenproject.org, paul.durrant@citrix.com,
wei.liu2@citrix.com, ian.campbell@citrix.com,
netdev@vger.kernel.org
Subject: Re: [PATCH V3 net-next 3/5] xen-netfront: Factor queue-specific data into queue struct.
Date: Mon, 17 Feb 2014 11:10:23 +0000 [thread overview]
Message-ID: <5301EE1F.8080305__8346.27920198745$1392635557$gmane$org@citrix.com> (raw)
In-Reply-To: <52FE5AC6.9000300@citrix.com>
On 14/02/14 18:04, David Vrabel wrote:
> On 14/02/14 17:35, Andrew J. Bennieston wrote:
>> From: "Andrew J. Bennieston" <andrew.bennieston@citrix.com>
>>
>> In preparation for multi-queue support in xen-netfront, move the
>> queue-specific data from struct netfront_info to struct netfront_queue,
>> and update the rest of the code to use this.
>>
>> Also adds loops over queues where appropriate, even though only one is
>> configured at this point, and uses alloc_etherdev_mq() and the
>> corresponding multi-queue netif wake/start/stop functions in preparation
>> for multiple active queues.
>>
>> Finally, implements a trivial queue selection function suitable for
>> ndo_select_queue, which simply returns 0, selecting the first (and
>> only) queue.
> [...]
>> --- a/drivers/net/xen-netfront.c
>> +++ b/drivers/net/xen-netfront.c
> [...]
>> @@ -2048,17 +2196,27 @@ static const struct xenbus_device_id netfront_ids[] = {
> [...]
>> + for (i = 0; i < info->num_queues; ++i) {
>> + queue = &info->queues[i];
>> + del_timer_sync(&queue->rx_refill_timer);
>> + }
>> +
>> + if (info->num_queues) {
>> + kfree(info->queues);
>> + info->queues = NULL;
>> + }
>> +
>> xennet_sysfs_delif(info->netdev);
>>
>> unregister_netdev(info->netdev);
>>
>> - del_timer_sync(&info->rx_refill_timer);
>> -
>
> This has reordered the del_timer_sync() to before the
> unregister_netdev() call.
>
> Can you be sure that the timer cannot be restarted after deleting it?
>
> David
>
Looking at the code, mod_timer() is called from
xennet_alloc_rx_buffers(), only. This, in turn, is called from
xennet_poll, which is the registered NAPI handler function. This should
not be called after a napi_disable(), which is done in xennet_close().
xennet_close() is called to stop the interface, which should be done
before the module is removed (unless I'm mistaken here). So this should
be safe.
That said, there is no reason that the queue cleanup has to happen
before the unregister_netdev() call. I'll move it to after that point,
just to be safe.
-Andrew
next prev parent reply other threads:[~2014-02-17 11:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 17:35 [PATCH V3 net-next 0/5] xen-net{back, front}: Multiple transmit and receive queues Andrew J. Bennieston
2014-02-14 17:35 ` Andrew J. Bennieston
2014-02-14 17:35 ` [PATCH V3 net-next 1/5] xen-netback: Factor queue-specific data into queue struct Andrew J. Bennieston
2014-02-14 17:35 ` Andrew J. Bennieston
2014-02-14 17:35 ` [PATCH V3 net-next 2/5] xen-netback: Add support for multiple queues Andrew J. Bennieston
2014-02-14 17:35 ` Andrew J. Bennieston
2014-02-14 17:35 ` [PATCH V3 net-next 3/5] xen-netfront: Factor queue-specific data into queue struct Andrew J. Bennieston
2014-02-14 17:35 ` Andrew J. Bennieston
2014-02-14 18:04 ` David Vrabel
2014-02-14 18:04 ` [Xen-devel] " David Vrabel
2014-02-17 11:10 ` Andrew Bennieston
2014-02-17 11:10 ` Andrew Bennieston [this message]
2014-02-14 17:35 ` [PATCH V3 net-next 4/5] xen-netfront: Add support for multiple queues Andrew J. Bennieston
2014-02-14 17:35 ` Andrew J. Bennieston
2014-02-14 18:11 ` [Xen-devel] " David Vrabel
2014-02-14 18:11 ` David Vrabel
2014-02-14 17:35 ` [PATCH V3 net-next 5/5] xen-net{back, front}: Document multi-queue feature in netif.h Andrew J. Bennieston
2014-02-14 17:35 ` Andrew J. Bennieston
2014-02-14 18:23 ` [Xen-devel] " David Vrabel
2014-02-14 18:23 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='5301EE1F.8080305__8346.27920198745$1392635557$gmane$org@citrix.com' \
--to=andrew.bennieston@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.