From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFSRd-0006d0-Ox for qemu-devel@nongnu.org; Mon, 17 Feb 2014 12:57:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFSRZ-0002rS-0n for qemu-devel@nongnu.org; Mon, 17 Feb 2014 12:57:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:2578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFSRY-0002rL-PK for qemu-devel@nongnu.org; Mon, 17 Feb 2014 12:57:24 -0500 Message-ID: <53024D80.1020609@redhat.com> Date: Mon, 17 Feb 2014 10:57:20 -0700 From: Eric Blake MIME-Version: 1.0 References: <1392186806-10418-1-git-send-email-cyliu@suse.com> <1392186806-10418-13-git-send-email-cyliu@suse.com> In-Reply-To: <1392186806-10418-13-git-send-email-cyliu@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sCONat86A9drukF8Sahi3mb4uGJJkoB6b" Subject: Re: [Qemu-devel] [PATCH v20 12/26] qcow2.c: replace QEMUOptionParameter with QemuOpts in amend options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Dong Xu Wang , stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sCONat86A9drukF8Sahi3mb4uGJJkoB6b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/11/2014 11:33 PM, Chunyan Liu wrote: > qcow2.c: replace QEMUOptionParameter with QemuOpts in 'qemu-img amend' >=20 > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block.c | 4 +- > block/qcow2.c | 90 ++++++++++++++++++++-----------------= ------- > include/block/block.h | 2 +- > include/block/block_int.h | 2 +- > qemu-img.c | 17 ++++---- > 5 files changed, 53 insertions(+), 62 deletions(-) >=20 > @@ -2228,7 +2220,7 @@ static BlockDriver bdrv_qcow2 =3D { > .bdrv_open =3D qcow2_open, > .bdrv_close =3D qcow2_close, > .bdrv_reopen_prepare =3D qcow2_reopen_prepare, > - .bdrv_create2 =3D qcow2_create, > + .bdrv_create2 =3D qcow2_create, > .bdrv_has_zero_init =3D bdrv_has_zero_init_1, > .bdrv_co_get_block_status =3D qcow2_co_get_block_status, Might be worth aligning the =3D while touching this. > +++ b/include/block/block_int.h > @@ -229,7 +229,7 @@ struct BlockDriver { > BdrvCheckMode fix); > =20 > int (*bdrv_amend_options)(BlockDriverState *bs, > - QEMUOptionParameter *options); > + QemuOpts *opts); Indentation looks odd here; and with your change to shorter contents, you can just pull it into one line instead of wrapping and worrying about indentation in the first place. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --sCONat86A9drukF8Sahi3mb4uGJJkoB6b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTAk2AAAoJEKeha0olJ0NqLYUIAJ1vHPapgWtdoh9GgbA1Tc3L DPUESFnMhuOGbgTtoy5LjnLfHEkZIU19HUl3HS8O9P2JZdxL4JzqNs0Axf9xdYlI sAAhZ5tVdVokY24mPsNdfZLaGMLYR98lM+zQ96sxOsqBrBoS1QIijwmv2zp5sjWn d5NC3iniysZIAy5SDz0SEyYDb9mzAt3n5AdcepIafyd+qHITExtRcoznTUJZNQeq rz6uWbWrOH5XGlrP47/FtJ90ElVZTXh7BIsdOy4NSZkVhoGyCBWWVbsrGj9BPsJE yOqQpP5IEL6NfBOdNsjA+7nGUUHaYogihY7MBHqSVE6a/AIv9F0r2fAJTxAAckU= =sSh2 -----END PGP SIGNATURE----- --sCONat86A9drukF8Sahi3mb4uGJJkoB6b--