From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFSVR-0000Vr-92 for qemu-devel@nongnu.org; Mon, 17 Feb 2014 13:01:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFSVM-0004N5-S2 for qemu-devel@nongnu.org; Mon, 17 Feb 2014 13:01:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFSVM-0004Mz-KC for qemu-devel@nongnu.org; Mon, 17 Feb 2014 13:01:20 -0500 Message-ID: <53024E69.1080505@redhat.com> Date: Mon, 17 Feb 2014 11:01:13 -0700 From: Eric Blake MIME-Version: 1.0 References: <1392186806-10418-1-git-send-email-cyliu@suse.com> <1392186806-10418-14-git-send-email-cyliu@suse.com> In-Reply-To: <1392186806-10418-14-git-send-email-cyliu@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="It1MfvGVdGiKG9TkCw8LugmW14iQFqm7f" Subject: Re: [Qemu-devel] [PATCH v20 13/26] qed.c: replace QEMUOptionParameter with QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Dong Xu Wang , stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --It1MfvGVdGiKG9TkCw8LugmW14iQFqm7f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/11/2014 11:33 PM, Chunyan Liu wrote: > qed.c: replace QEMUOptionParameter with QemuOpts >=20 > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/qed.c | 89 +++++++++++++++++++++++++++++----------------------= -------- > block/qed.h | 3 +- > 2 files changed, 45 insertions(+), 47 deletions(-) >=20 > + cluster_size =3D qemu_opt_get_size_del(opts, > + BLOCK_OPT_CLUSTER_SIZE, > + QED_DEFAULT_CLUSTER_SIZE); > + table_size =3D qemu_opt_get_size_del(opts, BLOCK_OPT_TABLE_SIZE, > + QED_DEFAULT_TABLE_SIZE); > =20 > + { > + .name =3D BLOCK_OPT_CLUSTER_SIZE, > + .type =3D QEMU_OPT_SIZE, > + .help =3D "Cluster size (in bytes)", > + .def_value_str =3D stringify(QED_DEFAULT_CLUSTER_SIZE) > + }, > + { > + .name =3D BLOCK_OPT_TABLE_SIZE, > + .type =3D QEMU_OPT_SIZE, > + .help =3D "L1/L2 table size (in clusters)" > + }, Why does cluster size list a default, but table size does not? > +++ b/block/qed.h > @@ -43,7 +43,7 @@ > * > * All fields are little-endian on disk. > */ > - > +#define QED_DEFAULT_CLUSTER_SIZE 65536 > enum { > QED_MAGIC =3D 'Q' | 'E' << 8 | 'D' << 16 | '\0' << 24, > =20 > @@ -69,7 +69,6 @@ enum { > */ > QED_MIN_CLUSTER_SIZE =3D 4 * 1024, /* in bytes */ > QED_MAX_CLUSTER_SIZE =3D 64 * 1024 * 1024, > - QED_DEFAULT_CLUSTER_SIZE =3D 64 * 1024, Why this change? I actually prefer enums over #defines, because they behave nicer in gdb. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --It1MfvGVdGiKG9TkCw8LugmW14iQFqm7f Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTAk5pAAoJEKeha0olJ0NqGoIH/3a/rn5+Oz+RoSZvTn5Yotb+ LPuXwkyWyhkr8vfjE1y4LLpX7SfT/VtdeWmlpgqBHY3h9b1vQQVM447VAKWRCruM pbEYYDMikgyX4GfTpQUboqBjg8mNC5Ken9gDHCJcS9HZHJ2VcOCvW3y9ORDAL3Hg aCWQhsJvQ3gM/JHAKJ5ZNrkXWMdEZuXHoG93LbD9OlnFe5zEiX/PoCsvi0HP4Jiv qvQ7cxJ6dQy+PmeLoxbBmi5RwpWhjl/VN8zzmvH5kL0m7tzcZt7N0ayA1X+GtEMm xucf7L6DTtq6ZIKTqda/dguD5QeyDnMFz4Jn7Xsqo/ZFC42ZnkVic2k/PlSiycs= =wV+l -----END PGP SIGNATURE----- --It1MfvGVdGiKG9TkCw8LugmW14iQFqm7f--