From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFSmF-0007H9-GU for qemu-devel@nongnu.org; Mon, 17 Feb 2014 13:18:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFSmB-0001rK-45 for qemu-devel@nongnu.org; Mon, 17 Feb 2014 13:18:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:16240) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFSmA-0001rA-RL for qemu-devel@nongnu.org; Mon, 17 Feb 2014 13:18:43 -0500 Message-ID: <53025280.5050906@redhat.com> Date: Mon, 17 Feb 2014 11:18:40 -0700 From: Eric Blake MIME-Version: 1.0 References: <1392186806-10418-1-git-send-email-cyliu@suse.com> <1392186806-10418-15-git-send-email-cyliu@suse.com> In-Reply-To: <1392186806-10418-15-git-send-email-cyliu@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="00HP31EEn4Vpg46p5OAtIlPc1a0HD75ep" Subject: Re: [Qemu-devel] [PATCH v20 14/26] raw-posix.c: replace QEMUOptionParameter with QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Dong Xu Wang , stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --00HP31EEn4Vpg46p5OAtIlPc1a0HD75ep Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/11/2014 11:33 PM, Chunyan Liu wrote: > raw-posix.c: replace QEMUOptionParameter with QemuOpts >=20 > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/raw-posix.c | 58 ++++++++++++++++++++++++---------------------= ------- > 1 files changed, 27 insertions(+), 31 deletions(-) >=20 > @@ -2171,8 +2167,8 @@ static BlockDriver bdrv_host_cdrom =3D { > .bdrv_reopen_prepare =3D raw_reopen_prepare, > .bdrv_reopen_commit =3D raw_reopen_commit, > .bdrv_reopen_abort =3D raw_reopen_abort, > - .bdrv_create =3D hdev_create, > - .create_options =3D raw_create_options, > + .bdrv_create2 =3D hdev_create, > + .create_opts =3D &raw_create_opts, Everywhere else in the patch maintained or added consistency, but alignment of =3D here is off. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --00HP31EEn4Vpg46p5OAtIlPc1a0HD75ep Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTAlKAAAoJEKeha0olJ0NqVEkH/jAlDdYizSXcbE/Ml+YYi+vf ftXMEKakZKJfYVn8GXvrlu+XttAD3KQlayRlJzgWijM0xkx8Gk2yGxNL1Du8CcsY HFm/jggFDFdn2Z/poZaM3yRLsJPcn0FBlTQHnwDFXoOJz+34RIiOmBqSeXeVzMHj NOVT0Xw+5n1Bglf9wJB4NUym9skForbDhChr4OlDYEyykcDYB/eUVxLUAMv+dAWF PqIT8doCsLqw+fSdhvTH3HCJPMJ/vuW4rCbJSCqv1pmewxgtXvnjLi2/pvC1mC64 Z4wLFyrqqLXoJGrupGWJiECJwwdArjoPijSU+rNsoK+DORRNf2C20Po5/VZGo6M= =yaZy -----END PGP SIGNATURE----- --00HP31EEn4Vpg46p5OAtIlPc1a0HD75ep--