From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFXaN-0007NY-A4 for qemu-devel@nongnu.org; Mon, 17 Feb 2014 18:26:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFXaI-0000d1-TI for qemu-devel@nongnu.org; Mon, 17 Feb 2014 18:26:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11352) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFXaI-0000ct-Jl for qemu-devel@nongnu.org; Mon, 17 Feb 2014 18:26:46 -0500 Message-ID: <53029AB2.6010505@redhat.com> Date: Mon, 17 Feb 2014 16:26:42 -0700 From: Eric Blake MIME-Version: 1.0 References: <1392186806-10418-1-git-send-email-cyliu@suse.com> <1392186806-10418-20-git-send-email-cyliu@suse.com> In-Reply-To: <1392186806-10418-20-git-send-email-cyliu@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ExmDKdrbow170G23hPfnCaHsQGcHXpsKq" Subject: Re: [Qemu-devel] [PATCH v20 19/26] ssh.c: replace QEMUOptionParameter with QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Dong Xu Wang , stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ExmDKdrbow170G23hPfnCaHsQGcHXpsKq Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/11/2014 11:33 PM, Chunyan Liu wrote: > ssh.c: replace QEMUOptionParameter with QemuOpts >=20 > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/ssh.c | 31 +++++++++++++++---------------- > 1 files changed, 15 insertions(+), 16 deletions(-) >=20 > .bdrv_getlength =3D ssh_getlength, > .bdrv_co_flush_to_disk =3D ssh_co_flush, > - .create_options =3D ssh_create_options, > + .create_opts =3D &ssh_create_opts, More inconsistent &. I'll quit pointing it out. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ExmDKdrbow170G23hPfnCaHsQGcHXpsKq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTApqyAAoJEKeha0olJ0NqM3QH/2BVUd+sLf0EEcxh1xRUNN29 Phuq4d7n6P4mUAx4nzrSkcDbpZ4e9gEHbV/k6reEZw76ES9Oeooy0g81CZ87u8tD a1FK5ttrfsYot7UD439qUEr14SfoWN95kxC4QItxF70Z93hiBmXZmHgsIvtQNGR8 npANwP78VpNldPA53ozQhKUxEw+eIysHuWKpRzOmSy9MINWgZPzG4Pgz0XmOybFO M4GATTfu73QI9Y0YPYtiY/OBGCMCGK5sBPh5NAB8QKuzQMQgNkWO0JOTM+zDRsn0 hDOxQZhFwOv/JAII3SlUlbdbPxk9hZ4PNRG4PEhb87ro4mClpVveGtWugGNfw8g= =Ep6e -----END PGP SIGNATURE----- --ExmDKdrbow170G23hPfnCaHsQGcHXpsKq--