From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60682)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WFZJi-0007GT-Vu
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 20:17:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WFZJd-0007o7-VP
	for qemu-devel@nongnu.org; Mon, 17 Feb 2014 20:17:46 -0500
Message-ID: <5302B4B0.7050507@suse.de>
Date: Tue, 18 Feb 2014 02:17:36 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1392659611-8439-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1392659611-8439-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] hw/intc/exynos4210_combiner: Don't overrun
 output_irq array in init
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Evgeny Voevodin <e.voevodin@samsung.com>, patches@linaro.org, Igor Mitsyanko <i.mitsyanko@gmail.com>, qemu-stable <qemu-stable@nongnu.org>, Dmitry Solodkiy <d.solodkiy@samsung.com>, Maksim Kozlov <m.kozlov@samsung.com>

Am 17.02.2014 18:53, schrieb Peter Maydell:
> The Exynos4210 combiner has IIC_NIRQ inputs and IIC_NGRP outputs;
> use the correct constant in the loop initializing our output
> sysbus IRQs so that we don't overrun the output_irq[] array.
>=20
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  hw/intc/exynos4210_combiner.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/hw/intc/exynos4210_combiner.c b/hw/intc/exynos4210_combine=
r.c
> index ef5e8eb..3287479 100644
> --- a/hw/intc/exynos4210_combiner.c
> +++ b/hw/intc/exynos4210_combiner.c
> @@ -418,7 +418,7 @@ static int exynos4210_combiner_init(SysBusDevice *s=
bd)
>      qdev_init_gpio_in(dev, exynos4210_combiner_handler, IIC_NIRQ);
> =20
>      /* Connect SysBusDev irqs to device specific irqs */
> -    for (i =3D 0; i < IIC_NIRQ; i++) {
> +    for (i =3D 0; i < IIC_NGRP; i++) {

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

It seems that IIC_NIRQ =3D=3D IIC_NGRP * 8, so please don't forget to Cc
qemu-stable@nongnu.org in the commit message for 1.7.1.

Regards,
Andreas

>          sysbus_init_irq(sbd, &s->output_irq[i]);
>      }
> =20

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg