From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, tim@xen.org,
george.dunlap@citrix.com, stefano.stabellini@citrix.com
Subject: Re: [PATCH] xen/arm: Correctly handle non-page aligned pointer in raw_copy_*
Date: Tue, 18 Feb 2014 15:05:58 +0000 [thread overview]
Message-ID: <530376D6.9000704@linaro.org> (raw)
In-Reply-To: <1392735576.11080.87.camel@kazak.uk.xensource.com>
On 02/18/2014 02:59 PM, Ian Campbell wrote:
> On Fri, 2014-02-14 at 17:10 +0000, Julien Grall wrote:
>> The current implementation of raw_copy_* helpers may lead to data corruption
>> and sometimes Xen crash when the guest virtual address is not aligned to
>> PAGE_SIZE.
>
> Isn't a non-aligned address the vast majority of the cases (hypercall
> arguments on the guest stack)? How have we managed to get away with this
> for so long?
Because most of the time the size is smaller than 1 page. It not the
case with flask policy.
--
Julien Grall
prev parent reply other threads:[~2014-02-18 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 17:10 [PATCH] xen/arm: Correctly handle non-page aligned pointer in raw_copy_* Julien Grall
2014-02-14 17:35 ` Stefano Stabellini
2014-02-18 14:59 ` Ian Campbell
2014-02-18 15:00 ` Ian Campbell
2014-02-18 15:08 ` Julien Grall
2014-02-18 15:25 ` Ian Campbell
2014-02-18 15:29 ` Julien Grall
2014-02-18 15:05 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530376D6.9000704@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.