From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGC2N-00049n-BM for qemu-devel@nongnu.org; Wed, 19 Feb 2014 13:38:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGC2I-0000J4-UM for qemu-devel@nongnu.org; Wed, 19 Feb 2014 13:38:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:15864) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGC2I-0000Ig-Lh for qemu-devel@nongnu.org; Wed, 19 Feb 2014 13:38:22 -0500 Message-ID: <5304FA18.1060602@redhat.com> Date: Wed, 19 Feb 2014 11:38:16 -0700 From: Eric Blake MIME-Version: 1.0 References: <1392186806-10418-1-git-send-email-cyliu@suse.com> <1392186806-10418-24-git-send-email-cyliu@suse.com> In-Reply-To: <1392186806-10418-24-git-send-email-cyliu@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TeeTkgaX2aBTXjDHCUI48RRhnQwdTNf7l" Subject: Re: [Qemu-devel] [PATCH v20 23/26] vhdx.c: replace QEMUOptionParameter with QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Dong Xu Wang , stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TeeTkgaX2aBTXjDHCUI48RRhnQwdTNf7l Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/11/2014 11:33 PM, Chunyan Liu wrote: > vhdx.c: replace QEMUOptionParameter with QemuOpts >=20 > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/vhdx.c | 93 +++++++++++++++++++++++++++-----------------------= ------- > block/vhdx.h | 1 + > 2 files changed, 45 insertions(+), 49 deletions(-) >=20 > + image_size =3D qemu_opt_get_size_del(opts, BLOCK_OPT_SIZE, 0); > + log_size =3D qemu_opt_get_size_del(opts, VHDX_BLOCK_OPT_LOG_SIZE, = 0); > + block_size =3D qemu_opt_get_size_del(opts, VHDX_BLOCK_OPT_BLOCK_SI= ZE, 0); > + type =3D qemu_opt_get_del(opts, BLOCK_OPT_SUBFMT); > + use_zero_blocks =3D qemu_opt_get_bool_del(opts, VHDX_BLOCK_OPT_ZER= O, 0); s/0/false/ when passing a bool to qemu_opt_get_bool_del. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --TeeTkgaX2aBTXjDHCUI48RRhnQwdTNf7l Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTBPoYAAoJEKeha0olJ0NqoPIH/iiI9mQv4GjGLJheHRXdEmk3 za20QI4hIQAy4ajQBEdqjlizeISf1KGmJnfarEwfR0LRAZ3ninGweZDAHvfyldlU mA+mBF+/VooJ1pTIz0XMhk8ACfblDIhjN4NTbcNlrFne5oHgfVwzhiagSggiUehl 7/Z5H6KhQf1/aXHRAz2u+RYQbreAyRvm9W3HYrxFD5ufm8HN8EckxNC2JagBKs/f bxR6VQSdlWN5b8YuBswbhXCGwYdLIT7SjSu/jxnalAAeBQqxoIS3IfQ8p8VgRDZL AEutzGrPnEUVCdkJ8zTja0ykxIePvqhE+DhTbfOoUEXfcjna5LEXgWTsCqqW6dE= =AdsG -----END PGP SIGNATURE----- --TeeTkgaX2aBTXjDHCUI48RRhnQwdTNf7l--