From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42253) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGUFn-0004mI-II for qemu-devel@nongnu.org; Thu, 20 Feb 2014 09:05:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGUFh-0008SS-DC for qemu-devel@nongnu.org; Thu, 20 Feb 2014 09:05:31 -0500 Received: from mail-pd0-f178.google.com ([209.85.192.178]:50986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGUFh-0008S4-7J for qemu-devel@nongnu.org; Thu, 20 Feb 2014 09:05:25 -0500 Received: by mail-pd0-f178.google.com with SMTP id fp1so1849737pdb.23 for ; Thu, 20 Feb 2014 06:05:24 -0800 (PST) Message-ID: <53060B9C.7000404@ozlabs.ru> Date: Fri, 21 Feb 2014 01:05:16 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1392904246-15575-1-git-send-email-aik@ozlabs.ru> <53060A17.4010901@redhat.com> In-Reply-To: <53060A17.4010901@redhat.com> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 0/6] spapr: bootindex support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Alexander Graf , Andreas Faerber On 02/21/2014 12:58 AM, Paolo Bonzini wrote: > Il 20/02/2014 14:50, Alexey Kardashevskiy ha scritto: >> This time I grouped patches into 2 groups - the first 3 patches >> are platform independent and last 3 are for sPAPR machine. Not many updates, >> just some code style fixes and rebased on top of qemu.org/master + >> agraf/ppc-next. >> >> Please comment. Thanks. > > Good, but S-o-b in patch 3 is missing. Why does it matter? It is your patch, it will go through someone else's tree and I just reposted it - I could have added "Reviewed-by" or "Tested-by" or "Acked-by", but SOB... > > Paolo > >> >> Alexey Kardashevskiy (5): >> boot: extend get_boot_devices_list() to ignore suffixes >> qdev: introduce FWPathProvider interface >> spapr-llan: add to boot device list >> spapr-vio: fix firmware names >> spapr: define interface to fix device pathname >> >> Paolo Bonzini (1): >> vl: allow customizing the class of /machine >> >> hw/core/Makefile.objs | 1 + >> hw/core/fw-path-provider.c | 51 +++++++++++++++++++++ >> hw/core/qdev.c | 18 +++++++- >> hw/net/spapr_llan.c | 3 ++ >> hw/nvram/fw_cfg.c | 2 +- >> hw/ppc/spapr.c | 103 >> +++++++++++++++++++++++++++++++++++++++++- >> hw/ppc/spapr_vio.c | 3 ++ >> include/hw/boards.h | 1 + >> include/hw/fw-path-provider.h | 49 ++++++++++++++++++++ >> include/sysemu/sysemu.h | 2 +- >> tests/Makefile | 1 + >> vl.c | 13 ++++-- >> 12 files changed, 240 insertions(+), 7 deletions(-) >> create mode 100644 hw/core/fw-path-provider.c >> create mode 100644 include/hw/fw-path-provider.h >> > -- Alexey