From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiang Liu Subject: Re: [PATCH v5 10/33] iommu, irq: Allocate irq_desc for dmar_msi with local node Date: Sat, 22 Feb 2014 23:33:23 +0800 Message-ID: <5308C343.5040102@linux.intel.com> References: <1388707565-16535-1-git-send-email-yinghai@kernel.org> <1388707565-16535-11-git-send-email-yinghai@kernel.org> <53070393.5020005@linux.intel.com> <53081614.4020503@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: stable-owner@vger.kernel.org To: Yinghai Lu Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Tony Luck , Bjorn Helgaas , "Rafael J. Wysocki" , "linux-pci@vger.kernel.org" , Linux Kernel Mailing List , ACPI Devel Maling List , Joerg Roedel , Donald Dutile , Sebastian Andrzej Siewior , "stable@vger.kernel.org" List-Id: linux-acpi@vger.kernel.org Hi Yinghai, I have a plan to test this patch set once I have reviewed all patches in coming weeks. Do you have a plan to update to latest kernel or is it ok to test this version? Thanks! Gerry On 2014/2/22 15:44, Yinghai Lu wrote: > On Fri, Feb 21, 2014 at 7:14 PM, Jiang Liu wrote: > >> Seems there is no such protection on IA64 side. I feel create_irq_nr() >> returns 0 for error is a little risky, 0 may be >> a valid IRQ number on other platforms(no sure about this). >> Thanks! > > in [PATCH] ia64, irq: Add dummy create_irq_nr() > > +unsigned int create_irq_nr(unsigned int from, int node) > +{ > + int irq = create_irq(); > + > + if (irq < 0) > + irq = 0; > + > + return irq; > +} > + > > so that from is ignored. > > create_irq_nr() is only with x86 and ia64. > > Thanks > > Yinghai >