From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80BB9C7EE2D for ; Mon, 27 Feb 2023 08:26:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t9lsz7N24Ssy/Vj6qO0dYglcw+RsCknKTz5RdMDl9ZI=; b=d1gfJcDFCxRLLd 6PBc9J8ZSU0IZ45Ce/8uPDAEiURQ8NSFh7WSSS7qhrSulYMzIo8382x49oDadEBJoGt7vn2fUDRuK aOvmB7px6zvHC7AXgMErN0HXybJ955JelsOr267WXmibde8wgM3h3FkDFNOOhtVbVpeDfCqlpih57 PawWi7yoI3AAMxA7+bUcVeFyKZkBUkMMDz/fePjOznGs0XfWDWdNP6aCefuIFAjAdROWYGdvYJkZU ygaxuFMCjiX3bFl3fr9ag71gFUlVvE5cRBN1qQBdjcBR3j5wqAJ6NEj02VfSV3Gfn1TGrHfDaDG7I n2A96P9G1JCK9txD9GzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWYpF-008pDB-JN; Mon, 27 Feb 2023 08:25:37 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWYpA-008pBV-Rv for linux-arm-kernel@lists.infradead.org; Mon, 27 Feb 2023 08:25:34 +0000 Received: by mail-wr1-x430.google.com with SMTP id bv17so5255450wrb.5 for ; Mon, 27 Feb 2023 00:25:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f7wawcQch3lNu+MG0Wy2sQLlrBSIfPCFFDnZ1A7TraE=; b=pHnoMo8xE+1HtXKcjUR26tXhOt//H0eiEimGk9ipnhjjM7zKxZclB5EAYneTx0PEmN ER82JRtpkYSpUrd9t5HuGN1bzO/Sfd6T+IdLacmQFM6ofpnZWxH1PbRuVuNvxLDW1kgi xR5Hgz1ya9Y4rqXYEYCWekO/OmoZaAZypSFl2Qhsn5OLzZ8NdWns9B8ji63tr49c2H1T OhMit2X0P5Wmz4Pezz8bZectgG7+SlY9QNb+LxJfg2IuAX35TrwlCtNYciJo5BTNJP+D EWr7k/CWEwKRChWA4Z1nGDFEUP4LdDnOIPwRIdvR+xYqFa1CnrcLHJnRiauOrjsk+hRa MsaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f7wawcQch3lNu+MG0Wy2sQLlrBSIfPCFFDnZ1A7TraE=; b=lA8kl1XgzojqHcgBWiZd6fYXuAZ79Gt8j4KkSZkwrK11v+m48T5QItOiWzfsqQk4p3 yH6cnfI3w1Yj05SN6qD06ovA91C9CY8SCPd1Mtj8dCyv6BIGmBs2JBdDIsWvbgqcAEl3 IEGTQxwawASqiu/wn6z/RJk0lHwKkQHaVO7emopT1Uqzg6Ay6MW1KKls5TCfoAN8RmMs iaZuKupaz6ojj1aFzDUHlkRQshlav1dKO4lTYjwRbFGX+3U3I/tXi+4+Fb581P+E8sCX 8Evzo2x0wnUhQtqUpDoWX6MPhisf66ucbh9AjvI95rRPCJRX2tPvTwv8CUhrxqQEp5Eq f+Tw== X-Gm-Message-State: AO0yUKXC61ppzsC6AyyLR38kBxJrjw3549+Ft5J/OFPvJvFBIPf8Q5Xy DMS5X+d36dQCkumQUaaFRCbnvg== X-Google-Smtp-Source: AK7set8msDbkhhTp2CHF66KjjFwBil0QNBCibqKaWkpjsyR0NI0l2qa6mBCMtcy9ziB1IY0cJmvegw== X-Received: by 2002:a5d:4708:0:b0:2cb:3b68:3c1c with SMTP id y8-20020a5d4708000000b002cb3b683c1cmr3439137wrq.14.1677486331251; Mon, 27 Feb 2023 00:25:31 -0800 (PST) Received: from [192.168.1.20] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id r14-20020adff70e000000b002c567881dbcsm6381961wrp.48.2023.02.27.00.25.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 00:25:30 -0800 (PST) Message-ID: <53090449-58c9-bc03-56df-aa8ae93c0c26@linaro.org> Date: Mon, 27 Feb 2023 09:25:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 Content-Language: en-US To: Ryan Chen , Andrew Jeffery , Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Rob Herring , Krzysztof Kozlowski , Philipp Zabel , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20230226031321.3126756-1-ryan_chen@aspeedtech.com> <20230226031321.3126756-2-ryan_chen@aspeedtech.com> From: Krzysztof Kozlowski In-Reply-To: <20230226031321.3126756-2-ryan_chen@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230227_002532_958125_6789FD50 X-CRM114-Status: GOOD ( 18.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/02/2023 04:13, Ryan Chen wrote: > Add ast2600-i2cv2 compatible and aspeed,global-regs, aspeed,timeout > aspeed,xfer-mode description for ast2600-i2cv2. > > Signed-off-by: Ryan Chen > --- > .../devicetree/bindings/i2c/aspeed,i2c.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > index f597f73ccd87..75de3ce41cf5 100644 > --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > @@ -49,6 +49,25 @@ properties: > description: > states that there is another master active on this bus > > + aspeed,timeout: > + type: boolean > + description: I2C bus timeout enable for master/slave mode Nothing improved here in regards to my last comment. > + > + aspeed,xfer-mode: > + description: | > + I2C bus transfer mode selection. > + - "byte": I2C bus byte transfer mode. > + - "buffered": I2C bus buffer register transfer mode. > + - "dma": I2C bus dma transfer mode (default) > + items: > + enum: [byte, buffered, dma] > + maxItems: 1 Drop, not an array. > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array Wrong ref. This is not an array, but one string. > + > + aspeed,global-regs: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of i2c global register node. > + > required: > - reg > - compatible > @@ -57,6 +76,19 @@ required: > > unevaluatedProperties: false > > +if: This should be under allOf (in this location) > + properties: > + compatible: > + contains: > + const: aspeed,ast2600-i2cv2 > + > +then: > + properties: > + reg: > + minItems: 2 > + required: > + - aspeed,global-regs else: aspeed,global-regs: false and the same for other v2 properties > + > examples: > - | > #include > @@ -71,3 +103,15 @@ examples: > interrupts = <0>; > interrupt-parent = <&i2c_ic>; > }; > + - | > + #include > + i2c1: i2c@80 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "aspeed,ast2600-i2cv2"; > + reg = <0x80 0x80>, <0xc00 0x20>; > + interrupts = ; > + aspeed,global-regs = <&i2c_global>; > + clocks = <&syscon ASPEED_CLK_APB>; > + resets = <&syscon ASPEED_RESET_I2C>; > + }; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68646C64ED6 for ; Mon, 27 Feb 2023 08:32:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230299AbjB0Icy (ORCPT ); Mon, 27 Feb 2023 03:32:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232310AbjB0IbG (ORCPT ); Mon, 27 Feb 2023 03:31:06 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A062D21A02 for ; Mon, 27 Feb 2023 00:27:43 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id l1so2195532wry.12 for ; Mon, 27 Feb 2023 00:27:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f7wawcQch3lNu+MG0Wy2sQLlrBSIfPCFFDnZ1A7TraE=; b=pHnoMo8xE+1HtXKcjUR26tXhOt//H0eiEimGk9ipnhjjM7zKxZclB5EAYneTx0PEmN ER82JRtpkYSpUrd9t5HuGN1bzO/Sfd6T+IdLacmQFM6ofpnZWxH1PbRuVuNvxLDW1kgi xR5Hgz1ya9Y4rqXYEYCWekO/OmoZaAZypSFl2Qhsn5OLzZ8NdWns9B8ji63tr49c2H1T OhMit2X0P5Wmz4Pezz8bZectgG7+SlY9QNb+LxJfg2IuAX35TrwlCtNYciJo5BTNJP+D EWr7k/CWEwKRChWA4Z1nGDFEUP4LdDnOIPwRIdvR+xYqFa1CnrcLHJnRiauOrjsk+hRa MsaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f7wawcQch3lNu+MG0Wy2sQLlrBSIfPCFFDnZ1A7TraE=; b=FLsz8XT5tsT0t7k0k+8TIoUdrIJ2w810LGS/0pEPrkWnfxFdACfuMzUhydmmhqG577 9dgrvaA70gy7sHCueusiZ1EZG8EOElfvj7AS/X4GAfjjTqFmxC/qSucMWnsP5AlAIk/G tv+4cti+1p0lmEuQWg4M3by1tbURO55UrCbn3RZOXJ2mr39MLeVaAFu4ZLteDk0STnrZ N/FvVvUGJiPJ0C3Ps5yShEXzDdkJMWJQp2mR4hDO6W6zeQZJhVUE7KeW95mNcsBgcHeA JrwmQP0a49BCnut+6uEglCbdhwpbHGYWDY0lHJVY60ibZT6Mg2dJBFnGiCjCDcW/oQyJ evTA== X-Gm-Message-State: AO0yUKVHD2oBRVSlIiQopGQRlH9l0upWgfUoQTYgBp4/OgpuHohCrDAp 5XySVrO6HMfZnp5MnJBgbQNLmg== X-Google-Smtp-Source: AK7set8msDbkhhTp2CHF66KjjFwBil0QNBCibqKaWkpjsyR0NI0l2qa6mBCMtcy9ziB1IY0cJmvegw== X-Received: by 2002:a5d:4708:0:b0:2cb:3b68:3c1c with SMTP id y8-20020a5d4708000000b002cb3b683c1cmr3439137wrq.14.1677486331251; Mon, 27 Feb 2023 00:25:31 -0800 (PST) Received: from [192.168.1.20] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id r14-20020adff70e000000b002c567881dbcsm6381961wrp.48.2023.02.27.00.25.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 00:25:30 -0800 (PST) Message-ID: <53090449-58c9-bc03-56df-aa8ae93c0c26@linaro.org> Date: Mon, 27 Feb 2023 09:25:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 Content-Language: en-US To: Ryan Chen , Andrew Jeffery , Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Rob Herring , Krzysztof Kozlowski , Philipp Zabel , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20230226031321.3126756-1-ryan_chen@aspeedtech.com> <20230226031321.3126756-2-ryan_chen@aspeedtech.com> From: Krzysztof Kozlowski In-Reply-To: <20230226031321.3126756-2-ryan_chen@aspeedtech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/02/2023 04:13, Ryan Chen wrote: > Add ast2600-i2cv2 compatible and aspeed,global-regs, aspeed,timeout > aspeed,xfer-mode description for ast2600-i2cv2. > > Signed-off-by: Ryan Chen > --- > .../devicetree/bindings/i2c/aspeed,i2c.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > index f597f73ccd87..75de3ce41cf5 100644 > --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > @@ -49,6 +49,25 @@ properties: > description: > states that there is another master active on this bus > > + aspeed,timeout: > + type: boolean > + description: I2C bus timeout enable for master/slave mode Nothing improved here in regards to my last comment. > + > + aspeed,xfer-mode: > + description: | > + I2C bus transfer mode selection. > + - "byte": I2C bus byte transfer mode. > + - "buffered": I2C bus buffer register transfer mode. > + - "dma": I2C bus dma transfer mode (default) > + items: > + enum: [byte, buffered, dma] > + maxItems: 1 Drop, not an array. > + $ref: /schemas/types.yaml#/definitions/non-unique-string-array Wrong ref. This is not an array, but one string. > + > + aspeed,global-regs: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of i2c global register node. > + > required: > - reg > - compatible > @@ -57,6 +76,19 @@ required: > > unevaluatedProperties: false > > +if: This should be under allOf (in this location) > + properties: > + compatible: > + contains: > + const: aspeed,ast2600-i2cv2 > + > +then: > + properties: > + reg: > + minItems: 2 > + required: > + - aspeed,global-regs else: aspeed,global-regs: false and the same for other v2 properties > + > examples: > - | > #include > @@ -71,3 +103,15 @@ examples: > interrupts = <0>; > interrupt-parent = <&i2c_ic>; > }; > + - | > + #include > + i2c1: i2c@80 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "aspeed,ast2600-i2cv2"; > + reg = <0x80 0x80>, <0xc00 0x20>; > + interrupts = ; > + aspeed,global-regs = <&i2c_global>; > + clocks = <&syscon ASPEED_CLK_APB>; > + resets = <&syscon ASPEED_RESET_I2C>; > + }; Best regards, Krzysztof