From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH] clk: Correct handling of NULL clk in __clk_{get, put} Date: Mon, 24 Feb 2014 13:59:33 +0100 Message-ID: <530B4235.6070108@samsung.com> References: <1389096223-23934-1-git-send-email-s.nawrocki@samsung.com> <52CFC5C9.4000006@samsung.com> <52F8E9E8.8060408@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:64126 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509AbaBXM7k (ORCPT ); Mon, 24 Feb 2014 07:59:40 -0500 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N1I006PN439D270@mailout2.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Mon, 24 Feb 2014 12:59:34 +0000 (GMT) In-reply-to: <52F8E9E8.8060408@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Sylwester Nawrocki , Mike Turquette Cc: Sachin Kamat , linux-samsung-soc , linux-arm-kernel , Tomasz Figa Mike, On 10.02.2014 16:02, Sylwester Nawrocki wrote: > On 30/01/14 05:50, Sachin Kamat wrote: >> On 10 January 2014 15:34, Sylwester Nawrocki wrote: >>>> On 08/01/14 05:44, Sachin Kamat wrote: >>>>>> Hi Sylwester, >>>>>> >>>>>> On 7 January 2014 17:33, Sylwester Nawrocki wrote: >>>>>>>> Ensure clk->kref is dereferenced only when clk is not NULL. >>>>>>>> >>>>>>>> Signed-off-by: Sylwester Nawrocki >>>>>>>> --- >>>>>>>> Hi Sachin, >>>>>>>> >>>>>>>> please try if this patch fixes the exyno5420 boot crash. >>>>>> >>>>>> Confirmed that this patch works fine on 5420 as well as already >>>>>> working 4210 and 5250 boards. >>>>>> Thanks for the quick fix. >>>>>> >>>>>> Tested-by: Sachin Kamat >>>> >>>> Thanks Sachin. Mike, it seems we need this patch on top of >>>> my clk-unregister branch. Sorry for overlooking this issue. >>>> Could you add the $subject patch to your clk-next tree ? >> >> Gentle ping Mike. Hope we can have this patch in rc-2. > > A gentle reminder, this patch is still not in current -rc and is required > to fix booting of some exynos platforms. It's been one and a half of a month since Sylwester posted this patch. Sorry for nagging, but for this whole period we've been observing complete breakage of several platforms, including Exynos4412-Trats2 board, due to NULL pointer dereference at boot-up time, so I'd consider this patch a _critical_ fix. Can we expect this patch to be applied to your tree and sent for next rc release or I should apply it to my tree and send a pull request to Linus directly? Best regards, Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: t.figa@samsung.com (Tomasz Figa) Date: Mon, 24 Feb 2014 13:59:33 +0100 Subject: [PATCH] clk: Correct handling of NULL clk in __clk_{get, put} In-Reply-To: <52F8E9E8.8060408@samsung.com> References: <1389096223-23934-1-git-send-email-s.nawrocki@samsung.com> <52CFC5C9.4000006@samsung.com> <52F8E9E8.8060408@samsung.com> Message-ID: <530B4235.6070108@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Mike, On 10.02.2014 16:02, Sylwester Nawrocki wrote: > On 30/01/14 05:50, Sachin Kamat wrote: >> On 10 January 2014 15:34, Sylwester Nawrocki wrote: >>>> On 08/01/14 05:44, Sachin Kamat wrote: >>>>>> Hi Sylwester, >>>>>> >>>>>> On 7 January 2014 17:33, Sylwester Nawrocki wrote: >>>>>>>> Ensure clk->kref is dereferenced only when clk is not NULL. >>>>>>>> >>>>>>>> Signed-off-by: Sylwester Nawrocki >>>>>>>> --- >>>>>>>> Hi Sachin, >>>>>>>> >>>>>>>> please try if this patch fixes the exyno5420 boot crash. >>>>>> >>>>>> Confirmed that this patch works fine on 5420 as well as already >>>>>> working 4210 and 5250 boards. >>>>>> Thanks for the quick fix. >>>>>> >>>>>> Tested-by: Sachin Kamat >>>> >>>> Thanks Sachin. Mike, it seems we need this patch on top of >>>> my clk-unregister branch. Sorry for overlooking this issue. >>>> Could you add the $subject patch to your clk-next tree ? >> >> Gentle ping Mike. Hope we can have this patch in rc-2. > > A gentle reminder, this patch is still not in current -rc and is required > to fix booting of some exynos platforms. It's been one and a half of a month since Sylwester posted this patch. Sorry for nagging, but for this whole period we've been observing complete breakage of several platforms, including Exynos4412-Trats2 board, due to NULL pointer dereference at boot-up time, so I'd consider this patch a _critical_ fix. Can we expect this patch to be applied to your tree and sent for next rc release or I should apply it to my tree and send a pull request to Linus directly? Best regards, Tomasz