All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ionut Nicu <ioan.nicu.ext@nsn.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Regression][ext4] Regression at EXT4 filesystem code
Date: Mon, 24 Feb 2014 17:42:59 +0100	[thread overview]
Message-ID: <530B7693.3030201@nsn.com> (raw)
In-Reply-To: <20140224161359.5309e540@amdc2363>


Hi,

On 24.02.2014 16:13, ext Lukasz Majewski wrote:
> Dear All,
> 
> In the newest master u-boot 
> (SHA1: 1674df60d17e0e72396c961d5390bb62b184ad95)
> 
> I've found a regression with writing to EXT4 file system:
> 
> Writing uImage to ext4 partition - created with Debian's
> mkfs.ext4 /dev/sdd2 (size 58M)
> 
> dfu-util -R -a2 -D arch/arm/boot/uImage
> uImage size - 4.8 MiB
> 
> GADGET DRIVER: usb_dnl_dfu
> USB PHY0 Enable
> #Extent Error
> ext4fs_devread read outside partition 4294967294
> Extent Error
> 

Ugh ... It's pretty stupid, but my patch is completely ignoring the write path.
The error occurs because in read_allocated_block() I'm trying to use the extent
cache, but this extent cache is only built in ext4fs_read_file().

> 
> After reverting following patch:
> 
> Commit: "ext4fs: Add ext4 extent cache for read operations"
> SHA1: fc0fc50f38a4d7d0554558076a79dfe8b0d78cd5
> 
> I am able to store files on the ext4 partition:	
> 
> USB PHY0 Enable
> #File System is consistent
> file found deleting
> update journal finished
> File System is consistent
> update journal finished
> 
> DFU complete CRC32: 0x3875a108
> DOWNLOAD ... OK
> Ctrl+C to exit ...
> resetting ...
> 
> 
> Any ideas how to fix it?
> 

I guess the best solution for the moment is to revert the patch and I'll try to 
come up with an updated version which doesn't break the write functionality.

Sorry about this.

Regards,
Ionut

  reply	other threads:[~2014-02-24 16:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-04 14:48 [U-Boot] [PATCH v2] ext4fs: Add ext4 extent cache for read operations Ionut Nicu
2014-02-21 19:57 ` [U-Boot] [U-Boot, " Tom Rini
2014-02-24 15:13 ` [U-Boot] [Regression][ext4] Regression at EXT4 filesystem code Lukasz Majewski
2014-02-24 16:42   ` Ionut Nicu [this message]
2014-02-26 13:20     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530B7693.3030201@nsn.com \
    --to=ioan.nicu.ext@nsn.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.