From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WICc3-0005YL-Tu for qemu-devel@nongnu.org; Tue, 25 Feb 2014 02:39:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WICbx-000661-Tm for qemu-devel@nongnu.org; Tue, 25 Feb 2014 02:39:35 -0500 Received: from cantor2.suse.de ([195.135.220.15]:35623 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WICbx-00065x-N8 for qemu-devel@nongnu.org; Tue, 25 Feb 2014 02:39:29 -0500 Message-ID: <530C48AC.4060107@suse.de> Date: Tue, 25 Feb 2014 08:39:24 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1393302864-11348-1-git-send-email-bsd@redhat.com> <1393302864-11348-2-git-send-email-bsd@redhat.com> In-Reply-To: <1393302864-11348-2-git-send-email-bsd@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2 v3] qdev-monitor: set DeviceState opts before calling realize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bandan Das , qemu-devel@nongnu.org Cc: Paolo Bonzini , Alex Williamson , Amos Kong , Markus Armbruster , "Michael S. Tsirkin" Am 25.02.2014 05:34, schrieb Bandan Das: > Setting opts before the realize property is set allows the > following patch to make decisions based on whether the user > specified "rombar". This also avoids having to create a new > tristate property especially for this purpose >=20 > Signed-off-by: Bandan Das > --- > qdev-monitor.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Makes perfect sense, Reviewed-by: Andreas F=E4rber Queuing a copy on qom-next to avoid conflicts with a v2 for Amos' link<> issue. Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg