From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [V1 PATCH 1/3] pvh: early return from hvm_hap_nested_page_fault Date: Tue, 25 Feb 2014 09:26:01 +0000 Message-ID: <530C6FB9020000780011F0D6@nat28.tlf.novell.com> References: <1393290237-28427-1-git-send-email-mukesh.rathor@oracle.com> <1393290237-28427-2-git-send-email-mukesh.rathor@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WIEHC-0006gF-0Y for xen-devel@lists.xenproject.org; Tue, 25 Feb 2014 09:26:10 +0000 In-Reply-To: <1393290237-28427-2-git-send-email-mukesh.rathor@oracle.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Mukesh Rathor Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org >>> On 25.02.14 at 02:03, Mukesh Rathor wrote: > pvh does not support nested hvm at present. As such, return if pvh. > > Signed-off-by: Mukesh Rathor > --- > xen/arch/x86/hvm/hvm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c > index 69f7e74..a4a3dcf 100644 > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -1416,6 +1416,9 @@ int hvm_hap_nested_page_fault(paddr_t gpa, > int sharing_enomem = 0; > mem_event_request_t *req_ptr = NULL; > > + if ( is_pvh_vcpu(v) ) > + return 0; > + Afaict the "nested" in the function name means "nested paging", not "nested virtualization", i.e. the function here handles more than just nested HVM cases. With that, the change appears to be wrong. What's the motivation for putting such a check here anyway? Jan