From: Mark Tinguely <tinguely@sgi.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Boris Ranto <branto@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_metadump: include F in getopts string
Date: Tue, 25 Feb 2014 11:36:11 -0600 [thread overview]
Message-ID: <530CD48B.5000100@sgi.com> (raw)
In-Reply-To: <530CC371.8030005@redhat.com>
On 02/25/14 10:23, Eric Sandeen wrote:
> I added an F case, but didn't add it to the bash
> getopts string last go-round.
>
> /usr/sbin/xfs_metadump: illegal option -- F
>
> I sure thought I tested this, I'm not sure how it got lost.
>
> Reported-by: Boris Ranto<branto@redhat.com>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---
>
> diff --git a/db/xfs_metadump.sh b/db/xfs_metadump.sh
> index 7ce7a6d..71f579d 100755
> --- a/db/xfs_metadump.sh
> +++ b/db/xfs_metadump.sh
> @@ -7,7 +7,7 @@ OPTS=" "
> DBOPTS=" "
> USAGE="Usage: xfs_metadump [-efFogwV] [-m max_extents] [-l logdev] source target"
>
> -while getopts "efgl:m:owV" c
> +while getopts "efgl:m:owFV" c
> do
> case $c in
> e) OPTS=$OPTS"-e ";;
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-25 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 16:23 [PATCH] xfs_metadump: include F in getopts string Eric Sandeen
2014-02-25 17:36 ` Mark Tinguely [this message]
2014-02-25 22:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530CD48B.5000100@sgi.com \
--to=tinguely@sgi.com \
--cc=branto@redhat.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.