From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH 4/6] s390x: Add I/O adapter registration. Date: Wed, 26 Feb 2014 09:29:12 +0100 Message-ID: <530DA5D8.6040909@de.ibm.com> References: <1393349120-18228-1-git-send-email-cornelia.huck@de.ibm.com> <1393349120-18228-5-git-send-email-cornelia.huck@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1393349120-18228-5-git-send-email-cornelia.huck@de.ibm.com> Sender: kvm-owner@vger.kernel.org List-Archive: List-Post: To: Cornelia Huck , kvm@vger.kernel.org, linux-s390@vger.kernel.org, qemu-devel@nongnu.org Cc: agraf@suse.de, pbonzini@redhat.com, gleb@kernel.org List-ID: On 25/02/14 18:25, Cornelia Huck wrote: > +int kvm_s390_io_adapter_map(uint32_t id, uint64_t map_addr, bool do_map) > +{ > + struct kvm_s390_io_adapter_req req = { > + .id = id, > + .type = do_map ? KVM_S390_IO_ADAPTER_MAP : KVM_S390_IO_ADAPTER_UNMAP, > + .addr = map_addr, > + }; > + KVMS390FLICState *flic = s390_get_flic(); > + struct kvm_device_attr attr; Can we use designated initializer for attr, e.g. struct kvm_device_attr attr = { .group = KVM_DEV_FLIC_ADAPTER_MODIFY, .addr = (uint64_t)&req, } > + int r; > + > + if (!flic) { > + return -ENOSYS; > + } > + if (!kvm_check_extension(kvm_state, KVM_CAP_IRQ_ROUTING)) { > + return -ENOSYS; > + } > + > + attr.group = KVM_DEV_FLIC_ADAPTER_MODIFY; > + attr.addr = (uint64_t)&req; and not do it here. That will zero out the other fields of attr. Same for the register code. Christian From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIZru-00081O-SI for qemu-devel@nongnu.org; Wed, 26 Feb 2014 03:29:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WIZrl-00057V-SJ for qemu-devel@nongnu.org; Wed, 26 Feb 2014 03:29:30 -0500 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:44328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIZrl-00057Q-2z for qemu-devel@nongnu.org; Wed, 26 Feb 2014 03:29:21 -0500 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 26 Feb 2014 08:29:18 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id AEF7117D805C for ; Wed, 26 Feb 2014 08:29:48 +0000 (GMT) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s1Q8T3vH27918584 for ; Wed, 26 Feb 2014 08:29:03 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s1Q8TEO1019224 for ; Wed, 26 Feb 2014 01:29:15 -0700 Message-ID: <530DA5D8.6040909@de.ibm.com> Date: Wed, 26 Feb 2014 09:29:12 +0100 From: Christian Borntraeger MIME-Version: 1.0 References: <1393349120-18228-1-git-send-email-cornelia.huck@de.ibm.com> <1393349120-18228-5-git-send-email-cornelia.huck@de.ibm.com> In-Reply-To: <1393349120-18228-5-git-send-email-cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/6] s390x: Add I/O adapter registration. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , kvm@vger.kernel.org, linux-s390@vger.kernel.org, qemu-devel@nongnu.org Cc: gleb@kernel.org, pbonzini@redhat.com, agraf@suse.de On 25/02/14 18:25, Cornelia Huck wrote: > +int kvm_s390_io_adapter_map(uint32_t id, uint64_t map_addr, bool do_map) > +{ > + struct kvm_s390_io_adapter_req req = { > + .id = id, > + .type = do_map ? KVM_S390_IO_ADAPTER_MAP : KVM_S390_IO_ADAPTER_UNMAP, > + .addr = map_addr, > + }; > + KVMS390FLICState *flic = s390_get_flic(); > + struct kvm_device_attr attr; Can we use designated initializer for attr, e.g. struct kvm_device_attr attr = { .group = KVM_DEV_FLIC_ADAPTER_MODIFY, .addr = (uint64_t)&req, } > + int r; > + > + if (!flic) { > + return -ENOSYS; > + } > + if (!kvm_check_extension(kvm_state, KVM_CAP_IRQ_ROUTING)) { > + return -ENOSYS; > + } > + > + attr.group = KVM_DEV_FLIC_ADAPTER_MODIFY; > + attr.addr = (uint64_t)&req; and not do it here. That will zero out the other fields of attr. Same for the register code. Christian