From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46689)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1WJD0m-0007OQ-Lh
	for qemu-devel@nongnu.org; Thu, 27 Feb 2014 21:17:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1WJD0h-0002FB-9N
	for qemu-devel@nongnu.org; Thu, 27 Feb 2014 21:17:16 -0500
Received: from mail-pa0-f46.google.com ([209.85.220.46]:44185)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aik@ozlabs.ru>) id 1WJD0h-0002Ey-2j
	for qemu-devel@nongnu.org; Thu, 27 Feb 2014 21:17:11 -0500
Received: by mail-pa0-f46.google.com with SMTP id kp14so11324pab.19
	for <qemu-devel@nongnu.org>; Thu, 27 Feb 2014 18:17:09 -0800 (PST)
Message-ID: <530FF19D.50908@ozlabs.ru>
Date: Fri, 28 Feb 2014 13:17:01 +1100
From: Alexey Kardashevskiy <aik@ozlabs.ru>
MIME-Version: 1.0
References: <1391947053-26753-1-git-send-email-afaerber@suse.de>
	<1392004376-17016-1-git-send-email-aik@ozlabs.ru>
	<1392004376-17016-2-git-send-email-aik@ozlabs.ru>
	<52F93745.8090703@suse.de> <52FD9583.6080005@ozlabs.ru>
In-Reply-To: <52FD9583.6080005@ozlabs.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 1/2] tests-ppc64: add to cleanup rule
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>

On 02/14/2014 03:03 PM, Alexey Kardashevskiy wrote:
> On 02/11/2014 07:32 AM, Andreas Färber wrote:
>> Am 10.02.2014 04:52, schrieb Alexey Kardashevskiy:
>>> This adds $(check-qtest-ppc64-y) to the check-clean rule.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>
>> Nice catch!
>>
>>> ---
>>>  tests/Makefile | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tests/Makefile b/tests/Makefile
>>> index 0aaf657..3a00ea7 100644
>>> --- a/tests/Makefile
>>> +++ b/tests/Makefile
>>> @@ -319,7 +319,7 @@ check-block: $(patsubst %,check-%, $(check-block-y))
>>>  check: check-qapi-schema check-unit check-qtest
>>>  check-clean:
>>>  	$(MAKE) -C tests/tcg clean
>>> -	rm -rf $(check-unit-y) $(check-qtest-i386-y) $(check-qtest-x86_64-y) $(check-qtest-sparc64-y) $(check-qtest-sparc-y) tests/*.o $(QEMU_IOTESTS_HELPERS-y)
>>> +	rm -rf $(check-unit-y) $(check-qtest-i386-y) $(check-qtest-x86_64-y) $(check-qtest-sparc64-y) $(check-qtest-sparc-y) $(check-qtest-ppc64-y) tests/*.o $(QEMU_IOTESTS_HELPERS-y)
>>>  
>>>  clean: check-clean
>>>  
>>
>> Can we use a $(foreach ...) for $(check-qtest-*-y) like Peter did for
>> adding qom-test?
>>
>> http://patchwork.ozlabs.org/patch/313650/
> 
> Like this? Against what should I rebase my patches and repost them?

Ping?


> 
> diff --git a/tests/Makefile b/tests/Makefile
> index 94b32b7..2577843 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -323,7 +323,9 @@ check-block: $(patsubst %,check-%, $(check-block-y))
>  check: check-qapi-schema check-unit check-qtest
>  check-clean:
>         $(MAKE) -C tests/tcg clean
> -       rm -rf $(check-unit-y) $(check-qtest-i386-y)
> $(check-qtest-x86_64-y) $(check-qtest-sparc64-y) $(check-qtest-sparc-y) t
> +       $(eval rmlist = $(check-unit-y) tests/*.o $(QEMU_IOTESTS_HELPERS-y))
> +       $(foreach target,$(SYSEMU_TARGET_LIST), $(eval rmlist +=
> $(check-qtest-$(target)-y)))
> +       rm -rf $(rmlist)
> 
>  clean: check-clean
> 
> 
> 


-- 
Alexey