All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Jingoo Han <jg1.han@samsung.com>, 'Wim Van Sebroeck' <wim@iguana.be>
Cc: linux-watchdog@vger.kernel.org, 'Akinobu Mita' <akinobu.mita@gmail.com>
Subject: Re: [PATCH 4/6] watchdog: ibmasr: fix incorrect placement of __initdata marker
Date: Thu, 27 Feb 2014 19:21:41 -0800	[thread overview]
Message-ID: <531000C5.9040009@roeck-us.net> (raw)
In-Reply-To: <004801cf337f$41d5af60$c5810e20$%han@samsung.com>

On 02/26/2014 09:46 PM, Jingoo Han wrote:
> The __initdata marker can be virtually anywhere on the line,
> EXCEPT right after "struct". The preferred location is before
> the "=" sign if there is one, or before the trailing ";"
> otherwise. It also fixes the following chechpatch warning.
>
>    WARNING: __initdata should be placed after ibmasr_id_table[]
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>



  reply	other threads:[~2014-02-28  3:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-27  5:41 [PATCH 1/6] watchdog: ep93xx_wdt: split module author names Jingoo Han
2014-02-27  5:43 ` [PATCH 2/6] watchdog: pc87413: " Jingoo Han
2014-02-28  3:21   ` Guenter Roeck
2014-02-27  5:44 ` [PATCH 3/6] watchdog: w83697hf: " Jingoo Han
2014-02-28  3:21   ` Guenter Roeck
2014-02-27  5:46 ` [PATCH 4/6] watchdog: ibmasr: fix incorrect placement of __initdata marker Jingoo Han
2014-02-28  3:21   ` Guenter Roeck [this message]
2014-02-27  5:48 ` [PATCH 5/6] watchdog: iTCO_wdt: remove unnecessary spaces Jingoo Han
2014-02-28  3:21   ` Guenter Roeck
2014-02-27  5:48 ` [PATCH 6/6] watchdog: softdog: remove unnecessary initialization of static variable Jingoo Han
2014-02-28  3:22   ` Guenter Roeck
2014-02-28  3:20 ` [PATCH 1/6] watchdog: ep93xx_wdt: split module author names Guenter Roeck
2014-03-02 14:03 ` Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=531000C5.9040009@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=akinobu.mita@gmail.com \
    --cc=jg1.han@samsung.com \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.