All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Junichi Nomura <j-nomura@ce.jp.nec.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	Alasdair Kergon <agk@redhat.com>
Subject: Re: [PATCH 4/8] dm mpath: remove process_queued_ios()
Date: Fri, 28 Feb 2014 10:37:05 +0100	[thread overview]
Message-ID: <531058C1.30402@suse.de> (raw)
In-Reply-To: <11AF7C027C4C02408624617A49860784010D7D51@BPXM12GP.gisp.nec.co.jp>

On 02/28/2014 10:05 AM, Junichi Nomura wrote:
> On 02/27/14 16:30, Hannes Reinecke wrote:
>> @@ -1214,9 +1189,11 @@ static void pg_init_done(void *data, int errors)
>>  
>>  	if (!m->pg_init_required)
>>  		m->queue_io = 0;
>> -
>> -	m->pg_init_delay_retry = delay_retry;
>> -	queue_work(kmultipathd, &m->process_queued_ios);
>> +	else if (m->current_pg) {
>> +		m->pg_init_delay_retry = delay_retry;
>> +		if (__pg_init_all_paths(m))
>> +			goto out;
>> +	}
> 
> As I commented before:
> https://www.redhat.com/archives/dm-devel/2014-February/msg00013.html
> 
> I think the code here should clear queue_io like this
> when retry was requested but wasn't done:
> 
> 	if (m->pg_init_required) {
> 		m->pg_init_delay_retry = delay_retry;
> 		if (__pg_init_all_paths(m))
> 			goto out;
> 	}
> 	m->queue_io = 0;
> 
> Otherwise, if __pg_init_all_paths() returns 0, m->queue_io will remain
> as "1" and nobody will clear it.
> 
You are right. Will be fixing it up.

Thanks for the review.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

  reply	other threads:[~2014-02-28  9:37 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-27  7:30 [PATCHv8 0/8] dm-multipath: push back requests instead of queueing Hannes Reinecke
2014-02-27  7:30 ` [PATCH 1/8] dm mpath: do not call pg_init when it is already running Hannes Reinecke
2014-02-27  7:30 ` [PATCH 2/8] dm table: add dm_table_run_md_queue_async Hannes Reinecke
2014-02-27  7:30 ` [PATCH 3/8] dm mpath: push back requests instead of queueing Hannes Reinecke
2014-02-27  7:30 ` [PATCH 4/8] dm mpath: remove process_queued_ios() Hannes Reinecke
2014-02-28  9:05   ` Junichi Nomura
2014-02-28  9:37     ` Hannes Reinecke [this message]
2014-02-27  7:30 ` [PATCH 5/8] dm mpath: reduce memory pressure when requeuing Hannes Reinecke
2014-02-27  7:30 ` [PATCH 6/8] dm mpath: remove map_io() Hannes Reinecke
2014-02-28  9:06   ` Junichi Nomura
2014-02-27  7:30 ` [PATCH 7/8] dm mpath: remove extra nesting in map function Hannes Reinecke
2014-02-27  7:30 ` [PATCH 8/8] dm-mpath: do not activate failed paths Hannes Reinecke
2014-02-28  8:49   ` Junichi Nomura
2014-02-28  9:32     ` Hannes Reinecke
2014-02-28  9:37       ` Junichi Nomura
2014-02-28  9:52         ` Hannes Reinecke
2014-02-28 10:08           ` Junichi Nomura
2014-02-28 14:22           ` Mike Snitzer
2014-02-28 14:44             ` Hannes Reinecke
2014-02-28 15:02               ` Mike Snitzer
2014-02-28 15:08                 ` Hannes Reinecke
2014-02-28 14:33 [PATCHv9 0/8] dm-multipath: push back requests instead of queueing Hannes Reinecke
2014-02-28 14:33 ` [PATCH 4/8] dm mpath: remove process_queued_ios() Hannes Reinecke
2014-03-02 23:12   ` Junichi Nomura
2014-03-05  8:59     ` Hannes Reinecke
2014-03-05 14:24       ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=531058C1.30402@suse.de \
    --to=hare@suse.de \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=j-nomura@ce.jp.nec.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.