From: Manu Gautam <email@example.com>
To: Michal Nazarewicz <firstname.lastname@example.org>
Cc: email@example.com, firstname.lastname@example.org, email@example.com,
Subject: Re: [PATCHv2] usb: gadget: f_fs: Add flags to descriptors block
Date: Fri, 28 Feb 2014 15:41:03 +0530 [thread overview]
Message-ID: <531060B7.firstname.lastname@example.org> (raw)
On 2/25/2014 10:32 PM, Michal Nazarewicz wrote:
> This reworks the way SuperSpeed descriptors are added and instead of
> having a magick after full and high speed descriptors, it reworks the
> whole descriptors block to include a flags field which lists which
> descriptors are present and makes future extensions possible.
> Signed-off-by: Michal Nazarewicz <email@example.com>
> Manu, if you could include it in your series, adjust your user space
> client and test it, it would be wonderful. :]
I have tested this with my userspace client. It works fine. I checked
both DESC_MAGIC and DESC_MAGIC_V2 with and without passing ss_descs.
I faced one issue when I was using MAGIC_V2 and specified ss_count as 0.
This resulted in driver treating ss_count as start of descs blob.
Later noticed that this is now changed and depending on the flags
(descriptors) passed, these fields may or may not be present. I see that
you have explicitly mentioned the same in functionfs.h. This looks fine
Additionally, there were could of typos (mentioned below) which I have
fixed in the patch.
> #define FUNCTIONFS_SS_DESC_MAGIC 0x0055DE5C
can be removed.
> + * | | fs_count | LE32 | number of full-speed descriptors |
> + * | | hs_count | LE32 | number of high-speed descriptors |
> + * | | ss_count | LE32 | number of high-speed descriptors |
> + * | | fs_descrs | Descriptor | list of full-speed descriptors |
> + * | | hs_descrs | Descriptor | list of high-speed descriptors |
> + * | | ss_descrs | Descriptor | list of high-speed descriptors |
> + *
> + * Depending on which flags are set, various fields may be missing in the
> + * structure. Any flags that are not recognised cause the whole block to be
> + * rejected with -ENOSYS.
This is what I was talking about.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-02-28 10:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 9:30 [PATCH v5 1/1] usb: gadget: f_fs: Add support for SuperSpeed Mode Manu Gautam
[not found] ` <1387877408-17567-1-git-send-email-mgautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-02-25 4:47 ` Manu Gautam
2014-02-25 14:01 ` [RFC] usb: gadget: f_fs: Add flags to descriptors block Michal Nazarewicz
[not found] ` <xa1tsir7b5uz.fsf-deATy8a+UHjQT0dZR+AlfA@public.gmane.org>
2014-02-25 17:02 ` [PATCHv2] " Michal Nazarewicz
2014-02-25 18:32 ` Felipe Balbi
2014-02-28 10:11 ` Manu Gautam [this message]
[not found] ` <xa1tob1vazxh.fsf-deATy8a+UHjQT0dZR+AlfA@public.gmane.org>
2014-06-04 14:24 ` Krzysztof Opasiak
[not found] ` <005901cf8000$c16ec090$444c41b0$%opasiak-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-04 19:06 ` Michal Nazarewicz
2014-06-05 11:32 ` Krzysztof Opasiak
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.