From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 21/25] xen/arm: refactor vpl011_data_avail Date: Mon, 13 Aug 2018 14:23:00 +0100 Message-ID: <53131f06-0d7e-62dc-b94a-e36068c53924@arm.com> References: <1533079688-9541-21-git-send-email-sstabellini@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1533079688-9541-21-git-send-email-sstabellini@kernel.org> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Stefano Stabellini Cc: Stefano Stabellini , andrii_anisov@epam.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org SGkgU3RlZmFubywKCk9uIDAxLzA4LzE4IDAwOjI4LCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6 Cj4gTW92ZSB0aGUgY29kZSB0byBjYWxjdWxhdGUgaW5fZmlmb19sZXZlbCBhbmQgb3V0X2ZpZm9f bGV2ZWwgb3V0IG9mCj4gdnBsMDExX2RhdGFfYXZhaWwsIHRvIHRoZSBjYWxsZXIuCj4gVGhpcyBj aGFuZ2Ugd2lsbCBtYWtlIGl0IHBvc3NpYmxlIHRvIHJldXNlIHZwbDAxMV9kYXRhX2F2YWlsIHdp dGgKPiBkaWZmZXJlbnQgcmluZyBzdHJ1Y3R1cmVzIGluIGEgbGF0ZXIgcGF0Y2guCj4gCj4gU2ln bmVkLW9mZi1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzdGVmYW5vc0B4aWxpbnguY29tPgoKQWNr ZWQtYnk6IEp1bGllbiBHcmFsbCA8anVsaWVuLmdyYWxsQGFybS5jb20+CgpDaGVlcnMsCgo+IAo+ IC0tLQo+IENoYW5nZXMgaW4gdjM6Cj4gLSByZW1vdmUgZm9yd2FyZCBkZWNsYXJhdGlvbiBvZiB2 cGwwMTFfZGF0YV9hdmFpbAo+IAo+IENoYW5nZXMgaW4gdjI6Cj4gLSBuZXcgcGF0Y2gKPiAtLS0K PiAgIHhlbi9hcmNoL2FybS92cGwwMTEuYyB8IDY0ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDM2IGluc2VydGlv bnMoKyksIDI4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vdnBs MDExLmMgYi94ZW4vYXJjaC9hcm0vdnBsMDExLmMKPiBpbmRleCBlNzBjNWVjLi43MjVhMjAzIDEw MDY0NAo+IC0tLSBhL3hlbi9hcmNoL2FybS92cGwwMTEuYwo+ICsrKyBiL3hlbi9hcmNoL2FybS92 cGwwMTEuYwo+IEBAIC0zNzgsMzAgKzM3OCwxMyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IG1taW9f aGFuZGxlcl9vcHMgdnBsMDExX21taW9faGFuZGxlciA9IHsKPiAgICAgICAud3JpdGUgPSB2cGww MTFfbW1pb193cml0ZSwKPiAgIH07Cj4gICAKPiAtc3RhdGljIHZvaWQgdnBsMDExX2RhdGFfYXZh aWwoc3RydWN0IGRvbWFpbiAqZCkKPiArc3RhdGljIHZvaWQgdnBsMDExX2RhdGFfYXZhaWwoc3Ry dWN0IGRvbWFpbiAqZCwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgWEVOQ09OU19S SU5HX0lEWCBpbl9maWZvX2xldmVsLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBY RU5DT05TX1JJTkdfSURYIGluX3NpemUsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IFhFTkNPTlNfUklOR19JRFggb3V0X2ZpZm9fbGV2ZWwsCj4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIFhFTkNPTlNfUklOR19JRFggb3V0X3NpemUpCj4gICB7Cj4gLSAgICB1bnNpZ25l ZCBsb25nIGZsYWdzOwo+ICAgICAgIHN0cnVjdCB2cGwwMTEgKnZwbDAxMSA9ICZkLT5hcmNoLnZw bDAxMTsKPiAtICAgIHN0cnVjdCB4ZW5jb25zX2ludGVyZmFjZSAqaW50ZiA9IHZwbDAxMS0+ZG9t LnJpbmdfYnVmOwo+IC0gICAgWEVOQ09OU19SSU5HX0lEWCBpbl9jb25zLCBpbl9wcm9kLCBvdXRf Y29ucywgb3V0X3Byb2Q7Cj4gLSAgICBYRU5DT05TX1JJTkdfSURYIGluX2ZpZm9fbGV2ZWwsIG91 dF9maWZvX2xldmVsOwo+IC0KPiAtICAgIFZQTDAxMV9MT0NLKGQsIGZsYWdzKTsKPiAtCj4gLSAg ICBpbl9jb25zID0gaW50Zi0+aW5fY29uczsKPiAtICAgIGluX3Byb2QgPSBpbnRmLT5pbl9wcm9k Owo+IC0gICAgb3V0X2NvbnMgPSBpbnRmLT5vdXRfY29uczsKPiAtICAgIG91dF9wcm9kID0gaW50 Zi0+b3V0X3Byb2Q7Cj4gLQo+IC0gICAgc21wX3JtYigpOwo+IC0KPiAtICAgIGluX2ZpZm9fbGV2 ZWwgPSB4ZW5jb25zX3F1ZXVlZChpbl9wcm9kLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGluX2NvbnMsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg c2l6ZW9mKGludGYtPmluKSk7Cj4gLQo+IC0gICAgb3V0X2ZpZm9fbGV2ZWwgPSB4ZW5jb25zX3F1 ZXVlZChvdXRfcHJvZCwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgb3V0 X2NvbnMsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNpemVvZihpbnRm LT5vdXQpKTsKPiAgIAo+ICAgICAgIC8qKioqIFVwZGF0ZSB0aGUgVUFSVCBSWCBzdGF0ZSAqKioq Lwo+ICAgCj4gQEAgLTQxMCwxMSArMzkzLDExIEBAIHN0YXRpYyB2b2lkIHZwbDAxMV9kYXRhX2F2 YWlsKHN0cnVjdCBkb21haW4gKmQpCj4gICAgICAgICAgIHZwbDAxMS0+dWFydGZyICY9IH5SWEZF Owo+ICAgCj4gICAgICAgLyogU2V0IHRoZSBGSUZPX0ZVTEwgYml0IGlmIHRoZSBYZW4gYnVmZmVy IGlzIGZ1bGwuICovCj4gLSAgICBpZiAoIGluX2ZpZm9fbGV2ZWwgPT0gc2l6ZW9mKGludGYtPmlu KSApCj4gKyAgICBpZiAoIGluX2ZpZm9fbGV2ZWwgPT0gaW5fc2l6ZSApCj4gICAgICAgICAgIHZw bDAxMS0+dWFydGZyIHw9IFJYRkY7Cj4gICAKPiAgICAgICAvKiBBc3NlcnQgdGhlIFJYIGludGVy cnVwdCBpZiB0aGUgRklGTyBpcyBtb3JlIHRoYW4gaGFsZiB3YXkgZmlsbGVkLiAqLwo+IC0gICAg aWYgKCBpbl9maWZvX2xldmVsID49IHNpemVvZihpbnRmLT5pbikgLSBTQlNBX1VBUlRfRklGT19M RVZFTCApCj4gKyAgICBpZiAoIGluX2ZpZm9fbGV2ZWwgPj0gaW5fc2l6ZSAtIFNCU0FfVUFSVF9G SUZPX0xFVkVMICkKPiAgICAgICAgICAgdnBsMDExLT51YXJ0cmlzIHw9IFJYSTsKPiAgIAo+ICAg ICAgIC8qCj4gQEAgLTQyNyw3ICs0MTAsNyBAQCBzdGF0aWMgdm9pZCB2cGwwMTFfZGF0YV9hdmFp bChzdHJ1Y3QgZG9tYWluICpkKQo+ICAgCj4gICAgICAgLyoqKiogVXBkYXRlIHRoZSBVQVJUIFRY IHN0YXRlICoqKiovCj4gICAKPiAtICAgIGlmICggb3V0X2ZpZm9fbGV2ZWwgIT0gc2l6ZW9mKGlu dGYtPm91dCkgKQo+ICsgICAgaWYgKCBvdXRfZmlmb19sZXZlbCAhPSBvdXRfc2l6ZSApCj4gICAg ICAgewo+ICAgICAgICAgICB2cGwwMTEtPnVhcnRmciAmPSB+VFhGRjsKPiAgIAo+IEBAIC00NDUs MTMgKzQyOCwzOCBAQCBzdGF0aWMgdm9pZCB2cGwwMTFfZGF0YV9hdmFpbChzdHJ1Y3QgZG9tYWlu ICpkKQo+ICAgCj4gICAgICAgaWYgKCBvdXRfZmlmb19sZXZlbCA9PSAwICkKPiAgICAgICAgICAg dnBsMDExLT51YXJ0ZnIgfD0gVFhGRTsKPiAtCj4gLSAgICBWUEwwMTFfVU5MT0NLKGQsIGZsYWdz KTsKPiAgIH0KPiAgIAo+ICAgc3RhdGljIHZvaWQgdnBsMDExX25vdGlmaWNhdGlvbihzdHJ1Y3Qg dmNwdSAqdiwgdW5zaWduZWQgaW50IHBvcnQpCj4gICB7Cj4gLSAgICB2cGwwMTFfZGF0YV9hdmFp bCh2LT5kb21haW4pOwo+ICsgICAgdW5zaWduZWQgbG9uZyBmbGFnczsKPiArICAgIHN0cnVjdCBk b21haW4gKmQgPSB2LT5kb21haW47Cj4gKyAgICBzdHJ1Y3QgdnBsMDExICp2cGwwMTEgPSAmZC0+ YXJjaC52cGwwMTE7Cj4gKyAgICBzdHJ1Y3QgeGVuY29uc19pbnRlcmZhY2UgKmludGYgPSB2cGww MTEtPmRvbS5yaW5nX2J1ZjsKPiArICAgIFhFTkNPTlNfUklOR19JRFggaW5fY29ucywgaW5fcHJv ZCwgb3V0X2NvbnMsIG91dF9wcm9kOwo+ICsgICAgWEVOQ09OU19SSU5HX0lEWCBpbl9maWZvX2xl dmVsLCBvdXRfZmlmb19sZXZlbDsKPiArCj4gKyAgICBWUEwwMTFfTE9DSyhkLCBmbGFncyk7Cj4g Kwo+ICsgICAgaW5fY29ucyA9IGludGYtPmluX2NvbnM7Cj4gKyAgICBpbl9wcm9kID0gaW50Zi0+ aW5fcHJvZDsKPiArICAgIG91dF9jb25zID0gaW50Zi0+b3V0X2NvbnM7Cj4gKyAgICBvdXRfcHJv ZCA9IGludGYtPm91dF9wcm9kOwo+ICsKPiArICAgIHNtcF9ybWIoKTsKPiArCj4gKyAgICBpbl9m aWZvX2xldmVsID0geGVuY29uc19xdWV1ZWQoaW5fcHJvZCwKPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBpbl9jb25zLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHNpemVvZihpbnRmLT5pbikpOwo+ICsKPiArICAgIG91dF9maWZvX2xldmVsID0geGVu Y29uc19xdWV1ZWQob3V0X3Byb2QsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIG91dF9jb25zLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzaXpl b2YoaW50Zi0+b3V0KSk7Cj4gKwo+ICsgICAgdnBsMDExX2RhdGFfYXZhaWwodi0+ZG9tYWluLCBp bl9maWZvX2xldmVsLCBzaXplb2YoaW50Zi0+aW4pLAo+ICsgICAgICAgICAgICAgICAgICAgICAg b3V0X2ZpZm9fbGV2ZWwsIHNpemVvZihpbnRmLT5vdXQpKTsKPiArCj4gKyAgICBWUEwwMTFfVU5M T0NLKGQsIGZsYWdzKTsKPiAgIH0KPiAgIAo+ICAgaW50IGRvbWFpbl92cGwwMTFfaW5pdChzdHJ1 Y3QgZG9tYWluICpkLCBzdHJ1Y3QgdnBsMDExX2luaXRfaW5mbyAqaW5mbykKPiAKCi0tIApKdWxp ZW4gR3JhbGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Clhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0 dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=