From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77046C636D6 for ; Tue, 7 Feb 2023 11:28:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231500AbjBGL2Y (ORCPT ); Tue, 7 Feb 2023 06:28:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230445AbjBGL2T (ORCPT ); Tue, 7 Feb 2023 06:28:19 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18285E398 for ; Tue, 7 Feb 2023 03:27:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675769251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NjK2kZBOicICFKKeKjHG/kRG3ABMzmNQEsUkC1U+ZhY=; b=iFa8euGOZsmuDzIXX/Ju2TUj27vmZ1BuVpP4YA7WQznjgFgBqnI1dR1M0NvAuA/mk6XJYU YfBd3V6eg8of5oIzL8TDut8ybrbtZjhUaRCtTxRhlfor4KnhwySkjqCDYhWIav2GNfCrH0 FwGMwPjyNpqccqWy49BT1o0VnSxxGuk= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-629-nKD3i5BTMg-0RXVjPKzrdw-1; Tue, 07 Feb 2023 06:27:30 -0500 X-MC-Unique: nKD3i5BTMg-0RXVjPKzrdw-1 Received: by mail-qv1-f72.google.com with SMTP id b19-20020a0ccd13000000b005374d115edbso7461658qvm.19 for ; Tue, 07 Feb 2023 03:27:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NjK2kZBOicICFKKeKjHG/kRG3ABMzmNQEsUkC1U+ZhY=; b=ogITOP0HnPGOBM5L7/6G9cUeIzpU7lcVHBdc6kpxkb2dFw6scyAazeGSSkCItAPPGV cpEXQJZsrB+U7Zk5GG2AA+jj7bYzeNkCNQLDQX7u6kTQnR16FoWsJZ8XmJcmKno9DDUT Pwu7pUaFc8owkyA1po+Ysz1QLH5mtKb11McJUWxZI0eamojp4bp8covSX91BzABr+JsN s79T9YOZ2+Id3QPBWhZQpc4XmCHmBhI7vrgm9ke9SXDS5yxuzX+qOcZQjSS0Pbape1BB xMftQklTj0ZTOhok4qcRB0UefRST4u3X3dG1XDI9OP7NYc0LGnCHRt4jdqMAE4cVECF1 UxPA== X-Gm-Message-State: AO0yUKWRm05dBAt/5R0HNg9nLxSNugvSZVnTymWphojjQh1R2u4+kWu1 9fl3nSGiMl07OpkVU5R/WhAsH1mVPkb9Ncz+bsHA/8Q1s1akxO2L+sCyvs9HIbdDxlOiyBoj6vp sR0i11mjCaz38xuPvZS6w3YxM X-Received: by 2002:a0c:f587:0:b0:538:a431:8630 with SMTP id k7-20020a0cf587000000b00538a4318630mr3558217qvm.1.1675769249869; Tue, 07 Feb 2023 03:27:29 -0800 (PST) X-Google-Smtp-Source: AK7set/UomiMZJq0DCZT+ohWr7e/c9M7OAp5dyxgo1bvtA3OuUL0OCSJ2+9BVBbxQJwAvBRDKfrIVg== X-Received: by 2002:a0c:f587:0:b0:538:a431:8630 with SMTP id k7-20020a0cf587000000b00538a4318630mr3558188qvm.1.1675769249547; Tue, 07 Feb 2023 03:27:29 -0800 (PST) Received: from gerbillo.redhat.com (146-241-113-28.dyn.eolo.it. [146.241.113.28]) by smtp.gmail.com with ESMTPSA id br34-20020a05620a462200b0071d7ade87afsm9482828qkb.67.2023.02.07.03.27.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 03:27:28 -0800 (PST) Message-ID: <5314e0ba3a728787299ca46a60b0a2da5e8ab23a.camel@redhat.com> Subject: Re: [PATCH net v2 1/2] net: ll_temac: Fix DMA resources leak From: Paolo Abeni To: Jonas Suhr Christensen , netdev@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Michal Simek , Harini Katakam , Haoyue Xu , huangjunxian , Wang Qing , Yang Yingliang , Esben Haabendal , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 07 Feb 2023 12:27:25 +0100 In-Reply-To: <20230205201130.11303-2-jsc@umbraculum.org> References: <20230205201130.11303-1-jsc@umbraculum.org> <20230205201130.11303-2-jsc@umbraculum.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sun, 2023-02-05 at 21:11 +0100, Jonas Suhr Christensen wrote: > Add missing conversion of address when unmapping dma region causing > unmapping to silently fail. At some point resulting in buffer > overrun eg. when releasing device. >=20 > Fixes: fdd7454ecb29 ("net: ll_temac: Fix support for little-endian platfo= rms") >=20 > Signed-off-by: Jonas Suhr Christensen I'm sorry for nit-picking, but you must avoid empty lines in the tag area. Please post a v2 avoiding the empty line between the Fixes and sob tags (both here and in the next patch). You can retain (include in the tag area) the already collected reviewed-by/acked-by tags. Thanks, Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FF77C636CC for ; Tue, 7 Feb 2023 11:28:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p3adzwFsSuA/NWi3B06t3R/B+GdF9MRC/NKm8nJIIiI=; b=2QYbG7Oh/v6vCR E7+8J9qaQ044Qft1410QIazFgI1SeGIOzY3y6mQ2bv2fv9H1OSRIzeWquEj/O2nz7fRo+ZuXZYgVJ rF57ACDuj/eR95xFD9rq4YJtY65EDrtNCiPqMv3VaqILdDRJPi2uZmP83gDGp0BYLO3RH3MwsuKyF bF/Lghm4jwaBio+pP74srGzpUnbw96A67dBVofpWZvaRkMNUnJbfhE0dfkdnPMi7yJr8JDcoTAT1+ epkMgjhi5+PrUnmDJKBvMGJ2ZncfpSBrv7kQhGynRqjDjWb0CdwSSO2NbUrcPHmlQA1iKa2YIAcXo gV025oSGNALwDJuAUmsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPM8S-00Bx1o-Fc; Tue, 07 Feb 2023 11:27:40 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPM8O-00Bx0y-SL for linux-arm-kernel@lists.infradead.org; Tue, 07 Feb 2023 11:27:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675769253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NjK2kZBOicICFKKeKjHG/kRG3ABMzmNQEsUkC1U+ZhY=; b=ftimy2GWKtRL5SSgFinWfZaHvuQwy29eff+p0Ipc5vfy60wyfYQ4IbuxfIyoXtbb6hRTFn t2ykPYlgKiacYuvZoY3VKiDx8v6i44Z+oCrQZLc3BZavGZBLipoZ8yUJ+br2+tFoDPpiZG smq5I3W34e8mvqdTreecTJoM/FZ4m1Y= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-608-AEykEeZBNTOg2YZET0YvsQ-1; Tue, 07 Feb 2023 06:27:30 -0500 X-MC-Unique: AEykEeZBNTOg2YZET0YvsQ-1 Received: by mail-qt1-f198.google.com with SMTP id v8-20020a05622a144800b003ba0dc5d798so6214206qtx.22 for ; Tue, 07 Feb 2023 03:27:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NjK2kZBOicICFKKeKjHG/kRG3ABMzmNQEsUkC1U+ZhY=; b=c3mMcWTWDeJNxx3DwI1soKcidVZjIZWZdi1AKcXsUrrMuDeo1UNOqt5SZDp2g+sC/L RfIWSWG6wQG3UnKFWRYz1l3oG8MjX7PMr1eKa6w9c91S4a9y/tzj+k9rnoERuQJzGAX8 BsX5MB71n0OhDbX4HblZDjOXrw33WZIfKAFtoAAaIaJf72QoenmFJjfLw7vZKQ+F+EV5 n50Z2mocTCSefL4jqEgEKfu9/AtO3u4SH4opRnl+Aoez8ntLcHTFr2VjP/zhuLhQE+CY 7+C3N2VA/YUkEry1fTo0++g76PTGe9uU5Sl/XqsoylTDF5r33MbT01B2Nw90fscl5YFy X5Bw== X-Gm-Message-State: AO0yUKVVkvSoAjB7oWCvCKGN7N4qifRvJlhEHp3VCyX3G6veFCNoxQT9 cA/SJ1Qgx7r1+p88TEAPJYYfkC+kuF38K3TYrinGI1KnQAttMNc1b0Ds0t3pTzJ0K8Zf0jTSFxz m50IWw1LxDrflk3752KcnLZ490EHHKfoJwuY= X-Received: by 2002:a0c:f587:0:b0:538:a431:8630 with SMTP id k7-20020a0cf587000000b00538a4318630mr3558215qvm.1.1675769249869; Tue, 07 Feb 2023 03:27:29 -0800 (PST) X-Google-Smtp-Source: AK7set/UomiMZJq0DCZT+ohWr7e/c9M7OAp5dyxgo1bvtA3OuUL0OCSJ2+9BVBbxQJwAvBRDKfrIVg== X-Received: by 2002:a0c:f587:0:b0:538:a431:8630 with SMTP id k7-20020a0cf587000000b00538a4318630mr3558188qvm.1.1675769249547; Tue, 07 Feb 2023 03:27:29 -0800 (PST) Received: from gerbillo.redhat.com (146-241-113-28.dyn.eolo.it. [146.241.113.28]) by smtp.gmail.com with ESMTPSA id br34-20020a05620a462200b0071d7ade87afsm9482828qkb.67.2023.02.07.03.27.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 03:27:28 -0800 (PST) Message-ID: <5314e0ba3a728787299ca46a60b0a2da5e8ab23a.camel@redhat.com> Subject: Re: [PATCH net v2 1/2] net: ll_temac: Fix DMA resources leak From: Paolo Abeni To: Jonas Suhr Christensen , netdev@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Michal Simek , Harini Katakam , Haoyue Xu , huangjunxian , Wang Qing , Yang Yingliang , Esben Haabendal , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 07 Feb 2023 12:27:25 +0100 In-Reply-To: <20230205201130.11303-2-jsc@umbraculum.org> References: <20230205201130.11303-1-jsc@umbraculum.org> <20230205201130.11303-2-jsc@umbraculum.org> User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230207_032737_010579_21F11A55 X-CRM114-Status: UNSURE ( 9.52 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Sun, 2023-02-05 at 21:11 +0100, Jonas Suhr Christensen wrote: > Add missing conversion of address when unmapping dma region causing > unmapping to silently fail. At some point resulting in buffer > overrun eg. when releasing device. > > Fixes: fdd7454ecb29 ("net: ll_temac: Fix support for little-endian platforms") > > Signed-off-by: Jonas Suhr Christensen I'm sorry for nit-picking, but you must avoid empty lines in the tag area. Please post a v2 avoiding the empty line between the Fixes and sob tags (both here and in the next patch). You can retain (include in the tag area) the already collected reviewed-by/acked-by tags. Thanks, Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel