From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [PATCH v4 00/34] drm/exynos: Refactor parts of the exynos driver Date: Tue, 04 Mar 2014 12:03:32 +0100 Message-ID: <5315B304.50006@samsung.com> References: <1391116773-28471-1-git-send-email-seanpaul@chromium.org> <52F59B02.9040902@gmail.com> <530F4280.5010306@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by gabe.freedesktop.org (Postfix) with ESMTP id 79F75FB57C for ; Tue, 4 Mar 2014 03:03:47 -0800 (PST) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N1W00AI8S28N980@mailout1.w1.samsung.com> for dri-devel@lists.freedesktop.org; Tue, 04 Mar 2014 11:03:44 +0000 (GMT) In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Inki Dae , Tomasz Figa Cc: =?UTF-8?B?VG9tYXN6IFN0YW5pc8WCYXdza2k=?= , =?UTF-8?B?U3TDqXBoYW5lIE1hcmNoZXNpbg==?= , DRI mailing list List-Id: dri-devel@lists.freedesktop.org Hi Inki, On 02/28/2014 03:28 AM, Inki Dae wrote: (...) > > Andrzej Hajda from our team is already working on addressing remaining > issues with Sean's series, including fixing removed parallel display > support. Earlier this month he sent a series restoring support for DSI > panels: http://thread.gmane.org/gmane. > > Already merged to internal kernel for test. > >> linux.kernel.samsung-soc/27044 . Now he's also trying to make the design >> more modular. He will give you more information on Monday, as he's on >> holiday for next two days. Thanks Tomasz for pointing it out. I try to properly restore parallel panel support. I have come to the conclusion that the most natural way is to implement crtc/encoder/connector in FIMD, as the FIMD directly produces parallel RGB stream (or I80 in command mode). I think implementing crtc/encoder/connector in FIMD in case of DSI and eDP panel is also more natural. In such case I would convert DSIM, eDP and ptn3460 to drm_panel framework similarly as I already did for TC358764 DSI/LVDS bridge. Here are different scenarios of HW pipelines: 1. Parallel panel: FIMD ---> Parallel Panel 2. DSI panel: FIMD ---> DSIM ---> DSI Panel 3. Arndale: FIMD ---> DSIM ---> DSI/LVDS bridge ---> LVDS panel 4. Snow: FIMD ---> eDP ---> eDP/LVDS bridge ---> LVDS panel 5. In case mobile image enhancer(MIE) will be used pipeline can be extended to: FIMD ---> MIE ---> DSIM ---> ..... or FIMD ---> MIE ---> eDP ---> ..... Pros of implementing all drm components (crtc,encoder,connector) in FIMD, and using drm_panel framework for panels, DSIM, eDP and external bridges: - it is natural, FIMD produces already encoded stream, DSIM and eDP are just optional converters, - easy to extend, adding/removing image processors or bridges will require only changing video paths in DTS (in addition to adding device nodes), - consistency. What do you think about it? Anyway the patch adding parallel support with current design should be ready soon. Regards Andrzej