From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BB30C433EF for ; Tue, 14 Jun 2022 17:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234580AbiFNRqP (ORCPT ); Tue, 14 Jun 2022 13:46:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232984AbiFNRqL (ORCPT ); Tue, 14 Jun 2022 13:46:11 -0400 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AA5840929 for ; Tue, 14 Jun 2022 10:46:09 -0700 (PDT) Received: by mail-qt1-x82c.google.com with SMTP id k4so6633991qth.8 for ; Tue, 14 Jun 2022 10:46:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20210112.gappssmtp.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-transfer-encoding:user-agent:mime-version; bh=Xn5U6yTCivKcEB2CQHYVzvugp+BfiT1C9G92C8VTcFE=; b=613RfUCkNkGQMLtU7V2MbO04fhnH0mtvC5dKJO2n7m5TCcstyJMNMqLu5YY/jKx85W WqQMLAi27pfXea2pgAxcenjo+QPeoTl9CYin1epFcZK/vTqiQCqBD1EYkVVK5uDXlJOk /REj65VNDa+2mfoDGydpq55FH9UXhemjGynB7O4/KvsjpjTKj3iXzE5se/WNWb3HwcDQ Qm8tyvsIiyWLkoQC0YSKGsXgM6jbVZQWXTcSfHhc7xpqFpsgqnP3lP5KbJsA0tnl+2AB IlaRWg/QdubW8ftDo3KKzJL3UuG4GA8jNRl6v8rVtjb0Mt6ik6HtmbEE25xxiVEQixz1 wZZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=Xn5U6yTCivKcEB2CQHYVzvugp+BfiT1C9G92C8VTcFE=; b=qOeA4eGnC8ZlvRIGu9LgFbAoS5mAOzSwT07KX4FEO+wfHkPll4YfAZsbub1mlKzco7 hhRh6YtvRW3JL5e4WIjFPp/k8z0Wnlkcuohv3gFJPX47ugO7WBGVF2rK5/NEqkFV6aht 4N/tsuULn8FtA3UsSznaIBk6pfZ403mQvVF1sSe9kvpx209zH37dry4ZSKWFKEX3YG04 uPU+6sDSvH51Co7STTZbcgp0YMjbQj8XaU29l7TWY9vvV8cBRp0iSZ4H4El+GSt+PU8c wOe1k8SXDIRGZO4dG7y2MmhRDb5x/hudk08Dwv1fG+WtE2dCAzsCGTBjcK04qS55e7dF dHAA== X-Gm-Message-State: AOAM5300C+8vTPZnjDol77BuoEDny8+yL7oxHUyFZKstwOuU/DLqitYw cs260Q6y3EDWBSpXjGiCqUz3Jw== X-Google-Smtp-Source: ABdhPJyz6Dah76Tro/nBusft/e8MUMRJGJMekMTnnVzKmUelFUurRZI3FxaqFWMN0HWssy5n6ZNO1g== X-Received: by 2002:ac8:5a42:0:b0:305:222b:8ec9 with SMTP id o2-20020ac85a42000000b00305222b8ec9mr5296612qta.214.1655228768303; Tue, 14 Jun 2022 10:46:08 -0700 (PDT) Received: from nicolas-tpx395.localdomain (192-222-136-102.qc.cable.ebox.net. [192.222.136.102]) by smtp.gmail.com with ESMTPSA id q12-20020a05622a030c00b00304dd83a9b1sm8255216qtw.82.2022.06.14.10.46.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 10:46:07 -0700 (PDT) Message-ID: <5316234cef174e49110f949991ef71c578a3478e.camel@ndufresne.ca> Subject: Re: [PATCH v4, 0/3] add h264 decoder driver for mt8186 From: Nicolas Dufresne To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , AngeloGioacchino Del Regno , Benjamin Gaignard , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Cc: George Sun , Xiaoyong Lu , Hsin-Yi Wang , Fritz Koenig , Daniel Vetter , dri-devel , Irui Wang , Steve Cho , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Date: Tue, 14 Jun 2022 13:46:06 -0400 In-Reply-To: References: <20220512034620.30500-1-yunfei.dong@mediatek.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le lundi 13 juin 2022 =C3=A0 16:10 -0400, Nicolas Dufresne a =C3=A9crit=C2= =A0: > Le jeudi 12 mai 2022 =C3=A0 11:46 +0800, Yunfei Dong a =C3=A9crit=C2=A0: > > Firstly, add mt8186 compatible and private data, then add document for > > compatible "mediatek,mt8186-vcodec-dec". For mt8186 is single core > > architecture, need to add new interface for h264 hardware decoder. >=20 > Would be nice to take the habit of sharing fluster score for this new HW,= I > would expect no less then what the numbers you'd get from running over MT= 8195 or > 92, remains nice to demonstrate that this was tested and document any oop= s along > the way. > >=20 > > Patche 1 add mt8186 compatible and private data. > > Patche 2 add mt8186 compatible document. > > Patche 3 add h264 single core driver. > > --- > > This patch depends on "support for MT8192 decoder"[1] > >=20 > > [1] https://patchwork.kernel.org/project/linux-mediatek/cover/20220512= 021950.29087-1-yunfei.dong@mediatek.com/ I forgot earlier, but I suppose this will also depends on an scp.img firmwa= re ? If so, any linux-firmware submission to link to ? > > --- > > changed with v3: > > - fix __iomem not reasonable, align share memory to dram. > > changed with v2: > > - fix sparse and smatch check fail for patch 3 > > changed with v1: > > - rebase driver to the latest media_stage. > > --- > > Yunfei Dong (3): > > dt-bindings: media: mediatek: vcodec: Adds decoder dt-bindings for > > mt8186 > > media: mediatek: vcodec: Support MT8186 > > media: mediatek: vcodec: add h264 decoder driver for mt8186 > >=20 > > .../media/mediatek,vcodec-subdev-decoder.yaml | 4 +- > > .../platform/mediatek/vcodec/mtk_vcodec_dec.h | 1 + > > .../mediatek/vcodec/mtk_vcodec_dec_drv.c | 4 + > > .../vcodec/mtk_vcodec_dec_stateless.c | 19 ++ > > .../vcodec/vdec/vdec_h264_req_multi_if.c | 177 +++++++++++++++++- > > 5 files changed, 203 insertions(+), 2 deletions(-) > >=20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B489AC433EF for ; Tue, 14 Jun 2022 17:46:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p8fGWhb9wX9+6FEzJM70pOibY4l/BzvU3iErMdWAyM0=; b=l74KE/F6MA4wTW qoW+UT8fHfEb0TzHeCAMP1wq7OpyMjiF35Rpw5vWdPID3fO75jsLpx4klrH4/7qRyPdYWJMtliSsw vL5NriPukeznHEBRdenEMZgrXHsONdZ14vqHpjxUtxVGPjZfdj1crF+Jw/VqSqdeQWLvCvo+Xh9wz hlqW9NpHvF8scnrZcSvEjSM2fEcm23ls9VjgDrE2KFKVj9jh+pUZ93lKGpjcmWTKQHE6Q/vP0xjew c/oQRYpURHhu7Rhnb/0oiTvEh17cORffg0EIyvMBR0WgC+vQQ6rNCAGJMmkSk24ajkd9I+c2/aH4c P2+m6EMtpR6QpRB+oTCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1AcJ-00AcAj-2q; Tue, 14 Jun 2022 17:46:15 +0000 Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1AcF-00Ac8D-Gt for linux-mediatek@lists.infradead.org; Tue, 14 Jun 2022 17:46:13 +0000 Received: by mail-qt1-x831.google.com with SMTP id x16so6608336qtw.12 for ; Tue, 14 Jun 2022 10:46:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20210112.gappssmtp.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-transfer-encoding:user-agent:mime-version; bh=Xn5U6yTCivKcEB2CQHYVzvugp+BfiT1C9G92C8VTcFE=; b=613RfUCkNkGQMLtU7V2MbO04fhnH0mtvC5dKJO2n7m5TCcstyJMNMqLu5YY/jKx85W WqQMLAi27pfXea2pgAxcenjo+QPeoTl9CYin1epFcZK/vTqiQCqBD1EYkVVK5uDXlJOk /REj65VNDa+2mfoDGydpq55FH9UXhemjGynB7O4/KvsjpjTKj3iXzE5se/WNWb3HwcDQ Qm8tyvsIiyWLkoQC0YSKGsXgM6jbVZQWXTcSfHhc7xpqFpsgqnP3lP5KbJsA0tnl+2AB IlaRWg/QdubW8ftDo3KKzJL3UuG4GA8jNRl6v8rVtjb0Mt6ik6HtmbEE25xxiVEQixz1 wZZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=Xn5U6yTCivKcEB2CQHYVzvugp+BfiT1C9G92C8VTcFE=; b=MED+pThT2bM2JiF5WJ0fwjmeXRl7X5lVVapRfgMUdqqJKGq8AEQxcc0IpuwUaRTgyN yRxPd9MpIM8OQmjRalwWH2gahFliSqX9KJI9UUNdvPIgnO0Y0z61O0dzA4ldKEjBXmTT 5gNBcy1m4zfcNxr8phEYcwkoQnjwLadV6wiYd/Az08HHYs+6htfQQJkB5iYmpGtzcD29 W4qwaK7EV01AEqA/cm9mQLqiUCj2SlrM6JuIbtkE3tNJNHhKrjmrccw30gAC7S9oa4A5 s0wEPaZ5nkd4Gvq3HzUHBP/bf8BiBWxqdeu5eqQSfPsiGfodyaF9m3Xyi5ghzNAJ5JzW mTMA== X-Gm-Message-State: AOAM530wK8ndJpoyxi0NyVIpvjedhC9PKRAuEmP/XIkqENOhODZ8Bsh0 MuFOR+zzwXCc2Dt9XGRKIpfTig== X-Google-Smtp-Source: ABdhPJyz6Dah76Tro/nBusft/e8MUMRJGJMekMTnnVzKmUelFUurRZI3FxaqFWMN0HWssy5n6ZNO1g== X-Received: by 2002:ac8:5a42:0:b0:305:222b:8ec9 with SMTP id o2-20020ac85a42000000b00305222b8ec9mr5296612qta.214.1655228768303; Tue, 14 Jun 2022 10:46:08 -0700 (PDT) Received: from nicolas-tpx395.localdomain (192-222-136-102.qc.cable.ebox.net. [192.222.136.102]) by smtp.gmail.com with ESMTPSA id q12-20020a05622a030c00b00304dd83a9b1sm8255216qtw.82.2022.06.14.10.46.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 10:46:07 -0700 (PDT) Message-ID: <5316234cef174e49110f949991ef71c578a3478e.camel@ndufresne.ca> Subject: Re: [PATCH v4, 0/3] add h264 decoder driver for mt8186 From: Nicolas Dufresne To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , AngeloGioacchino Del Regno , Benjamin Gaignard , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Cc: George Sun , Xiaoyong Lu , Hsin-Yi Wang , Fritz Koenig , Daniel Vetter , dri-devel , Irui Wang , Steve Cho , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Date: Tue, 14 Jun 2022 13:46:06 -0400 In-Reply-To: References: <20220512034620.30500-1-yunfei.dong@mediatek.com> User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_104611_841403_DF17039F X-CRM114-Status: GOOD ( 19.26 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org TGUgbHVuZGkgMTMganVpbiAyMDIyIMOgIDE2OjEwIC0wNDAwLCBOaWNvbGFzIER1ZnJlc25lIGEg w6ljcml0wqA6Cj4gTGUgamV1ZGkgMTIgbWFpIDIwMjIgw6AgMTE6NDYgKzA4MDAsIFl1bmZlaSBE b25nIGEgw6ljcml0wqA6Cj4gPiBGaXJzdGx5LCBhZGQgbXQ4MTg2IGNvbXBhdGlibGUgYW5kIHBy aXZhdGUgZGF0YSwgdGhlbiBhZGQgZG9jdW1lbnQgZm9yCj4gPiBjb21wYXRpYmxlICJtZWRpYXRl ayxtdDgxODYtdmNvZGVjLWRlYyIuIEZvciBtdDgxODYgaXMgc2luZ2xlIGNvcmUKPiA+IGFyY2hp dGVjdHVyZSwgbmVlZCB0byBhZGQgbmV3IGludGVyZmFjZSBmb3IgaDI2NCBoYXJkd2FyZSBkZWNv ZGVyLgo+IAo+IFdvdWxkIGJlIG5pY2UgdG8gdGFrZSB0aGUgaGFiaXQgb2Ygc2hhcmluZyBmbHVz dGVyIHNjb3JlIGZvciB0aGlzIG5ldyBIVywgSQo+IHdvdWxkIGV4cGVjdCBubyBsZXNzIHRoZW4g d2hhdCB0aGUgbnVtYmVycyB5b3UnZCBnZXQgZnJvbSBydW5uaW5nIG92ZXIgTVQ4MTk1IG9yCj4g OTIsIHJlbWFpbnMgbmljZSB0byBkZW1vbnN0cmF0ZSB0aGF0IHRoaXMgd2FzIHRlc3RlZCBhbmQg ZG9jdW1lbnQgYW55IG9vcHMgYWxvbmcKPiB0aGUgd2F5Lgo+ID4gCj4gPiBQYXRjaGUgMSBhZGQg bXQ4MTg2IGNvbXBhdGlibGUgYW5kIHByaXZhdGUgZGF0YS4KPiA+IFBhdGNoZSAyIGFkZCBtdDgx ODYgY29tcGF0aWJsZSBkb2N1bWVudC4KPiA+IFBhdGNoZSAzIGFkZCBoMjY0IHNpbmdsZSBjb3Jl IGRyaXZlci4KPiA+IC0tLQo+ID4gVGhpcyBwYXRjaCBkZXBlbmRzIG9uICJzdXBwb3J0IGZvciBN VDgxOTIgZGVjb2RlciJbMV0KPiA+IAo+ID4gWzFdICBodHRwczovL3BhdGNod29yay5rZXJuZWwu b3JnL3Byb2plY3QvbGludXgtbWVkaWF0ZWsvY292ZXIvMjAyMjA1MTIwMjE5NTAuMjkwODctMS15 dW5mZWkuZG9uZ0BtZWRpYXRlay5jb20vCgpJIGZvcmdvdCBlYXJsaWVyLCBidXQgSSBzdXBwb3Nl IHRoaXMgd2lsbCBhbHNvIGRlcGVuZHMgb24gYW4gc2NwLmltZyBmaXJtd2FyZSA/CklmIHNvLCBh bnkgbGludXgtZmlybXdhcmUgc3VibWlzc2lvbiB0byBsaW5rIHRvID8KCj4gPiAtLS0KPiA+IGNo YW5nZWQgd2l0aCB2MzoKPiA+IC0gZml4IF9faW9tZW0gbm90IHJlYXNvbmFibGUsIGFsaWduIHNo YXJlIG1lbW9yeSB0byBkcmFtLgo+ID4gY2hhbmdlZCB3aXRoIHYyOgo+ID4gLSBmaXggc3BhcnNl IGFuZCBzbWF0Y2ggY2hlY2sgZmFpbCBmb3IgcGF0Y2ggMwo+ID4gY2hhbmdlZCB3aXRoIHYxOgo+ ID4gLSByZWJhc2UgZHJpdmVyIHRvIHRoZSBsYXRlc3QgbWVkaWFfc3RhZ2UuCj4gPiAtLS0KPiA+ IFl1bmZlaSBEb25nICgzKToKPiA+ICAgZHQtYmluZGluZ3M6IG1lZGlhOiBtZWRpYXRlazogdmNv ZGVjOiBBZGRzIGRlY29kZXIgZHQtYmluZGluZ3MgZm9yCj4gPiAgICAgbXQ4MTg2Cj4gPiAgIG1l ZGlhOiBtZWRpYXRlazogdmNvZGVjOiBTdXBwb3J0IE1UODE4Ngo+ID4gICBtZWRpYTogbWVkaWF0 ZWs6IHZjb2RlYzogYWRkIGgyNjQgZGVjb2RlciBkcml2ZXIgZm9yIG10ODE4Ngo+ID4gCj4gPiAg Li4uL21lZGlhL21lZGlhdGVrLHZjb2RlYy1zdWJkZXYtZGVjb2Rlci55YW1sIHwgICA0ICstCj4g PiAgLi4uL3BsYXRmb3JtL21lZGlhdGVrL3Zjb2RlYy9tdGtfdmNvZGVjX2RlYy5oIHwgICAxICsK PiA+ICAuLi4vbWVkaWF0ZWsvdmNvZGVjL210a192Y29kZWNfZGVjX2Rydi5jICAgICAgfCAgIDQg Kwo+ID4gIC4uLi92Y29kZWMvbXRrX3Zjb2RlY19kZWNfc3RhdGVsZXNzLmMgICAgICAgICB8ICAx OSArKwo+ID4gIC4uLi92Y29kZWMvdmRlYy92ZGVjX2gyNjRfcmVxX211bHRpX2lmLmMgICAgICB8 IDE3NyArKysrKysrKysrKysrKysrKy0KPiA+ICA1IGZpbGVzIGNoYW5nZWQsIDIwMyBpbnNlcnRp b25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4gCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KTGludXgtbWVkaWF0ZWsgbWFpbGluZyBsaXN0CkxpbnV4 LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1tZWRpYXRlawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BEA84C433EF for ; Tue, 14 Jun 2022 17:46:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CE39F10E1BA; Tue, 14 Jun 2022 17:46:09 +0000 (UTC) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by gabe.freedesktop.org (Postfix) with ESMTPS id 45FC210E1BA for ; Tue, 14 Jun 2022 17:46:09 +0000 (UTC) Received: by mail-qt1-x831.google.com with SMTP id x18so6642101qtj.3 for ; Tue, 14 Jun 2022 10:46:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20210112.gappssmtp.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-transfer-encoding:user-agent:mime-version; bh=Xn5U6yTCivKcEB2CQHYVzvugp+BfiT1C9G92C8VTcFE=; b=613RfUCkNkGQMLtU7V2MbO04fhnH0mtvC5dKJO2n7m5TCcstyJMNMqLu5YY/jKx85W WqQMLAi27pfXea2pgAxcenjo+QPeoTl9CYin1epFcZK/vTqiQCqBD1EYkVVK5uDXlJOk /REj65VNDa+2mfoDGydpq55FH9UXhemjGynB7O4/KvsjpjTKj3iXzE5se/WNWb3HwcDQ Qm8tyvsIiyWLkoQC0YSKGsXgM6jbVZQWXTcSfHhc7xpqFpsgqnP3lP5KbJsA0tnl+2AB IlaRWg/QdubW8ftDo3KKzJL3UuG4GA8jNRl6v8rVtjb0Mt6ik6HtmbEE25xxiVEQixz1 wZZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=Xn5U6yTCivKcEB2CQHYVzvugp+BfiT1C9G92C8VTcFE=; b=iuJeTEGdeLfkeQfGj3WrFPzb3zKe6rTt/oAnxrl7qjuKfoygINitdeCHTBPEcjbC5D Ki8fIsQR9hb7zqTTAqZoedaJEaawPjFWT7nvIrrcwNe3FR9ehv9/m9ILUfTWKHhr/CoT fQJUjleQpNRVCkAzFn5sGNlp8Ubx3D8godKOTN+0Tq7NDesWPQJcAmROw6onhW7g7C8O uG76Izf+1oyNvYe/eZ5/ck3i35EyoXN941uTeayGHTV4Z/Xtl2gzPB0oLF5WiGNt2vVK Z0yOtHB2q5xV9m+iiKGPm8tbwmzEXGkYHErNxWYnkzREBk3B+K2CkxxIG5FohmS0ae6y KeyQ== X-Gm-Message-State: AOAM531jUlZwiWLwJOJnAIJPkKGnHZFBgOcKHfnDiN9Uq2WD65c3ls0T lmZ5ZUE7YI6xF8QElzvFuYpuOA== X-Google-Smtp-Source: ABdhPJyz6Dah76Tro/nBusft/e8MUMRJGJMekMTnnVzKmUelFUurRZI3FxaqFWMN0HWssy5n6ZNO1g== X-Received: by 2002:ac8:5a42:0:b0:305:222b:8ec9 with SMTP id o2-20020ac85a42000000b00305222b8ec9mr5296612qta.214.1655228768303; Tue, 14 Jun 2022 10:46:08 -0700 (PDT) Received: from nicolas-tpx395.localdomain (192-222-136-102.qc.cable.ebox.net. [192.222.136.102]) by smtp.gmail.com with ESMTPSA id q12-20020a05622a030c00b00304dd83a9b1sm8255216qtw.82.2022.06.14.10.46.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 10:46:07 -0700 (PDT) Message-ID: <5316234cef174e49110f949991ef71c578a3478e.camel@ndufresne.ca> Subject: Re: [PATCH v4, 0/3] add h264 decoder driver for mt8186 From: Nicolas Dufresne To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , AngeloGioacchino Del Regno , Benjamin Gaignard , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Date: Tue, 14 Jun 2022 13:46:06 -0400 In-Reply-To: References: <20220512034620.30500-1-yunfei.dong@mediatek.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Irui Wang , George Sun , Steve Cho , devicetree@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, linux-kernel@vger.kernel.org, dri-devel , Xiaoyong Lu , linux-mediatek@lists.infradead.org, Hsin-Yi Wang , Fritz Koenig , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Le lundi 13 juin 2022 =C3=A0 16:10 -0400, Nicolas Dufresne a =C3=A9crit=C2= =A0: > Le jeudi 12 mai 2022 =C3=A0 11:46 +0800, Yunfei Dong a =C3=A9crit=C2=A0: > > Firstly, add mt8186 compatible and private data, then add document for > > compatible "mediatek,mt8186-vcodec-dec". For mt8186 is single core > > architecture, need to add new interface for h264 hardware decoder. >=20 > Would be nice to take the habit of sharing fluster score for this new HW,= I > would expect no less then what the numbers you'd get from running over MT= 8195 or > 92, remains nice to demonstrate that this was tested and document any oop= s along > the way. > >=20 > > Patche 1 add mt8186 compatible and private data. > > Patche 2 add mt8186 compatible document. > > Patche 3 add h264 single core driver. > > --- > > This patch depends on "support for MT8192 decoder"[1] > >=20 > > [1] https://patchwork.kernel.org/project/linux-mediatek/cover/20220512= 021950.29087-1-yunfei.dong@mediatek.com/ I forgot earlier, but I suppose this will also depends on an scp.img firmwa= re ? If so, any linux-firmware submission to link to ? > > --- > > changed with v3: > > - fix __iomem not reasonable, align share memory to dram. > > changed with v2: > > - fix sparse and smatch check fail for patch 3 > > changed with v1: > > - rebase driver to the latest media_stage. > > --- > > Yunfei Dong (3): > > dt-bindings: media: mediatek: vcodec: Adds decoder dt-bindings for > > mt8186 > > media: mediatek: vcodec: Support MT8186 > > media: mediatek: vcodec: add h264 decoder driver for mt8186 > >=20 > > .../media/mediatek,vcodec-subdev-decoder.yaml | 4 +- > > .../platform/mediatek/vcodec/mtk_vcodec_dec.h | 1 + > > .../mediatek/vcodec/mtk_vcodec_dec_drv.c | 4 + > > .../vcodec/mtk_vcodec_dec_stateless.c | 19 ++ > > .../vcodec/vdec/vdec_h264_req_multi_if.c | 177 +++++++++++++++++- > > 5 files changed, 203 insertions(+), 2 deletions(-) > >=20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CFC1C43334 for ; Tue, 14 Jun 2022 17:47:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ieMx3fEWp6JvuTHD4Bi3oE7xENqS9UV4++Iwp0yWce4=; b=a+u9Ifu3Dw1Z2B fZlO/zudmhahua2bFcK4tt1lpLsZAxkEfJqaAIlhkUrYvcR01ogY1GySmmoHI+GI+q6rxNd1RbYy8 2w+K5gRTRhJ79as3NzzIWk/rJEKGGL872CduacAPXNBZktbnMzibDyTFl+b9bueOw91R09529l+Fk py/O6N/fUiygq7jSwE/1irmDyWoyeUtA//ZCUfvNG5JSxYQ9ADOtP5fI5UUuw2H32RDKMJE1efzTf zZKU8UxQ4k0wuObRTC/ssx1VPqi+uYoUBZurgA5IXDgsr1f26/m9hq5GnjNjopnGpflz/eqeGUcrL rXo8vgVJozz7G9kxcISA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1AcK-00AcB6-GR; Tue, 14 Jun 2022 17:46:16 +0000 Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1AcF-00Ac8E-GA for linux-arm-kernel@lists.infradead.org; Tue, 14 Jun 2022 17:46:14 +0000 Received: by mail-qt1-x82f.google.com with SMTP id hf10so6630609qtb.7 for ; Tue, 14 Jun 2022 10:46:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20210112.gappssmtp.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-transfer-encoding:user-agent:mime-version; bh=Xn5U6yTCivKcEB2CQHYVzvugp+BfiT1C9G92C8VTcFE=; b=613RfUCkNkGQMLtU7V2MbO04fhnH0mtvC5dKJO2n7m5TCcstyJMNMqLu5YY/jKx85W WqQMLAi27pfXea2pgAxcenjo+QPeoTl9CYin1epFcZK/vTqiQCqBD1EYkVVK5uDXlJOk /REj65VNDa+2mfoDGydpq55FH9UXhemjGynB7O4/KvsjpjTKj3iXzE5se/WNWb3HwcDQ Qm8tyvsIiyWLkoQC0YSKGsXgM6jbVZQWXTcSfHhc7xpqFpsgqnP3lP5KbJsA0tnl+2AB IlaRWg/QdubW8ftDo3KKzJL3UuG4GA8jNRl6v8rVtjb0Mt6ik6HtmbEE25xxiVEQixz1 wZZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=Xn5U6yTCivKcEB2CQHYVzvugp+BfiT1C9G92C8VTcFE=; b=43jQHi0z1Dl2oH0XKGEf7jWrt3Vzjn1SsWG4vqHElcrJDA6HRH0bdbUV3pvOAs8Gz0 NOZ+T8wh4q0g9ISD69KNGUOlmqCvJN14k5RI1mHistL348xlsKP6om0yVCKZuQGchCr7 HnjN8FmxnqoquUS5R+VIAOByLACyPFoZ6GkuQvrQywHsK2jnSHeczqvvqnpKXCtG4kmi 8DZ829BK+m8F4ToGtXM4BWV6lu6eslqEm5W5muqWVnqYrCJs5dQ/o8kwZYKSnVzaXy25 PHHdFzb4jxGXvQ0IQR3J0OmjXZuTjlAG5mgqkHLRg9F7q5hgvnlnN+6/+uEzh/W2NqlI s1Xg== X-Gm-Message-State: AOAM531qOKuq2qh7dtLoc4fXOwf5YY2DZyNzyGYcIFn7zT2jV+NbCeUH m9S/HE0ztKNOVUgxH5EGTIhLgA== X-Google-Smtp-Source: ABdhPJyz6Dah76Tro/nBusft/e8MUMRJGJMekMTnnVzKmUelFUurRZI3FxaqFWMN0HWssy5n6ZNO1g== X-Received: by 2002:ac8:5a42:0:b0:305:222b:8ec9 with SMTP id o2-20020ac85a42000000b00305222b8ec9mr5296612qta.214.1655228768303; Tue, 14 Jun 2022 10:46:08 -0700 (PDT) Received: from nicolas-tpx395.localdomain (192-222-136-102.qc.cable.ebox.net. [192.222.136.102]) by smtp.gmail.com with ESMTPSA id q12-20020a05622a030c00b00304dd83a9b1sm8255216qtw.82.2022.06.14.10.46.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 10:46:07 -0700 (PDT) Message-ID: <5316234cef174e49110f949991ef71c578a3478e.camel@ndufresne.ca> Subject: Re: [PATCH v4, 0/3] add h264 decoder driver for mt8186 From: Nicolas Dufresne To: Yunfei Dong , Alexandre Courbot , Hans Verkuil , AngeloGioacchino Del Regno , Benjamin Gaignard , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa Cc: George Sun , Xiaoyong Lu , Hsin-Yi Wang , Fritz Koenig , Daniel Vetter , dri-devel , Irui Wang , Steve Cho , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Date: Tue, 14 Jun 2022 13:46:06 -0400 In-Reply-To: References: <20220512034620.30500-1-yunfei.dong@mediatek.com> User-Agent: Evolution 3.44.1 (3.44.1-1.fc36) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_104611_842719_B2C2A52F X-CRM114-Status: GOOD ( 20.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TGUgbHVuZGkgMTMganVpbiAyMDIyIMOgIDE2OjEwIC0wNDAwLCBOaWNvbGFzIER1ZnJlc25lIGEg w6ljcml0wqA6Cj4gTGUgamV1ZGkgMTIgbWFpIDIwMjIgw6AgMTE6NDYgKzA4MDAsIFl1bmZlaSBE b25nIGEgw6ljcml0wqA6Cj4gPiBGaXJzdGx5LCBhZGQgbXQ4MTg2IGNvbXBhdGlibGUgYW5kIHBy aXZhdGUgZGF0YSwgdGhlbiBhZGQgZG9jdW1lbnQgZm9yCj4gPiBjb21wYXRpYmxlICJtZWRpYXRl ayxtdDgxODYtdmNvZGVjLWRlYyIuIEZvciBtdDgxODYgaXMgc2luZ2xlIGNvcmUKPiA+IGFyY2hp dGVjdHVyZSwgbmVlZCB0byBhZGQgbmV3IGludGVyZmFjZSBmb3IgaDI2NCBoYXJkd2FyZSBkZWNv ZGVyLgo+IAo+IFdvdWxkIGJlIG5pY2UgdG8gdGFrZSB0aGUgaGFiaXQgb2Ygc2hhcmluZyBmbHVz dGVyIHNjb3JlIGZvciB0aGlzIG5ldyBIVywgSQo+IHdvdWxkIGV4cGVjdCBubyBsZXNzIHRoZW4g d2hhdCB0aGUgbnVtYmVycyB5b3UnZCBnZXQgZnJvbSBydW5uaW5nIG92ZXIgTVQ4MTk1IG9yCj4g OTIsIHJlbWFpbnMgbmljZSB0byBkZW1vbnN0cmF0ZSB0aGF0IHRoaXMgd2FzIHRlc3RlZCBhbmQg ZG9jdW1lbnQgYW55IG9vcHMgYWxvbmcKPiB0aGUgd2F5Lgo+ID4gCj4gPiBQYXRjaGUgMSBhZGQg bXQ4MTg2IGNvbXBhdGlibGUgYW5kIHByaXZhdGUgZGF0YS4KPiA+IFBhdGNoZSAyIGFkZCBtdDgx ODYgY29tcGF0aWJsZSBkb2N1bWVudC4KPiA+IFBhdGNoZSAzIGFkZCBoMjY0IHNpbmdsZSBjb3Jl IGRyaXZlci4KPiA+IC0tLQo+ID4gVGhpcyBwYXRjaCBkZXBlbmRzIG9uICJzdXBwb3J0IGZvciBN VDgxOTIgZGVjb2RlciJbMV0KPiA+IAo+ID4gWzFdICBodHRwczovL3BhdGNod29yay5rZXJuZWwu b3JnL3Byb2plY3QvbGludXgtbWVkaWF0ZWsvY292ZXIvMjAyMjA1MTIwMjE5NTAuMjkwODctMS15 dW5mZWkuZG9uZ0BtZWRpYXRlay5jb20vCgpJIGZvcmdvdCBlYXJsaWVyLCBidXQgSSBzdXBwb3Nl IHRoaXMgd2lsbCBhbHNvIGRlcGVuZHMgb24gYW4gc2NwLmltZyBmaXJtd2FyZSA/CklmIHNvLCBh bnkgbGludXgtZmlybXdhcmUgc3VibWlzc2lvbiB0byBsaW5rIHRvID8KCj4gPiAtLS0KPiA+IGNo YW5nZWQgd2l0aCB2MzoKPiA+IC0gZml4IF9faW9tZW0gbm90IHJlYXNvbmFibGUsIGFsaWduIHNo YXJlIG1lbW9yeSB0byBkcmFtLgo+ID4gY2hhbmdlZCB3aXRoIHYyOgo+ID4gLSBmaXggc3BhcnNl IGFuZCBzbWF0Y2ggY2hlY2sgZmFpbCBmb3IgcGF0Y2ggMwo+ID4gY2hhbmdlZCB3aXRoIHYxOgo+ ID4gLSByZWJhc2UgZHJpdmVyIHRvIHRoZSBsYXRlc3QgbWVkaWFfc3RhZ2UuCj4gPiAtLS0KPiA+ IFl1bmZlaSBEb25nICgzKToKPiA+ICAgZHQtYmluZGluZ3M6IG1lZGlhOiBtZWRpYXRlazogdmNv ZGVjOiBBZGRzIGRlY29kZXIgZHQtYmluZGluZ3MgZm9yCj4gPiAgICAgbXQ4MTg2Cj4gPiAgIG1l ZGlhOiBtZWRpYXRlazogdmNvZGVjOiBTdXBwb3J0IE1UODE4Ngo+ID4gICBtZWRpYTogbWVkaWF0 ZWs6IHZjb2RlYzogYWRkIGgyNjQgZGVjb2RlciBkcml2ZXIgZm9yIG10ODE4Ngo+ID4gCj4gPiAg Li4uL21lZGlhL21lZGlhdGVrLHZjb2RlYy1zdWJkZXYtZGVjb2Rlci55YW1sIHwgICA0ICstCj4g PiAgLi4uL3BsYXRmb3JtL21lZGlhdGVrL3Zjb2RlYy9tdGtfdmNvZGVjX2RlYy5oIHwgICAxICsK PiA+ICAuLi4vbWVkaWF0ZWsvdmNvZGVjL210a192Y29kZWNfZGVjX2Rydi5jICAgICAgfCAgIDQg Kwo+ID4gIC4uLi92Y29kZWMvbXRrX3Zjb2RlY19kZWNfc3RhdGVsZXNzLmMgICAgICAgICB8ICAx OSArKwo+ID4gIC4uLi92Y29kZWMvdmRlYy92ZGVjX2gyNjRfcmVxX211bHRpX2lmLmMgICAgICB8 IDE3NyArKysrKysrKysrKysrKysrKy0KPiA+ICA1IGZpbGVzIGNoYW5nZWQsIDIwMyBpbnNlcnRp b25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4gCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=