From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59029) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLIkN-00082v-II for qemu-devel@nongnu.org; Wed, 05 Mar 2014 15:49:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLIkI-0002fb-L1 for qemu-devel@nongnu.org; Wed, 05 Mar 2014 15:48:59 -0500 Message-ID: <53178DB3.4000801@suse.de> Date: Wed, 05 Mar 2014 21:48:51 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1391947053-26753-1-git-send-email-afaerber@suse.de> <1392004376-17016-1-git-send-email-aik@ozlabs.ru> <1392004376-17016-2-git-send-email-aik@ozlabs.ru> <52F93745.8090703@suse.de> <52FD9583.6080005@ozlabs.ru> In-Reply-To: <52FD9583.6080005@ozlabs.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] tests-ppc64: add to cleanup rule List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org, Peter Maydell Cc: Paolo Bonzini , qemu-ppc@nongnu.org, Alexander Graf , Markus Armbruster Am 14.02.2014 05:03, schrieb Alexey Kardashevskiy: > On 02/11/2014 07:32 AM, Andreas F=C3=A4rber wrote: >> Am 10.02.2014 04:52, schrieb Alexey Kardashevskiy: >>> This adds $(check-qtest-ppc64-y) to the check-clean rule. >>> >>> Signed-off-by: Alexey Kardashevskiy >> >> Nice catch! >> >>> --- >>> tests/Makefile | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/tests/Makefile b/tests/Makefile >>> index 0aaf657..3a00ea7 100644 >>> --- a/tests/Makefile >>> +++ b/tests/Makefile >>> @@ -319,7 +319,7 @@ check-block: $(patsubst %,check-%, $(check-block-= y)) >>> check: check-qapi-schema check-unit check-qtest >>> check-clean: >>> $(MAKE) -C tests/tcg clean >>> - rm -rf $(check-unit-y) $(check-qtest-i386-y) $(check-qtest-x86_64-y= ) $(check-qtest-sparc64-y) $(check-qtest-sparc-y) tests/*.o $(QEMU_IOTEST= S_HELPERS-y) >>> + rm -rf $(check-unit-y) $(check-qtest-i386-y) $(check-qtest-x86_64-y= ) $(check-qtest-sparc64-y) $(check-qtest-sparc-y) $(check-qtest-ppc64-y) = tests/*.o $(QEMU_IOTESTS_HELPERS-y) >>> =20 >>> clean: check-clean >>> =20 >> >> Can we use a $(foreach ...) for $(check-qtest-*-y) like Peter did for >> adding qom-test? >> >> http://patchwork.ozlabs.org/patch/313650/ >=20 > Like this? Maybe. Waiting for review from Peter (who did the foreach for qom-test) or anyone. > Against what should I rebase my patches and repost them? Sorry, didn't see this question... Pushed a new working branch: https://github.com/afaerber/qemu-cpu/commits/qtest Some more tests were already pulled in, queue for upstream is: https://github.com/afaerber/qemu-cpu/commits/qom-next Regards, Andreas > diff --git a/tests/Makefile b/tests/Makefile > index 94b32b7..2577843 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -323,7 +323,9 @@ check-block: $(patsubst %,check-%, $(check-block-y)= ) > check: check-qapi-schema check-unit check-qtest > check-clean: > $(MAKE) -C tests/tcg clean > - rm -rf $(check-unit-y) $(check-qtest-i386-y) > $(check-qtest-x86_64-y) $(check-qtest-sparc64-y) $(check-qtest-sparc-y)= t > + $(eval rmlist =3D $(check-unit-y) tests/*.o $(QEMU_IOTESTS_HELP= ERS-y)) > + $(foreach target,$(SYSEMU_TARGET_LIST), $(eval rmlist +=3D > $(check-qtest-$(target)-y))) > + rm -rf $(rmlist) >=20 > clean: check-clean >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg