From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [RFC PATCH v2 19/21] ARM: dts: exynos5250-arndale: add dsi and panel nodes Date: Fri, 07 Mar 2014 14:07:52 +0100 Message-ID: <5319C4A8.8080900@samsung.com> References: <1392204688-4591-1-git-send-email-a.hajda@samsung.com> <1392204688-4591-20-git-send-email-a.hajda@samsung.com> <53108FA0.4040903@ti.com> <53109193.3000604@ti.com> <5315C07B.3090705@samsung.com> <5319B9FF.50201@samsung.com> <5319BC45.4040308@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <5319BC45.4040308@ti.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Tomi Valkeinen Cc: Inki Dae , DRI mailing list , Mark Rutland , "devicetree@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , Pawel Moll , Ian Campbell , Kyungmin Park , Rob Herring , Kumar Gala , Grant Likely , Marek Szyprowski List-Id: devicetree@vger.kernel.org On 03/07/2014 01:32 PM, Tomi Valkeinen wrote: > On 07/03/14 14:22, Andrzej Hajda wrote: > >> I think we should even extend the bindings to fimd: >> dsi { >> port@0 { >> dsi_0: endpoint { >> remote-endpoint=<&fimd_0>; >> } >> } >> port@1 { >> dsi_1: endpoint { >> remote-endpoint=<&lvds_0>; >> } >> } >> } >> >> fimd { >> port@0 { >> fimd_0: endpoint { >> remote-endpoint=<&dsi_0>; >> } >> } >> } > If both fimd and dsi are SoC components, I don't see any strict need for > that. I think the ports/endpoints are only important when dealing with > external components, which can be used on any platform. For SoC internal > components you can have relevant data directly in the drivers, as it is > fixed (for that SoC). > > Of course, if using ports for SoC internal components makes things > easier for you, I don't see any problems with it either. There are many possible connections from FIMD, some of them: FIMD ---> RGB panel, external FIMD ---> DSI, on SoC FIMD ---> eDP, on SoC FIMD ---> ImageEnhacer, on SoC In the first case port should be created. In other cases connection could be determined by presence/absence of specific nodes, so in fact the port can be optional, almost like in my proposal :) > > For OMAP, the SoC's display blocks are all inside one bigger DSS > "container", so I have not seen need to represent the connections > between the internal components in the DT data. How do you deal with situation when IPs in SoC can be connected in different ways ? Andrzej > If the display components were truly independent IPs on the SoC, then > using ports might make things easier. > > Tomi > >