All of lore.kernel.org
 help / color / mirror / Atom feed
From: Henrik Rydberg <rydberg@euromail.se>
To: Roger Quadros <rogerq@ti.com>, dmitry.torokhov@gmail.com
Cc: jcbian@pixcir.com.cn, balbi@ti.com, dmurphy@ti.com,
	mugunthanvnm@ti.com, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 4/8] Input: pixcir_i2c_ts: Use Type-B Multi-Touch protocol
Date: Sat, 08 Mar 2014 16:11:45 +0100	[thread overview]
Message-ID: <531B3331.9050008@euromail.se> (raw)
In-Reply-To: <1393428486-15001-5-git-send-email-rogerq@ti.com>

Hi Roger,

the MT implementation seems mostly fine, just one curiosity:

>  static irqreturn_t pixcir_ts_isr(int irq, void *dev_id)
>  {
>  	struct pixcir_i2c_ts_data *tsdata = dev_id;
>  	const struct pixcir_ts_platform_data *pdata = tsdata->chip;
> +	struct pixcir_report_data report;
>  
>  	while (!tsdata->exiting) {
> -		pixcir_ts_poscheck(tsdata);
> -
> -		if (gpio_get_value(pdata->gpio_attb))
> +		/* parse packet */
> +		pixcir_ts_parse(tsdata, &report);
> +
> +		/* report it */
> +		pixcir_ts_report(tsdata, &report);
> +
> +		if (gpio_get_value(pdata->gpio_attb)) {
> +			if (report.num_touches) {
> +				/*
> +				 * Last report with no finger up?
> +				 * Do it now then.
> +				 */
> +				input_mt_sync_frame(tsdata->input);
> +				input_sync(tsdata->input);

Why is this special handling needed?

Thanks,
Henrik


  reply	other threads:[~2014-03-08 15:31 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26 15:27 [PATCH v2 0/8] Input: pixcir_i2c_ts: Add Type-B Multi-touch and DT support Roger Quadros
2014-02-26 15:27 ` Roger Quadros
2014-02-26 15:27 ` [PATCH v2 1/8] Input: pixcir_i2c_ts: Use devres managed resource allocations Roger Quadros
2014-02-26 15:27   ` Roger Quadros
2014-02-26 15:28 ` [PATCH v2 2/8] Input: pixcir_i2c_ts: Initialize interrupt mode and power mode Roger Quadros
2014-02-26 15:28   ` Roger Quadros
2014-02-26 15:28 ` [PATCH v2 3/8] Input: pixcir_i2c_ts: Get rid of pdata->attb_read_val() Roger Quadros
2014-02-26 15:28   ` Roger Quadros
2014-02-26 15:41   ` Felipe Balbi
2014-02-26 15:41     ` Felipe Balbi
2014-02-26 15:28 ` [PATCH v2 4/8] Input: pixcir_i2c_ts: Use Type-B Multi-Touch protocol Roger Quadros
2014-02-26 15:28   ` Roger Quadros
2014-03-08 15:11   ` Henrik Rydberg [this message]
2014-03-10  8:57     ` Roger Quadros
2014-03-10  8:57       ` Roger Quadros
2014-03-10 16:37       ` Felipe Balbi
2014-03-10 16:37         ` Felipe Balbi
2014-03-11  9:35         ` Roger Quadros
2014-03-11  9:35           ` Roger Quadros
2014-03-19 11:27         ` Roger Quadros
2014-03-19 11:27           ` Roger Quadros
2014-02-26 15:28 ` [PATCH v2 5/8] Input: pixcir_i2c_ts: support upto 5 fingers and hardware provided tracking IDs Roger Quadros
2014-02-26 15:28   ` Roger Quadros
2014-02-26 15:28 ` [PATCH v2 6/8] Input: pixcir_i2c_ts: Implement wakeup from suspend Roger Quadros
2014-02-26 15:28   ` Roger Quadros
2014-02-26 15:28 ` [PATCH v2 7/8] Input: pixcir_i2c_ts: Add device tree support Roger Quadros
2014-02-26 15:28   ` Roger Quadros
2014-02-26 15:28 ` [PATCH v2 8/8] ARM: dts: am43x-epos-evm: Correct Touch controller info Roger Quadros
2014-02-26 15:28   ` Roger Quadros
2014-03-04 11:24 ` [PATCH v2 0/8] Input: pixcir_i2c_ts: Add Type-B Multi-touch and DT support Roger Quadros
2014-03-04 11:24   ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=531B3331.9050008@euromail.se \
    --to=rydberg@euromail.se \
    --cc=balbi@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dmurphy@ti.com \
    --cc=jcbian@pixcir.com.cn \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mugunthanvnm@ti.com \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.