From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNQ8r-0006Pm-G8 for qemu-devel@nongnu.org; Tue, 11 Mar 2014 13:07:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNQ8n-0005lq-2F for qemu-devel@nongnu.org; Tue, 11 Mar 2014 13:07:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3692) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNQ8m-0005la-Od for qemu-devel@nongnu.org; Tue, 11 Mar 2014 13:06:56 -0400 Message-ID: <531F42AC.5010509@redhat.com> Date: Tue, 11 Mar 2014 11:06:52 -0600 From: Eric Blake MIME-Version: 1.0 References: <1394436721-21812-1-git-send-email-cyliu@suse.com> <1394436721-21812-25-git-send-email-cyliu@suse.com> In-Reply-To: <1394436721-21812-25-git-send-email-cyliu@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ncXTRnn4XxV9fE8GfPfaUKJVxxKOEk1o3" Subject: Re: [Qemu-devel] [PATCH v22 24/25] vvfat.c: replace QEMUOptionParameter with QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Dong Xu Wang , stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ncXTRnn4XxV9fE8GfPfaUKJVxxKOEk1o3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/10/2014 01:32 AM, Chunyan Liu wrote: > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/vvfat.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > bdrv_qcow =3D bdrv_find_format("qcow"); > - options =3D parse_option_parameters("", bdrv_qcow->create_options,= NULL); Problem. This code is broken from the time that patch 11/25 is applied until now. That's because commit 11 changed bdrv_qcow from having create_options over to having create_opts. Do any of the other drivers do cross-driver option sharing? It would be nice to fix that to quit happening, preferably earlier in the series than where you start doing per-driver conversions. > - set_option_parameter_int(options, BLOCK_OPT_SIZE, s->sector_count = * 512); > - set_option_parameter(options, BLOCK_OPT_BACKING_FILE, "fat:"); > + opts =3D qemu_opts_create(bdrv_qcow->create_opts, NULL, 0, &error_= abort); > + qemu_opt_set_number(opts, BLOCK_OPT_SIZE, s->sector_count * 512); > + qemu_opt_set(opts, BLOCK_OPT_BACKING_FILE, "fat:"); > =20 > - ret =3D bdrv_create(bdrv_qcow, s->qcow_filename, options, NULL, &l= ocal_err); > + ret =3D bdrv_create(bdrv_qcow, s->qcow_filename, NULL, opts, &loca= l_err); > if (ret < 0) { > qerror_report_err(local_err); > error_free(local_err); >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ncXTRnn4XxV9fE8GfPfaUKJVxxKOEk1o3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTH0KsAAoJEKeha0olJ0NqyYAIAJFn+vVMmIwZXGqxPgN25+Lo WTRWlL6Ie2E7X9lL+3KQSlRiORxNuExcVxAWzQWUmqYzCQbqlckxDLsxOhdobOqM F+999zpNqjwk3LR777NNnHo1HRk6dRu6D7sa2PMhY3db0ajOaiD0d7wJWQv6xMZy J2Cnn/7nFANpGdgXDR/X1C8ou6pBNez74iYcvJDU08ZlW3XXumL1SPlm/DuRQATz TNVsgPOBoFy0yeMe5AOUsK6yNF4/+qG47yuIX1cM4BnolzOoO1ZdpFX6UemjbuhU mdA+a569/OJZlaaooCqN4MgpVC1p80YtVrES8bzvc/ywvcB3dYqFJkUQJaYNOpE= =fLbn -----END PGP SIGNATURE----- --ncXTRnn4XxV9fE8GfPfaUKJVxxKOEk1o3--