From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNu3U-0001sT-Vq for qemu-devel@nongnu.org; Wed, 12 Mar 2014 21:03:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNu3J-0003AW-17 for qemu-devel@nongnu.org; Wed, 12 Mar 2014 21:03:28 -0400 Received: from mail-pd0-f177.google.com ([209.85.192.177]:46926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNu3I-00038b-RU for qemu-devel@nongnu.org; Wed, 12 Mar 2014 21:03:16 -0400 Received: by mail-pd0-f177.google.com with SMTP id y10so306873pdj.8 for ; Wed, 12 Mar 2014 18:03:15 -0700 (PDT) Message-ID: <532103C9.6070207@ozlabs.ru> Date: Thu, 13 Mar 2014 12:03:05 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1392904246-15575-1-git-send-email-aik@ozlabs.ru> <1392904246-15575-3-git-send-email-aik@ozlabs.ru> <5320A24A.3010105@suse.de> <5320E78C.1020101@ozlabs.ru> <5320EFEE.2030200@suse.de> In-Reply-To: <5320EFEE.2030200@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v5 2/6] qdev: introduce FWPathProvider interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , qemu-ppc@nongnu.org, Alexander Graf On 03/13/2014 10:38 AM, Andreas Färber wrote: > Am 13.03.2014 00:02, schrieb Alexey Kardashevskiy: >> On 03/13/2014 05:07 AM, Andreas Färber wrote: >>> Am 20.02.2014 14:50, schrieb Alexey Kardashevskiy: >>>> QEMU supports firmware names for all devices in the QEMU tree but >>>> some architectures expect some parts of firmware path names in different >>>> format. >>>> >>>> This introduces a firmware-pathname-change interface definition. >>>> If some machines needs to redefine the firmware path format, it has >>>> to add the TYPE_FW_PATH_PROVIDER interface to an object that is above >>>> the device on the QOM tree (typically /machine). >>>> >>>> Signed-off-by: Alexey Kardashevskiy >>>> Signed-off-by: Paolo Bonzini >>> >>> I do not see a reply to my question on v4 and didn't catch bonzini on >>> IRC - guessing the two lines should be swapped since both v4 and v5 were >>> submitted by Alexey? >> >> >> I am actually waiting till machine QOM'fication to finish, then I'll repost >> this patchset. Something changed? > > Yes, machine QOM'ification is queued on qom-next and the pull request > containing it is facing some issues still. But you can already rebase > onto git://github.com/afaerber/qemu-cpu.git qom-next branch. gosh :( so many trees. What tree/branch should I base my "client-architecture-support" which needs new CPU suboptions support? > In short, the pseries machine needs to use type_init(), call > type_register_static(), and the TypeInfo needs to specify as .class_data > the QEMUMachine and a .class_init function that assigns that QEMUMachine > pointer to mc->qemu_machine as done in machine.c. -- Alexey