From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhou Zhu Subject: Re: [PATCH v2 4/4] video: mmp: add device tree support Date: Fri, 14 Mar 2014 18:43:30 +0800 Message-ID: <5322DD52.9070107@marvell.com> References: <1389698184-28761-1-git-send-email-zzhu3@marvell.com> <1389698184-28761-5-git-send-email-zzhu3@marvell.com> <20140217143736.GC19308@e106331-lin.cambridge.arm.com> <5316EF76.1050304@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5316EF76.1050304-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tomi Valkeinen Cc: Zhou Zhu , Mark Rutland , "linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Jean-Christophe Plagniol-Villard , Haojian Zhuang , Sascha Hauer , Jingoo Han , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Chao Xie , Guoqing Li , Lisa Du , Yonghai Huang List-Id: devicetree@vger.kernel.org Hi, Tomi, On 03/05/2014 05:33 PM, Tomi Valkeinen wrote: > I would recommend using the same style that is used in the OMAP DSS, imx > drm and exynos patches that are introducing DT support. They use ports > and endpoints as defined in: > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/media/video-interfaces.txt > > with the addition of a simplified endpoint format, where the 'port' node > is not required. > > To give an idea what it could look like, I've modified your example > above. It's just a rough example, you should study and think how it best > fits for mmp. > > You could use the same format for the internal connections also, but I > didn't touch that. I think internal connections can as well be > configured separately, in a custom format, because there's no need for > external components to connect to the internal links. > > mmp-disp@d420b000 { > compatible = "marvell,mmp-disp"; > reg = <0xd420b000 0x1fc>; > interrupts = <0 41 0x4>; > > internal-connections { > pipe1: pn-path { > input = "panel-graphic"; > output = &disp_out; > } > } > > disp_out: endpoint { > remote-endpoint = <&panel_in>; > marvell,rbswap; > marvell,spi; > }; > > status = "okay"; > } > > panel-xxx { > properties; > > panel_in: endpoint { > remote-endpoint = <&disp_out>; > }; > }; > > Tomi > > Thank you! I will update patches according to this layout later. -- Thanks, -Zhou -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhou Zhu Date: Fri, 14 Mar 2014 10:43:30 +0000 Subject: Re: [PATCH v2 4/4] video: mmp: add device tree support Message-Id: <5322DD52.9070107@marvell.com> List-Id: References: <1389698184-28761-1-git-send-email-zzhu3@marvell.com> <1389698184-28761-5-git-send-email-zzhu3@marvell.com> <20140217143736.GC19308@e106331-lin.cambridge.arm.com> <5316EF76.1050304@ti.com> In-Reply-To: <5316EF76.1050304-l0cyMroinI0@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tomi Valkeinen Cc: Zhou Zhu , Mark Rutland , "linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Jean-Christophe Plagniol-Villard , Haojian Zhuang , Sascha Hauer , Jingoo Han , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Chao Xie , Guoqing Li , Lisa Du , Yonghai Huang Hi, Tomi, On 03/05/2014 05:33 PM, Tomi Valkeinen wrote: > I would recommend using the same style that is used in the OMAP DSS, imx > drm and exynos patches that are introducing DT support. They use ports > and endpoints as defined in: > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/media/video-interfaces.txt > > with the addition of a simplified endpoint format, where the 'port' node > is not required. > > To give an idea what it could look like, I've modified your example > above. It's just a rough example, you should study and think how it best > fits for mmp. > > You could use the same format for the internal connections also, but I > didn't touch that. I think internal connections can as well be > configured separately, in a custom format, because there's no need for > external components to connect to the internal links. > > mmp-disp@d420b000 { > compatible = "marvell,mmp-disp"; > reg = <0xd420b000 0x1fc>; > interrupts = <0 41 0x4>; > > internal-connections { > pipe1: pn-path { > input = "panel-graphic"; > output = &disp_out; > } > } > > disp_out: endpoint { > remote-endpoint = <&panel_in>; > marvell,rbswap; > marvell,spi; > }; > > status = "okay"; > } > > panel-xxx { > properties; > > panel_in: endpoint { > remote-endpoint = <&disp_out>; > }; > }; > > Tomi > > Thank you! I will update patches according to this layout later. -- Thanks, -Zhou