From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH for-4.5 7/8] xen/irq: Handle multiple action per IRQ Date: Tue, 18 Mar 2014 15:08:40 +0000 Message-ID: <53286178.1090003@linaro.org> References: <1390581822-32624-1-git-send-email-julien.grall@linaro.org> <1390581822-32624-8-git-send-email-julien.grall@linaro.org> <1392810905.29739.19.camel@kazak.uk.xensource.com> <530673BD.9010301@linaro.org> <530B5275.7010008@citrix.com> <530B6606020000780011ED39@nat28.tlf.novell.com> <530B5BAC.2010100@linaro.org> <531F28D5.1000901@linaro.org> <531F431D0200007800122EC3@nat28.tlf.novell.com> <53276389.8080109@linaro.org> <1395135184.12847.1.camel@kazak.uk.xensource.com> <53283B8D.4030401@linaro.org> <53285E08.1040508@linaro.org> <1395154945.12847.63.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WPvdE-0000Xr-GJ for xen-devel@lists.xenproject.org; Tue, 18 Mar 2014 15:08:44 +0000 Received: by mail-we0-f172.google.com with SMTP id t61so6039201wes.31 for ; Tue, 18 Mar 2014 08:08:42 -0700 (PDT) In-Reply-To: <1395154945.12847.63.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Keir Fraser , patches@linaro.org, Stefano Stabellini , tim@xen.org, stefano.stabellini@citrix.com, Jan Beulich , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 03/18/2014 03:02 PM, Ian Campbell wrote: >> int num_irqs = dt_number_of_irq(smmu->node); > > assert(num_irqs == 2) here and the rest gets a lot simpler. The maximum > is a property of the hardware I think, so the driver is allowed to make > such assumptions. I know it would be easier ... but you can't assume that num_irqs == 2 :). The number is not determined. -- Julien Grall