From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v6 3/5] ethdev: redesign link speed config API
Date: Sun, 01 Nov 2015 23:16:29 +0100
Message-ID: <5329031.lkkhyj5zos@xps13>
References: <1443993003-1059-1-git-send-email-marcdevel@gmail.com>
 <1445810400-8978-1-git-send-email-marcdevel@gmail.com>
 <1445810400-8978-4-git-send-email-marcdevel@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Marc Sune <marcdevel@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com
 [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 15ADF5A06
 for <dev@dpdk.org>; Sun,  1 Nov 2015 23:20:25 +0100 (CET)
Received: by wicfx6 with SMTP id fx6so39266007wic.1
 for <dev@dpdk.org>; Sun, 01 Nov 2015 14:20:24 -0800 (PST)
In-Reply-To: <1445810400-8978-4-git-send-email-marcdevel@gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-10-25 22:59, Marc Sune:
> This patch redesigns the API to set the link speed/s configure
> for an ethernet port. Specifically:
> 
> - it allows to define a set of advertised speeds for
>   auto-negociation.
> - it allows to disable link auto-negociation (single fixed speed).
> - default: auto-negociate all supported speeds.
> 
> Other changes:
> 
> * Added utility MACROs ETH_SPEED_NUM_XXX with the numeric
>   values of all supported link speeds, in Mbps.
> * Converted link_speed to uint32_t to accomodate 100G speeds
>   (bug).
> * Added autoneg flag in struct rte_eth_link to indicate if
>   link speed was a result of auto-negociation or was fixed
>   by configuration.
> * Added utility function to convert numeric speeds to bitmap
>   fields.

Having it split in several commits may help to understand the changes.
And it must be explained in the release notes in the "API changes".