From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34008)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WQAZi-0000L5-Dx
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 03:06:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WQAZZ-0008EE-Rz
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 03:06:06 -0400
Received: from mail-ee0-x234.google.com ([2a00:1450:4013:c00::234]:38723)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WQAZZ-0008E6-Kg
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 03:05:57 -0400
Received: by mail-ee0-f52.google.com with SMTP id e49so6085527eek.25
	for <qemu-devel@nongnu.org>; Wed, 19 Mar 2014 00:05:56 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <532941D1.6060507@redhat.com>
Date: Wed, 19 Mar 2014 08:05:53 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1395193232-9065-1-git-send-email-prasadjoshi.linux@gmail.com>
In-Reply-To: <1395193232-9065-1-git-send-email-prasadjoshi.linux@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] scsi: check req pointer before
	dereferencing it
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Prasad Joshi <prasadjoshi.linux@gmail.com>, qemu-devel@nongnu.org

Il 19/03/2014 02:40, Prasad Joshi ha scritto:
> Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
> ---
>  hw/scsi/vmw_pvscsi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
> index 7d344b9..e35bff7 100644
> --- a/hw/scsi/vmw_pvscsi.c
> +++ b/hw/scsi/vmw_pvscsi.c
> @@ -479,12 +479,13 @@ static void
>  pvscsi_command_complete(SCSIRequest *req, uint32_t status, size_t resid)
>  {
>      PVSCSIRequest *pvscsi_req = req->hba_private;
> -    PVSCSIState *s = pvscsi_req->dev;
> +    PVSCSIState *s;
>
>      if (!pvscsi_req) {
>          trace_pvscsi_command_complete_not_found(req->tag);
>          return;
>      }
> +    s = pvscsi_req->dev;
>
>      if (resid) {
>          /* Short transfer.  */
>

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

will apply it to scsi-next, thanks.

Paolo