From mboxrd@z Thu Jan 1 00:00:00 1970 From: takuo.koguchi.sw@hitachi.com (=?utf-8?B?5bCP5Y+j55Ci5aSrIC8gS09HVUNISe+8jFRBS1VP?=) Date: Fri, 14 Sep 2018 21:15:31 +0000 Subject: [cip-dev] Altera CIP branch vs. Denali NAND driver In-Reply-To: References: <95cf4467-b48b-6a80-931c-a7f664048c6d@siemens.com> <2426c261-d153-24e3-4ce3-6cbf8f52d7c7@siemens.com> <5f005779-cbd2-430d-73a7-394696ff108a@siemens.com> , Message-ID: <532A3268-0497-4FF5-B107-E4EEEFE133B2@hitachi.com> To: cip-dev@lists.cip-project.org List-Id: cip-dev.lists.cip-project.org Hi Jan, Masaharu Yamada the maintainer of denali driver was reported this on 2018-09-12 by another user and the same fix likely comes to soon! https://www.spinics.net/lists/linux-mtd/msg01718.html Takuo 2018/09/15 1:44?Jan Kiszka >????: On 14.09.18 12:45, ???? / KOGUCHI?TAKUO wrote: Jan, Have you been making progress with this? I have confirmed that; (1) linux-4.13 and linux-4.14 works on my board without any modification to the denali driver. (2) linux-4.15 to linux-4.19-rc3 need a single extra line. I do not know a better fix. If you have an update, I would like to try it on my board. Marek may be able to comment on the details of your change better than I. We are using the queue now with some extensions. I need to dig them out and will try to refresh the queue I published. Thanks, Jan Best regard, Takuo --------------------------------- From: Takuo Koguchi > Date: Fri, 14 Sep 2018 18:38:43 +0900 Subject: [PATCH] MTD NAND Denali fix for Cyclonev Reading back DMA_ENABLE register just after enabling it, this is removed by commit: [586a2c52909df453ed1b6239283744b0851ccf81] mtd: nand: denali: squash denali_enable_dma() helper into caller Without this denali_wait_for_irq timeout for INTR__DMA_CMD_COMP. Signed-off-by: Takuo Koguchi > --- drivers/mtd/nand/raw/denali.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c index 67b2065..4ba997b 100644 --- a/drivers/mtd/nand/raw/denali.c +++ b/drivers/mtd/nand/raw/denali.c @@ -596,6 +596,7 @@ static int denali_dma_xfer(struct denali_nand_info *denali, void *buf, } iowrite32(DMA_ENABLE__FLAG, denali->reg + DMA_ENABLE); + ioread32(denali->reg + DMA_ENABLE); denali_reset_irq(denali); denali->setup_dma(denali, dma_addr, page, write); -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux -------------- next part -------------- An HTML attachment was scrubbed... URL: