All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Bandan Das <bsd@redhat.com>, kvm@vger.kernel.org
Cc: Gleb Natapov <gleb@kernel.org>, Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH 3/3] KVM: nVMX: check for null vmcs12 when L1 does invept
Date: Thu, 20 Mar 2014 13:43:08 +0100	[thread overview]
Message-ID: <532AE25C.5070008@redhat.com> (raw)
In-Reply-To: <1395286089-5406-4-git-send-email-bsd@redhat.com>

Il 20/03/2014 04:28, Bandan Das ha scritto:
> Some L1 hypervisors such as Xen seem to be calling invept after
> vmclear or before vmptrld on L2. In this case, proceed with
> falling through and syncing roots as a case where
> context wide invalidation can't be supported
>
> Signed-off-by: Bandan Das <bsd@redhat.com>
> ---
>  arch/x86/kvm/vmx.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index c707389..b407b3a 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -6435,8 +6435,9 @@ static int handle_invept(struct kvm_vcpu *vcpu)
>
>  	switch (type) {
>  	case VMX_EPT_EXTENT_CONTEXT:
> -		if ((operand.eptp & eptp_mask) !=
> -				(nested_ept_get_cr3(vcpu) & eptp_mask))
> +		if (get_vmcs12(vcpu) &&
> +		    ((operand.eptp & eptp_mask) != (nested_ept_get_cr3(vcpu) &
> +						    eptp_mask)))
>  			break;
>  	case VMX_EPT_EXTENT_GLOBAL:
>  		kvm_mmu_sync_roots(vcpu);
>

Please add a /* fall through */ comment as well.

Paolo

  parent reply	other threads:[~2014-03-20 12:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-20  3:28 [PATCH 0/3] nVMX: Fixes to run Xen as L1 Bandan Das
2014-03-20  3:28 ` [PATCH 1/3] KVM: nVMX: Advertise support for interrupt acknowledgement Bandan Das
2014-03-20  8:30   ` Jan Kiszka
2014-03-20 20:45     ` Bandan Das
2014-03-20  3:28 ` [PATCH 2/3] KVM: nVMX: Ack and write vector info to intr_info if L1 asks us to Bandan Das
2014-03-20  9:13   ` Jan Kiszka
2014-03-20 20:46     ` Bandan Das
2014-03-20  3:28 ` [PATCH 3/3] KVM: nVMX: check for null vmcs12 when L1 does invept Bandan Das
2014-03-20  9:34   ` Jan Kiszka
2014-03-20 20:58     ` Bandan Das
2014-03-22 11:38       ` Jan Kiszka
2014-03-22 16:43         ` Bandan Das
2014-03-23 19:16           ` Jan Kiszka
2014-03-26 20:22             ` Bandan Das
2014-03-27  9:03               ` Jan Kiszka
2014-03-27 22:14                 ` Bandan Das
2014-03-20 12:43   ` Paolo Bonzini [this message]
2014-03-20 20:58     ` Bandan Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532AE25C.5070008@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=bsd@redhat.com \
    --cc=gleb@kernel.org \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.