From: Peter Hurley <peter@hurleysoftware.com>
To: "Bollinger, Seth" <Seth.Bollinger@digi.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-serial <linux-serial@vger.kernel.org>
Subject: Re: Possible software flow problem in serial_core
Date: Thu, 20 Mar 2014 20:34:38 -0400 [thread overview]
Message-ID: <532B891E.80705@hurleysoftware.com> (raw)
In-Reply-To: <CF50E0EB.6E95%seth.bollinger@digi.com>
On 03/20/2014 07:34 PM, Bollinger, Seth wrote:
> Do you have a driver that would be a good example of this? From looking
> at serial_core.c:uart_start(), is seems that start_tx() is only called if
> the serial_core ring buffer is not empty. If we don¹t stop the
> transmitter, we slew too many characters.
Yeah, you're right; thanks for catching this.
(I was busy looking at the ll driver and completely missed the bug in
the serial core).
uart_start() should not be conditioning the call to start_tx() on
the ring buffer being empty; ll drivers should already be able to handle
that because CTS flow control change will start_tx regardless of the ring
buffer count.
Will you send a patch?
Regards,
Peter Hurley
next prev parent reply other threads:[~2014-03-21 0:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 13:44 Possible software flow problem in serial_core Bollinger, Seth
2014-03-20 23:05 ` Peter Hurley
2014-03-20 23:05 ` Peter Hurley
2014-03-20 23:34 ` Bollinger, Seth
2014-03-20 23:34 ` Bollinger, Seth
2014-03-21 0:34 ` Peter Hurley [this message]
2014-03-21 0:48 ` Bollinger, Seth
2014-03-21 1:07 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532B891E.80705@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=Seth.Bollinger@digi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.