From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] xen/arm: domain_vgic_init: Check xzalloc_* return Date: Fri, 21 Mar 2014 12:29:15 +0000 Message-ID: <532C3EAB02000078001268B2@nat28.tlf.novell.com> References: <1395323486-9891-1-git-send-email-julien.grall@linaro.org> <1395404371.19839.14.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WQyZa-0004Qo-W2 for xen-devel@lists.xenproject.org; Fri, 21 Mar 2014 12:29:19 +0000 In-Reply-To: <1395404371.19839.14.camel@kazak.uk.xensource.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Julien Grall Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, tim@xen.org List-Id: xen-devel@lists.xenproject.org >>> On 21.03.14 at 13:19, Ian Campbell wrote: > On Thu, 2014-03-20 at 13:51 +0000, Julien Grall wrote: >> The allocations for shared_irqs and pending_irqs are not checked and use >> later. This may lead to a Xen segfault if the hypervisor run out of memory. >> >> Signed-off-by: Julien Grall > > Acked + applied. > >> --- >> This patch should be backported to Xen 4.4 > > I've added it to my notes, but also CCing Jan since I guess he will be > the one to actually do it. That's something we need to discuss I think: Since I'm not actively using the ARM port, I'm not sure we wouldn't introduce unnecessary risks if I did the backports. Therefore I'd like to put up for discussion whether one of the ARM maintainers wouldn't be in a better position to do this now that we need to do backports there - both in terms of tracking what needs backporting as well as actually applying them. Jan