From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH v5 13/17] xenctx: Add convert of more
 registers to symbols
Date: Fri, 21 Mar 2014 15:11:50 +0000
Message-ID: <532C56B602000078000AF422@nat28.tlf.novell.com>
References: <1395342425-16260-1-git-send-email-dslutz@verizon.com>
	<1395342425-16260-14-git-send-email-dslutz@verizon.com>
	<1395414424.19839.134.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1395414424.19839.134.camel@kazak.uk.xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>, Don Slutz <dslutz@verizon.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, xen-devel@lists.xen.org, Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

>>> On 21.03.14 at 16:07, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> On Thu, 2014-03-20 at 15:07 -0400, Don Slutz wrote:
> 
>> @@ -368,8 +380,11 @@ static void print_ctx_32(vcpu_guest_context_x86_32_t *ctx)
>>      printf(" gs:     %04x\n", regs->gs);
>>  
>>      if (xenctx.disp_all) {
>> -        print_special(ctx->ctrlreg, "cr", 0x1d, 4);
>> -        print_special(ctx->debugreg, "dr", 0xcf, 4);
>> +        uint64_t cr_reg_mask[5] = {0, 0, ~0ULL};
>> +        uint64_t dr_reg_mask[8] = {~0ULL, ~0ULL, ~0ULL, ~0ULL};
> 
> Are you really using 8*64 bits to represent 8 boolean values? Your masks
> are all 0 or ~0.

Actually I had asked for this, since special registers may happen to have
(often at their bottom or top) bits not being part of an address.

Jan