Re: [PATCH v2 1/7] xenstore-read: add support for a retry open limit on xenstored

[David Vrabel <david.vrabel@citrix.com>]

On 19/03/14 20:58, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@suse.com>
> 
> This adds support for a customizable retry limit on trying to open
> the xenstored, each retry is separated by 1 second. This should allow
> us to simplify both our LSB init scripts and eventually our systemd
> service files for starting the xenstored.


This seems odd. Surely the point of systemd is that you only start
services once their dependencies are up?  It doesn't seem right to have
a service poll for another.

> 
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Jan Rękorajski <baggins@pld-linux.org>
> Cc: M A Young <m.a.young@durham.ac.uk>
> Cc: Jacek Konieczny <jajcus@jajcus.net>
> Cc: xen-devel@lists.xenproject.org
> Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
> ---
>  tools/xenstore/xenstore_client.c | 31 +++++++++++++++++++++++++------
>  1 file changed, 25 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/xenstore/xenstore_client.c b/tools/xenstore/xenstore_client.c
> index 0ec103f..87972b7 100644
> --- a/tools/xenstore/xenstore_client.c
> +++ b/tools/xenstore/xenstore_client.c
> @@ -77,7 +77,8 @@ usage(enum mode mode, int incl_mode, const char *progname)
>  	errx(1, "Usage: %s <mode> [-h] [...]", progname);
>      case MODE_read:
>  	mstr = incl_mode ? "read " : "";
> -	errx(1, "Usage: %s %s[-h] [-p] [-s] key [...]", progname, mstr);
> +	errx(1, "Usage: %s %s[-h] [-p] [-s] [ -l <num_open_tries> ] key [...]",
> +	     progname, mstr);

The command line option would be better as a time out value (in seconds).

David

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel