From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <532DBBFF.9010900@xenomai.org> Date: Sat, 22 Mar 2014 17:36:15 +0100 From: Gilles Chanteperdrix MIME-Version: 1.0 References: <53163439.6070608@gmail.com> In-Reply-To: <53163439.6070608@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Xenomai] Sensoray 626 analogy driver List-Id: Discussions about the Xenomai project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wojciech Domski Cc: xenomai@xenomai.org On 03/04/2014 09:14 PM, Wojciech Domski wrote: > Dear all, > > Could I ask you to offer some insight into the Analogy driver for > Sensoray 626 which has been placed here as a patch? Hi, I have just read your patch, it looks fine, except for a few detailss. First, the coding style. You use mixed-case identifiers, whereas the tradition is to use lower case with underscores, and you do not seem to indent with tabs, which is also the rule for kernel code. Your code also contains some code in commentaries, which makes it uselessly hard to read. Second, I see a lot of busy wait loops, for instance for things such as I2C transfers, but I2C transfers are usually slow, so busy waiting for the end of an I2C transfer in a critical section (as the comments say), will create large masking sections for the rest of the system, which is unacceptable for Xenomai, as we try hard to guarantee low latencies. Regards. -- Gilles.