From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42588) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRTiD-0001Em-4V for qemu-devel@nongnu.org; Sat, 22 Mar 2014 17:44:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WRTi7-0000Mr-57 for qemu-devel@nongnu.org; Sat, 22 Mar 2014 17:44:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRTi6-0000Mm-TU for qemu-devel@nongnu.org; Sat, 22 Mar 2014 17:44:11 -0400 Message-ID: <532E0427.8060909@redhat.com> Date: Sat, 22 Mar 2014 17:44:07 -0400 From: Cole Robinson MIME-Version: 1.0 References: <150e59818a7f8a0c5928f9f08d31c2248029ab57.1394579440.git.crobinso@redhat.com> <532DED51.6040706@suse.de> In-Reply-To: <532DED51.6040706@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/6] monitor: Remove unused monitor_print_filename List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , Luiz Capitulino On 03/22/2014 04:06 PM, Andreas F=E4rber wrote: > Am 12.03.2014 00:15, schrieb Cole Robinson: >> Cc: Luiz Capitulino >> Cc: Markus Armbruster >> Signed-off-by: Cole Robinson >=20 > Given that it even had its own stub file, the commit message should > please explain why it is no longer needed and thus okay to drop. >=20 > Regards, > Andreas >=20 The last usage of it was dropped with: commit fbe2e26c15af35e4d157874dc80f6a19eebaa83b Author: Kevin Wolf Date: Wed Jun 19 16:10:55 2013 +0200 hmp: Make "info block" output more readable Previously it was used to escape file=3D and backing_file=3D in 'info blo= ck' output. I sent this patch because I noticed it was unused, maybe someone else can comment on whether it's still useful? - Cole