All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] bluez5_utils: new package
@ 2013-11-04 12:59 Marcin Bis
  2013-11-04 16:06 ` Thomas De Schampheleire
  0 siblings, 1 reply; 20+ messages in thread
From: Marcin Bis @ 2013-11-04 12:59 UTC (permalink / raw)
  To: buildroot

This patch adds support for BlueZ 5.x.

API is not backwards compatible with BlueZ 4. It uses kernel interface
introduces in 3.4 (3.5 for Low Energy).

BlueZ utils will use systemd and/or udev if enabled.

Signed-off-by: Marcin Bis <marcin@bis.org.pl>
---
 package/Config.in                    |    1 +
 package/bluez5_utils/Config.in       |   36 +++++++++++++++++++++++++++++
 package/bluez5_utils/bluez5_utils.mk |   42 ++++++++++++++++++++++++++++++++++
 3 files changed, 79 insertions(+), 0 deletions(-)
 create mode 100644 package/bluez5_utils/Config.in
 create mode 100644 package/bluez5_utils/bluez5_utils.mk

diff --git a/package/Config.in b/package/Config.in
index 4c4da51..0e0fca9 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -768,6 +768,7 @@ source "package/axel/Config.in"
 source "package/bcusdk/Config.in"
 source "package/bind/Config.in"
 source "package/bluez_utils/Config.in"
+source "package/bluez5_utils/Config.in"
 source "package/bmon/Config.in"
 source "package/boa/Config.in"
 source "package/bridge-utils/Config.in"
diff --git a/package/bluez5_utils/Config.in b/package/bluez5_utils/Config.in
new file mode 100644
index 0000000..d2b4910
--- /dev/null
+++ b/package/bluez5_utils/Config.in
@@ -0,0 +1,36 @@
+config BR2_PACKAGE_BLUEZ5_UTILS
+	bool "bluez-utils 5.x"
+	depends on !BR2_avr32
+	depends on BR2_USE_WCHAR # libglib2
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, alsa-lib, libglib2
+	depends on BR2_USE_MMU # dbus
+	depends on !BR2_PACKAGE_BLUEZ_UTILS # conflicts with 4.x version
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBICAL
+	select BR2_PACKAGE_READLINE
+	help
+	  bluez utils version 5.x
+
+	  With this release BlueZ only supports the new Bluetooth Management kernel
+	  interface (introduced in Linux 3.4).
+	  For Low Energy support at least kernel version 3.5 is needed.
+
+	  The API is not backwards compatible with BlueZ 4.
+
+	  Bluez utils will use systemd and/or udev if enabled.
+
+	  http://www.bluez.org
+	  http://www.kernel.org/pub/linux/bluetooth
+
+if BR2_PACKAGE_BLUEZ5_UTILS
+
+config BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL
+	bool "build experimental plugins"
+	help
+	  Build BlueZ 5.x experimental plugins.
+
+endif
+
+comment "bluez5-utils needs a toolchain w/ wchar, threads"
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
new file mode 100644
index 0000000..a557868
--- /dev/null
+++ b/package/bluez5_utils/bluez5_utils.mk
@@ -0,0 +1,42 @@
+################################################################################
+#
+# bluez5_utils
+#
+################################################################################
+
+BLUEZ5_UTILS_VERSION = 5.10
+BLUEZ5_UTILS_SOURCE = bluez-$(BLUEZ5_UTILS_VERSION).tar.xz
+BLUEZ5_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
+BLUEZ5_UTILS_INSTALL_STAGING = YES
+BLUEZ5_UTILS_DEPENDENCIES = dbus libglib2 libical readline
+BLUEZ5_UTILS_CONF_OPT = --enable-test --enable-tools --enable-library
+BLUEZ5_UTILS_AUTORECONF = YES
+BLUEZ5_UTILS_LICENSE = GPLv2+ LGPLv2.1+
+BLUEZ5_UTILS_LICENSE_FILES = COPYING COPYING.LIB
+
+# experimental plugins
+ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL),y)
+BLUEZ5_UTILS_CONF_OPT +=	\
+	--enable-experimental
+else
+BLUEZ5_UTILS_CONF_OPT +=	\
+	--disable-experimental
+endif
+
+# use udev if available
+ifeq ($(BR2_PACKAGE_UDEV),y)
+        BLUEZ5_UTILS_CONF_OPT += --enable-udev
+        BLUEZ5_UTILS_DEPENDENCIES += udev
+else
+        BLUEZ5_UTILS_CONF_OPT += --disable-udev
+endif
+
+# integrate with systemd if available
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+        BLUEZ5_UTILS_CONF_OPT += --enable-systemd
+        BLUEZ5_UTILS_DEPENDENCIES += systemd
+else
+        BLUEZ5_UTILS_CONF_OPT += --disable-systemd
+endif
+
+$(eval $(autotools-package))
-- 
1.7.2.5

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH] bluez5_utils: new package
  2013-11-04 12:59 [Buildroot] [PATCH] bluez5_utils: new package Marcin Bis
@ 2013-11-04 16:06 ` Thomas De Schampheleire
  2013-11-04 21:34   ` [Buildroot] [PATCH v2] " Marcin Bis
  0 siblings, 1 reply; 20+ messages in thread
From: Thomas De Schampheleire @ 2013-11-04 16:06 UTC (permalink / raw)
  To: buildroot

Hi Marcin,

Thanks for your contribution!
Some comments below...

On Mon, Nov 4, 2013 at 1:59 PM, Marcin Bis <marcin@bis.org.pl> wrote:
> This patch adds support for BlueZ 5.x.
>
> API is not backwards compatible with BlueZ 4. It uses kernel interface
> introduces in 3.4 (3.5 for Low Energy).
>
> BlueZ utils will use systemd and/or udev if enabled.
>
> Signed-off-by: Marcin Bis <marcin@bis.org.pl>
> ---
>  package/Config.in                    |    1 +
>  package/bluez5_utils/Config.in       |   36 +++++++++++++++++++++++++++++
>  package/bluez5_utils/bluez5_utils.mk |   42 ++++++++++++++++++++++++++++++++++
>  3 files changed, 79 insertions(+), 0 deletions(-)
>  create mode 100644 package/bluez5_utils/Config.in
>  create mode 100644 package/bluez5_utils/bluez5_utils.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 4c4da51..0e0fca9 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -768,6 +768,7 @@ source "package/axel/Config.in"
>  source "package/bcusdk/Config.in"
>  source "package/bind/Config.in"
>  source "package/bluez_utils/Config.in"
> +source "package/bluez5_utils/Config.in"
>  source "package/bmon/Config.in"
>  source "package/boa/Config.in"
>  source "package/bridge-utils/Config.in"
> diff --git a/package/bluez5_utils/Config.in b/package/bluez5_utils/Config.in
> new file mode 100644
> index 0000000..d2b4910
> --- /dev/null
> +++ b/package/bluez5_utils/Config.in
> @@ -0,0 +1,36 @@
> +config BR2_PACKAGE_BLUEZ5_UTILS
> +       bool "bluez-utils 5.x"
> +       depends on !BR2_avr32
> +       depends on BR2_USE_WCHAR # libglib2
> +       depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, alsa-lib, libglib2
> +       depends on BR2_USE_MMU # dbus
> +       depends on !BR2_PACKAGE_BLUEZ_UTILS # conflicts with 4.x version
> +       select BR2_PACKAGE_DBUS
> +       select BR2_PACKAGE_LIBGLIB2
> +       select BR2_PACKAGE_LIBICAL
> +       select BR2_PACKAGE_READLINE
> +       help
> +         bluez utils version 5.x
> +
> +         With this release BlueZ only supports the new Bluetooth Management kernel
> +         interface (introduced in Linux 3.4).
> +         For Low Energy support at least kernel version 3.5 is needed.
> +
> +         The API is not backwards compatible with BlueZ 4.
> +
> +         Bluez utils will use systemd and/or udev if enabled.
> +
> +         http://www.bluez.org
> +         http://www.kernel.org/pub/linux/bluetooth
> +
> +if BR2_PACKAGE_BLUEZ5_UTILS
> +
> +config BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL
> +       bool "build experimental plugins"
> +       help
> +         Build BlueZ 5.x experimental plugins.
> +
> +endif
> +
> +comment "bluez5-utils needs a toolchain w/ wchar, threads"
> +       depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS

This comment should repeat the other dependencies of bluez5-utils, so
that the comment is only visible when relevant, so it should become:

comment "bluez5-utils needs a toolchain w/ wchar, threads"
       depends on !BR2_avr32 && BR2_USE_MMU && !BR2_PACKAGE_BLUEZ_UTILS
       depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS

This is not properly documented yet, but I have submitted a patch
today to fix all packages and will submit another patch to clarify the
documentation.

Also, I prefer to keep the comment together with the actual config
option, instead of having the 'experimental' part in between.


> diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
> new file mode 100644
> index 0000000..a557868
> --- /dev/null
> +++ b/package/bluez5_utils/bluez5_utils.mk
> @@ -0,0 +1,42 @@
> +################################################################################
> +#
> +# bluez5_utils
> +#
> +################################################################################
> +
> +BLUEZ5_UTILS_VERSION = 5.10
> +BLUEZ5_UTILS_SOURCE = bluez-$(BLUEZ5_UTILS_VERSION).tar.xz
> +BLUEZ5_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
> +BLUEZ5_UTILS_INSTALL_STAGING = YES
> +BLUEZ5_UTILS_DEPENDENCIES = dbus libglib2 libical readline
> +BLUEZ5_UTILS_CONF_OPT = --enable-test --enable-tools --enable-library
> +BLUEZ5_UTILS_AUTORECONF = YES
> +BLUEZ5_UTILS_LICENSE = GPLv2+ LGPLv2.1+
> +BLUEZ5_UTILS_LICENSE_FILES = COPYING COPYING.LIB
> +
> +# experimental plugins
> +ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL),y)
> +BLUEZ5_UTILS_CONF_OPT +=       \
> +       --enable-experimental
> +else
> +BLUEZ5_UTILS_CONF_OPT +=       \
> +       --disable-experimental

In the above cases I don't think it's necessary to wrap the lines (yet).

> +endif
> +
> +# use udev if available
> +ifeq ($(BR2_PACKAGE_UDEV),y)
> +        BLUEZ5_UTILS_CONF_OPT += --enable-udev
> +        BLUEZ5_UTILS_DEPENDENCIES += udev
> +else
> +        BLUEZ5_UTILS_CONF_OPT += --disable-udev
> +endif
> +
> +# integrate with systemd if available
> +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> +        BLUEZ5_UTILS_CONF_OPT += --enable-systemd
> +        BLUEZ5_UTILS_DEPENDENCIES += systemd
> +else
> +        BLUEZ5_UTILS_CONF_OPT += --disable-systemd
> +endif
> +
> +$(eval $(autotools-package))

Best regards,
Thomas

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH v2] bluez5_utils: new package
  2013-11-04 16:06 ` Thomas De Schampheleire
@ 2013-11-04 21:34   ` Marcin Bis
  2014-03-04 21:38     ` Yann E. MORIN
  0 siblings, 1 reply; 20+ messages in thread
From: Marcin Bis @ 2013-11-04 21:34 UTC (permalink / raw)
  To: buildroot

This patch adds support for BlueZ 5.x.

API is not backwards compatible with BlueZ 4. It uses kernel interface
introduced in 3.4 (3.5 for Low Energy).

BlueZ utils will use systemd and/or udev if enabled.

Signed-off-by: Marcin Bis <marcin@bis.org.pl>
---
 package/Config.in                    |    1 +
 package/bluez5_utils/Config.in       |   37 +++++++++++++++++++++++++++++++
 package/bluez5_utils/bluez5_utils.mk |   40 ++++++++++++++++++++++++++++++++++
 3 files changed, 78 insertions(+), 0 deletions(-)
 create mode 100644 package/bluez5_utils/Config.in
 create mode 100644 package/bluez5_utils/bluez5_utils.mk

diff --git a/package/Config.in b/package/Config.in
index 4c4da51..0e0fca9 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -768,6 +768,7 @@ source "package/axel/Config.in"
 source "package/bcusdk/Config.in"
 source "package/bind/Config.in"
 source "package/bluez_utils/Config.in"
+source "package/bluez5_utils/Config.in"
 source "package/bmon/Config.in"
 source "package/boa/Config.in"
 source "package/bridge-utils/Config.in"
diff --git a/package/bluez5_utils/Config.in b/package/bluez5_utils/Config.in
new file mode 100644
index 0000000..9da4f80
--- /dev/null
+++ b/package/bluez5_utils/Config.in
@@ -0,0 +1,37 @@
+config BR2_PACKAGE_BLUEZ5_UTILS
+	bool "bluez-utils 5.x"
+	depends on !BR2_avr32
+	depends on BR2_USE_WCHAR # libglib2
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
+	depends on BR2_USE_MMU # dbus
+	depends on !BR2_PACKAGE_BLUEZ_UTILS # conflicts with 4.x version
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBICAL
+	select BR2_PACKAGE_READLINE
+	help
+	  bluez utils version 5.x
+
+	  With this release BlueZ only supports the new Bluetooth Management
+	  kernel interface (introduced in Linux 3.4).
+	  For Low Energy support at least kernel version 3.5 is needed.
+
+	  The API is not backwards compatible with BlueZ 4.
+
+	  Bluez utils will use systemd and/or udev if enabled.
+
+	  http://www.bluez.org
+	  http://www.kernel.org/pub/linux/bluetooth
+
+comment "bluez5-utils needs a toolchain w/ wchar, threads"
+	depends on !BR2_avr32 && BR2_USE_MMU && !BR2_PACKAGE_BLUEZ_UTILS
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+
+if BR2_PACKAGE_BLUEZ5_UTILS
+
+config BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL
+	bool "build experimental plugins"
+	help
+	  Build BlueZ 5.x experimental plugins.
+
+endif
diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
new file mode 100644
index 0000000..718699d
--- /dev/null
+++ b/package/bluez5_utils/bluez5_utils.mk
@@ -0,0 +1,40 @@
+################################################################################
+#
+# bluez5_utils
+#
+################################################################################
+
+BLUEZ5_UTILS_VERSION = 5.10
+BLUEZ5_UTILS_SOURCE = bluez-$(BLUEZ5_UTILS_VERSION).tar.xz
+BLUEZ5_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
+BLUEZ5_UTILS_INSTALL_STAGING = YES
+BLUEZ5_UTILS_DEPENDENCIES = dbus libglib2 libical readline
+BLUEZ5_UTILS_CONF_OPT = --enable-test --enable-tools --enable-library
+BLUEZ5_UTILS_AUTORECONF = YES
+BLUEZ5_UTILS_LICENSE = GPLv2+ LGPLv2.1+
+BLUEZ5_UTILS_LICENSE_FILES = COPYING COPYING.LIB
+
+# experimental plugins
+ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL),y)
+BLUEZ5_UTILS_CONF_OPT += --enable-experimental
+else
+BLUEZ5_UTILS_CONF_OPT += --disable-experimental
+endif
+
+# use udev if available
+ifeq ($(BR2_PACKAGE_UDEV),y)
+        BLUEZ5_UTILS_CONF_OPT += --enable-udev
+        BLUEZ5_UTILS_DEPENDENCIES += udev
+else
+        BLUEZ5_UTILS_CONF_OPT += --disable-udev
+endif
+
+# integrate with systemd if available
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+        BLUEZ5_UTILS_CONF_OPT += --enable-systemd
+        BLUEZ5_UTILS_DEPENDENCIES += systemd
+else
+        BLUEZ5_UTILS_CONF_OPT += --disable-systemd
+endif
+
+$(eval $(autotools-package))
-- 
1.7.2.5

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH v2] bluez5_utils: new package
  2013-11-04 21:34   ` [Buildroot] [PATCH v2] " Marcin Bis
@ 2014-03-04 21:38     ` Yann E. MORIN
  2014-03-20 13:48       ` [Buildroot] [PATCH v3] " Marcin Bis
  0 siblings, 1 reply; 20+ messages in thread
From: Yann E. MORIN @ 2014-03-04 21:38 UTC (permalink / raw)
  To: buildroot

Marcin, All,

Thanks for your patch. Here are a few comments below...

On 2013-11-04 22:34 +0100, Marcin Bis spake thusly:
> This patch adds support for BlueZ 5.x.
> 
> API is not backwards compatible with BlueZ 4. It uses kernel interface
> introduced in 3.4 (3.5 for Low Energy).

So it has a dependency on the Linux kernel headers installed with the
toolchain, right? We now have a way to express this kind of
dependencies:

    depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_4

See the current manual:
    http://nightly.buildroot.org/#dependencies-target-toolchain-options

[--SNIP--]
> diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
> new file mode 100644
> index 0000000..718699d
> --- /dev/null
> +++ b/package/bluez5_utils/bluez5_utils.mk
> @@ -0,0 +1,40 @@
> +################################################################################
> +#
> +# bluez5_utils
> +#
> +################################################################################
> +
> +BLUEZ5_UTILS_VERSION = 5.10

There's 5.15, now...

> +BLUEZ5_UTILS_SOURCE = bluez-$(BLUEZ5_UTILS_VERSION).tar.xz
> +BLUEZ5_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
> +BLUEZ5_UTILS_INSTALL_STAGING = YES
> +BLUEZ5_UTILS_DEPENDENCIES = dbus libglib2 libical readline
> +BLUEZ5_UTILS_CONF_OPT = --enable-test --enable-tools --enable-library

Maybe make tests optional?

> +BLUEZ5_UTILS_AUTORECONF = YES

Why is autoreconf needed? The tarballs do have ./configure.

configure.ac uses PKG_PROG_PKG_CONFIG, so you'd need:
    BLUEZ5_UTILS_DEPENDENCIES += host-pkgconf

Also, configure.ac uses AC_DISABLE_STATIC, so it looks like they do not
intend to support static linking. You'll need in Config.in:
    depends on !BR2_PREFER_STATIC_LIB

> +BLUEZ5_UTILS_LICENSE = GPLv2+ LGPLv2.1+
> +BLUEZ5_UTILS_LICENSE_FILES = COPYING COPYING.LIB
> +
> +# experimental plugins
> +ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL),y)
> +BLUEZ5_UTILS_CONF_OPT += --enable-experimental
> +else
> +BLUEZ5_UTILS_CONF_OPT += --disable-experimental
> +endif
> +
> +# use udev if available
> +ifeq ($(BR2_PACKAGE_UDEV),y)
> +        BLUEZ5_UTILS_CONF_OPT += --enable-udev
> +        BLUEZ5_UTILS_DEPENDENCIES += udev
> +else
> +        BLUEZ5_UTILS_CONF_OPT += --disable-udev
> +endif
> +
> +# integrate with systemd if available
> +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> +        BLUEZ5_UTILS_CONF_OPT += --enable-systemd
> +        BLUEZ5_UTILS_DEPENDENCIES += systemd
> +else
> +        BLUEZ5_UTILS_CONF_OPT += --disable-systemd
> +endif

Bluez4 has more config knobs: are they no longer applicable to Bluez5?
  - Audio
  - USB support
  - GATT support

Since you mention the subject in the commit log: is there a way to
enable/disable support for BTLE?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH v3] bluez5_utils: new package.
  2014-03-04 21:38     ` Yann E. MORIN
@ 2014-03-20 13:48       ` Marcin Bis
  2014-03-20 18:21         ` Thomas Petazzoni
  2014-03-20 19:28         ` Jerzy Grzegorek
  0 siblings, 2 replies; 20+ messages in thread
From: Marcin Bis @ 2014-03-20 13:48 UTC (permalink / raw)
  To: buildroot


Hi Yann

>> +BLUEZ5_UTILS_VERSION = 5.10
>
>There's 5.15, now...
I have bumped it to 5.16 - newest version.

>> +BLUEZ5_UTILS_SOURCE = bluez-$(BLUEZ5_UTILS_VERSION).tar.xz
>> +BLUEZ5_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
>> +BLUEZ5_UTILS_INSTALL_STAGING = YES
>> +BLUEZ5_UTILS_DEPENDENCIES = dbus libglib2 libical readline
>> +BLUEZ5_UTILS_CONF_OPT = --enable-test --enable-tools --enable-library
>
>Maybe make tests optional?
Done

>> +BLUEZ5_UTILS_AUTORECONF = YES
>
>Why is autoreconf needed? The tarballs do have ./configure.
It seems not to be needed anymore. Previously, I copied it from
Bluez 4.x

>Bluez4 has more config knobs: are they no longer applicable to Bluez5?
Yes, they are no longer there. It seems, that Bluez code in 5.x
was seriously cleaned.
>  - Audio
>  - USB support
No longer here, as for USB - it relies on kernel's btusb driver.
>  - GATT support
gatttool is always build but not installed (there are no configuration knobs
for it).
I have added a post-install hook to copy gatttool manually. 

>Since you mention the subject in the commit log: is there a way to
>enable/disable support for BTLE?
I have not seen any 'lescan' and 'lecc' in hciconfig are always enabled.

The patch follows:

bluez5_utils: new package.

API is not backwards compatible with BlueZ 4.

BlueZ utils will use systemd and/or udev if enabled.
Contains a hook for installing GATT support tool, wchich is always
build but not installed by default.
---
 package/Config.in                    |    1 +
 package/bluez5_utils/Config.in       |   51 +++++++++++++++++++++++++++++++
 package/bluez5_utils/bluez5_utils.mk |   55 ++++++++++++++++++++++++++++++++++
 3 files changed, 107 insertions(+)
 create mode 100644 package/bluez5_utils/Config.in
 create mode 100644 package/bluez5_utils/bluez5_utils.mk

diff --git a/package/Config.in b/package/Config.in
index 688ed4d..653ab6c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -864,6 +864,7 @@ source "package/axel/Config.in"
 source "package/bcusdk/Config.in"
 source "package/bind/Config.in"
 source "package/bluez_utils/Config.in"
+source "package/bluez5_utils/Config.in"
 source "package/bmon/Config.in"
 source "package/boa/Config.in"
 source "package/bridge-utils/Config.in"
diff --git a/package/bluez5_utils/Config.in b/package/bluez5_utils/Config.in
new file mode 100644
index 0000000..c721fff
--- /dev/null
+++ b/package/bluez5_utils/Config.in
@@ -0,0 +1,51 @@
+config BR2_PACKAGE_BLUEZ5_UTILS
+	bool "bluez-utils 5.x"
+	depends on !BR2_avr32
+	depends on BR2_USE_WCHAR # libglib2
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
+	depends on BR2_USE_MMU # dbus
+	depends on !BR2_PACKAGE_BLUEZ_UTILS # conflicts with 4.x version
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBICAL
+	select BR2_PACKAGE_READLINE
+	help
+	  bluez utils version 5.x
+
+	  With this release BlueZ only supports the new Bluetooth Management
+	  kernel interface (introduced in Linux 3.4).
+	  For Low Energy support at least kernel version 3.5 is needed.
+
+	  The API is not backwards compatible with BlueZ 4.
+
+	  Bluez utils will use systemd and/or udev if enabled.
+
+	  http://www.bluez.org
+	  http://www.kernel.org/pub/linux/bluetooth
+
+if BR2_PACKAGE_BLUEZ5_UTILS
+
+config BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL
+	bool "build experimental plugins"
+	help
+	  Build BlueZ 5.x experimental plugins (SAP, NFC, ...).
+
+config BR2_PACKAGE_BLUEZ5_UTILS_TEST
+	bool "enable test"
+	help
+	  Enable test.
+
+config BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL
+	bool "install GATT tool"
+	help
+	  Generic Attribute Profile (GATT) support. This provides profile
+	  discovery and description services for Bluetooth Low Energy.
+	  This will install the gatttool utility.
+
+	  It is always build with BlueZ 5.x, but upstream choose not to install
+	  it by default.
+
+endif
+
+comment "bluez5-utils needs a toolchain w/ wchar, threads"
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
new file mode 100644
index 0000000..d0d69df
--- /dev/null
+++ b/package/bluez5_utils/bluez5_utils.mk
@@ -0,0 +1,55 @@
+################################################################################
+#
+# bluez5_utils
+#
+################################################################################
+
+BLUEZ5_UTILS_VERSION = 5.16
+BLUEZ5_UTILS_SOURCE = bluez-$(BLUEZ5_UTILS_VERSION).tar.xz
+BLUEZ5_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
+BLUEZ5_UTILS_INSTALL_STAGING = YES
+BLUEZ5_UTILS_DEPENDENCIES = dbus libglib2 libical readline
+BLUEZ5_UTILS_CONF_OPT = --enable-tools --enable-library
+BLUEZ5_UTILS_LICENSE = GPLv2+ LGPLv2.1+
+BLUEZ5_UTILS_LICENSE_FILES = COPYING COPYING.LIB
+
+# experimental plugins
+ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL),y)
+	BLUEZ5_UTILS_CONF_OPT += --enable-experimental
+else
+	BLUEZ5_UTILS_CONF_OPT += --disable-experimental
+endif
+
+# install gatttool (For some reason upstream choose not to do it by default)
+define BLUEZ5_UTILS_INSTALL_GATTTOOL
+	$(INSTALL) -D -m 0755 $(@D)/attrib/gatttool $(TARGET_DIR)/usr/bin
+endef
+
+ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL),y)
+	BLUEZ5_UTILS_POST_INSTALL_TARGET_HOOKS += BLUEZ5_UTILS_INSTALL_GATTTOOL
+endif
+
+# enable test
+ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_TEST),y)
+	BLUEZ5_UTILS_CONF_OPT += --enable-test
+else
+	BLUEZ5_UTILS_CONF_OPT += --disable-test
+endif
+
+# use udev if available
+ifeq ($(BR2_PACKAGE_UDEV),y)
+        BLUEZ5_UTILS_CONF_OPT += --enable-udev
+        BLUEZ5_UTILS_DEPENDENCIES += udev
+else
+        BLUEZ5_UTILS_CONF_OPT += --disable-udev
+endif
+
+# integrate with systemd if available
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+        BLUEZ5_UTILS_CONF_OPT += --enable-systemd
+        BLUEZ5_UTILS_DEPENDENCIES += systemd
+else
+        BLUEZ5_UTILS_CONF_OPT += --disable-systemd
+endif
+
+$(eval $(autotools-package))
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH v3] bluez5_utils: new package.
  2014-03-20 13:48       ` [Buildroot] [PATCH v3] " Marcin Bis
@ 2014-03-20 18:21         ` Thomas Petazzoni
  2014-03-20 19:28         ` Jerzy Grzegorek
  1 sibling, 0 replies; 20+ messages in thread
From: Thomas Petazzoni @ 2014-03-20 18:21 UTC (permalink / raw)
  To: buildroot

Dear Marcin Bis,

On Thu, 20 Mar 2014 14:48:18 +0100, Marcin Bis wrote:

> The patch follows:

Thanks a lot, but the patch should be in a separate e-mail. As you sent
it, all your discussion answering Yann's comment would end up in the
patch commit log.

> bluez5_utils: new package.
> 
> API is not backwards compatible with BlueZ 4.
> 
> BlueZ utils will use systemd and/or udev if enabled.
> Contains a hook for installing GATT support tool, wchich is always
> build but not installed by default.

Also your Signed-off-by line is missing.

See
http://buildroot.org/downloads/manual/manual.html#_contributing_to_buildroot
for more details about formatting patches.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH v3] bluez5_utils: new package.
  2014-03-20 13:48       ` [Buildroot] [PATCH v3] " Marcin Bis
  2014-03-20 18:21         ` Thomas Petazzoni
@ 2014-03-20 19:28         ` Jerzy Grzegorek
  2014-03-21  9:48           ` Marcin Bis
  2014-03-21  9:53           ` [Buildroot] [PATCH v4] " Marcin Bis
  1 sibling, 2 replies; 20+ messages in thread
From: Jerzy Grzegorek @ 2014-03-20 19:28 UTC (permalink / raw)
  To: buildroot


Hi Marcin,

[...]

> I have not seen any 'lescan' and 'lecc' in hciconfig are always enabled.
>
> The patch follows:
>
> bluez5_utils: new package.
>
> API is not backwards compatible with BlueZ 4.
>
> BlueZ utils will use systemd and/or udev if enabled.
> Contains a hook for installing GATT support tool, wchich is always
> build but not installed by default.
> ---
>   package/Config.in                    |    1 +
>   package/bluez5_utils/Config.in       |   51 +++++++++++++++++++++++++++++++
>   package/bluez5_utils/bluez5_utils.mk |   55 ++++++++++++++++++++++++++++++++++
>   3 files changed, 107 insertions(+)
>   create mode 100644 package/bluez5_utils/Config.in
>   create mode 100644 package/bluez5_utils/bluez5_utils.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 688ed4d..653ab6c 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -864,6 +864,7 @@ source "package/axel/Config.in"
>   source "package/bcusdk/Config.in"
>   source "package/bind/Config.in"
>   source "package/bluez_utils/Config.in"
> +source "package/bluez5_utils/Config.in"
>   source "package/bmon/Config.in"
>   source "package/boa/Config.in"
>   source "package/bridge-utils/Config.in"
> diff --git a/package/bluez5_utils/Config.in b/package/bluez5_utils/Config.in
> new file mode 100644
> index 0000000..c721fff
> --- /dev/null
> +++ b/package/bluez5_utils/Config.in
> @@ -0,0 +1,51 @@
> +config BR2_PACKAGE_BLUEZ5_UTILS
> +	bool "bluez-utils 5.x"
> +	depends on !BR2_avr32
> +	depends on BR2_USE_WCHAR # libglib2
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
> +	depends on BR2_USE_MMU # dbus
> +	depends on !BR2_PACKAGE_BLUEZ_UTILS # conflicts with 4.x version
> +	select BR2_PACKAGE_DBUS
> +	select BR2_PACKAGE_LIBGLIB2
> +	select BR2_PACKAGE_LIBICAL
> +	select BR2_PACKAGE_READLINE
> +	help
> +	  bluez utils version 5.x
> +
> +	  With this release BlueZ only supports the new Bluetooth Management
> +	  kernel interface (introduced in Linux 3.4).
> +	  For Low Energy support at least kernel version 3.5 is needed.
> +
> +	  The API is not backwards compatible with BlueZ 4.
> +
> +	  Bluez utils will use systemd and/or udev if enabled.
> +
> +	  http://www.bluez.org
> +	  http://www.kernel.org/pub/linux/bluetooth
> +
> +if BR2_PACKAGE_BLUEZ5_UTILS
> +
> +config BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL
> +	bool "build experimental plugins"
> +	help
> +	  Build BlueZ 5.x experimental plugins (SAP, NFC, ...).
> +
> +config BR2_PACKAGE_BLUEZ5_UTILS_TEST
> +	bool "enable test"
> +	help
> +	  Enable test.
> +
> +config BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL
> +	bool "install GATT tool"
> +	help
> +	  Generic Attribute Profile (GATT) support. This provides profile
> +	  discovery and description services for Bluetooth Low Energy.
> +	  This will install the gatttool utility.
> +
> +	  It is always build with BlueZ 5.x, but upstream choose not to install
> +	  it by default.
> +
> +endif
> +
> +comment "bluez5-utils needs a toolchain w/ wchar, threads"
> +	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
> new file mode 100644
> index 0000000..d0d69df
> --- /dev/null
> +++ b/package/bluez5_utils/bluez5_utils.mk
> @@ -0,0 +1,55 @@
> +################################################################################
> +#
> +# bluez5_utils
> +#
> +################################################################################
> +
> +BLUEZ5_UTILS_VERSION = 5.16
> +BLUEZ5_UTILS_SOURCE = bluez-$(BLUEZ5_UTILS_VERSION).tar.xz
> +BLUEZ5_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
> +BLUEZ5_UTILS_INSTALL_STAGING = YES
> +BLUEZ5_UTILS_DEPENDENCIES = dbus libglib2 libical readline
> +BLUEZ5_UTILS_CONF_OPT = --enable-tools --enable-library
> +BLUEZ5_UTILS_LICENSE = GPLv2+ LGPLv2.1+
> +BLUEZ5_UTILS_LICENSE_FILES = COPYING COPYING.LIB
> +
> +# experimental plugins
> +ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL),y)
> +	BLUEZ5_UTILS_CONF_OPT += --enable-experimental
> +else
> +	BLUEZ5_UTILS_CONF_OPT += --disable-experimental
> +endif
> +
> +# install gatttool (For some reason upstream choose not to do it by default)
> +define BLUEZ5_UTILS_INSTALL_GATTTOOL
> +	$(INSTALL) -D -m 0755 $(@D)/attrib/gatttool $(TARGET_DIR)/usr/bin
> +endef
> +
> +ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL),y)
> +	BLUEZ5_UTILS_POST_INSTALL_TARGET_HOOKS += BLUEZ5_UTILS_INSTALL_GATTTOOL
> +endif

Documentation says:
"...keep hook definition and assignment together in one if block",
so it should rather look like:

ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL),y)
define BLUEZ5_UTILS_INSTALL_GATTTOOL
	$(INSTALL) -D -m 0755 $(@D)/attrib/gatttool $(TARGET_DIR)/usr/bin
endef

BLUEZ5_UTILS_POST_INSTALL_TARGET_HOOKS += BLUEZ5_UTILS_INSTALL_GATTTOOL
endif


See:
http://buildroot.uclibc.org/downloads/manual/manual.html#writing-rules-mk

Regards,
Jerzy

> +
> +# enable test
> +ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_TEST),y)
> +	BLUEZ5_UTILS_CONF_OPT += --enable-test
> +else
> +	BLUEZ5_UTILS_CONF_OPT += --disable-test
> +endif
> +
> +# use udev if available
> +ifeq ($(BR2_PACKAGE_UDEV),y)
> +        BLUEZ5_UTILS_CONF_OPT += --enable-udev
> +        BLUEZ5_UTILS_DEPENDENCIES += udev
> +else
> +        BLUEZ5_UTILS_CONF_OPT += --disable-udev
> +endif
> +
> +# integrate with systemd if available
> +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> +        BLUEZ5_UTILS_CONF_OPT += --enable-systemd
> +        BLUEZ5_UTILS_DEPENDENCIES += systemd
> +else
> +        BLUEZ5_UTILS_CONF_OPT += --disable-systemd
> +endif
> +
> +$(eval $(autotools-package))

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH v3] bluez5_utils: new package.
  2014-03-20 19:28         ` Jerzy Grzegorek
@ 2014-03-21  9:48           ` Marcin Bis
  2014-03-21  9:53           ` [Buildroot] [PATCH v4] " Marcin Bis
  1 sibling, 0 replies; 20+ messages in thread
From: Marcin Bis @ 2014-03-21  9:48 UTC (permalink / raw)
  To: buildroot

Hi

Thank you for comments.
I am resending patch in a moment with following fixes:

> Documentation says:
> "...keep hook definition and assignment together in one if block",
> so it should rather look like:
>
> ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL),y)
> define BLUEZ5_UTILS_INSTALL_GATTTOOL
>
>         $(INSTALL) -D -m 0755 $(@D)/attrib/gatttool $(TARGET_DIR)/usr/bin
> endef
>
> BLUEZ5_UTILS_POST_INSTALL_TARGET_HOOKS += BLUEZ5_UTILS_INSTALL_GATTTOOL
> endif
Done

> Thanks a lot, but the patch should be in a separate e-mail. As you sent
> it, all your discussion answering Yann's comment would end up in the
> patch commit log.
It will be.

> Also your Signed-off-by line is missing.
Added

--
 Marcin Bis

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH v4] bluez5_utils: new package
  2014-03-20 19:28         ` Jerzy Grzegorek
  2014-03-21  9:48           ` Marcin Bis
@ 2014-03-21  9:53           ` Marcin Bis
  2014-03-21 11:08             ` Jerzy Grzegorek
  1 sibling, 1 reply; 20+ messages in thread
From: Marcin Bis @ 2014-03-21  9:53 UTC (permalink / raw)
  To: buildroot

This patch adds Bluez 5.x.
API is not backwards compatible with BlueZ 4.x

BlueZ utils will use systemd and/or udev if enabled.
Contains a hook for installing GATT support tool, wchich is always
build but not installed by default.

Signed-off-by: Marcin Bis <marcin@bis.org.pl>
---
 package/Config.in                    |    1 +
 package/bluez5_utils/Config.in       |   51 ++++++++++++++++++++++++++++++++
 package/bluez5_utils/bluez5_utils.mk |   54 ++++++++++++++++++++++++++++++++++
 3 files changed, 106 insertions(+)
 create mode 100644 package/bluez5_utils/Config.in
 create mode 100644 package/bluez5_utils/bluez5_utils.mk

diff --git a/package/Config.in b/package/Config.in
index 8986734..357a96c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -867,6 +867,7 @@ source "package/axel/Config.in"
 source "package/bcusdk/Config.in"
 source "package/bind/Config.in"
 source "package/bluez_utils/Config.in"
+source "package/bluez5_utils/Config.in"
 source "package/bmon/Config.in"
 source "package/boa/Config.in"
 source "package/bridge-utils/Config.in"
diff --git a/package/bluez5_utils/Config.in b/package/bluez5_utils/Config.in
new file mode 100644
index 0000000..c721fff
--- /dev/null
+++ b/package/bluez5_utils/Config.in
@@ -0,0 +1,51 @@
+config BR2_PACKAGE_BLUEZ5_UTILS
+	bool "bluez-utils 5.x"
+	depends on !BR2_avr32
+	depends on BR2_USE_WCHAR # libglib2
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
+	depends on BR2_USE_MMU # dbus
+	depends on !BR2_PACKAGE_BLUEZ_UTILS # conflicts with 4.x version
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBICAL
+	select BR2_PACKAGE_READLINE
+	help
+	  bluez utils version 5.x
+
+	  With this release BlueZ only supports the new Bluetooth Management
+	  kernel interface (introduced in Linux 3.4).
+	  For Low Energy support at least kernel version 3.5 is needed.
+
+	  The API is not backwards compatible with BlueZ 4.
+
+	  Bluez utils will use systemd and/or udev if enabled.
+
+	  http://www.bluez.org
+	  http://www.kernel.org/pub/linux/bluetooth
+
+if BR2_PACKAGE_BLUEZ5_UTILS
+
+config BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL
+	bool "build experimental plugins"
+	help
+	  Build BlueZ 5.x experimental plugins (SAP, NFC, ...).
+
+config BR2_PACKAGE_BLUEZ5_UTILS_TEST
+	bool "enable test"
+	help
+	  Enable test.
+
+config BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL
+	bool "install GATT tool"
+	help
+	  Generic Attribute Profile (GATT) support. This provides profile
+	  discovery and description services for Bluetooth Low Energy.
+	  This will install the gatttool utility.
+
+	  It is always build with BlueZ 5.x, but upstream choose not to install
+	  it by default.
+
+endif
+
+comment "bluez5-utils needs a toolchain w/ wchar, threads"
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
new file mode 100644
index 0000000..6cc61cf
--- /dev/null
+++ b/package/bluez5_utils/bluez5_utils.mk
@@ -0,0 +1,54 @@
+################################################################################
+#
+# bluez5_utils
+#
+################################################################################
+
+BLUEZ5_UTILS_VERSION = 5.16
+BLUEZ5_UTILS_SOURCE = bluez-$(BLUEZ5_UTILS_VERSION).tar.xz
+BLUEZ5_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
+BLUEZ5_UTILS_INSTALL_STAGING = YES
+BLUEZ5_UTILS_DEPENDENCIES = dbus libglib2 libical readline
+BLUEZ5_UTILS_CONF_OPT = --enable-tools --enable-library
+BLUEZ5_UTILS_LICENSE = GPLv2+ LGPLv2.1+
+BLUEZ5_UTILS_LICENSE_FILES = COPYING COPYING.LIB
+
+# experimental plugins
+ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL),y)
+	BLUEZ5_UTILS_CONF_OPT += --enable-experimental
+else
+	BLUEZ5_UTILS_CONF_OPT += --disable-experimental
+endif
+
+# install gatttool (For some reason upstream choose not to do it by default)
+ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL),y)
+define BLUEZ5_UTILS_INSTALL_GATTTOOL
+	$(INSTALL) -D -m 0755 $(@D)/attrib/gatttool $(TARGET_DIR)/usr/bin
+endef
+	BLUEZ5_UTILS_POST_INSTALL_TARGET_HOOKS += BLUEZ5_UTILS_INSTALL_GATTTOOL
+endif
+
+# enable test
+ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_TEST),y)
+	BLUEZ5_UTILS_CONF_OPT += --enable-test
+else
+	BLUEZ5_UTILS_CONF_OPT += --disable-test
+endif
+
+# use udev if available
+ifeq ($(BR2_PACKAGE_UDEV),y)
+        BLUEZ5_UTILS_CONF_OPT += --enable-udev
+        BLUEZ5_UTILS_DEPENDENCIES += udev
+else
+        BLUEZ5_UTILS_CONF_OPT += --disable-udev
+endif
+
+# integrate with systemd if available
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+        BLUEZ5_UTILS_CONF_OPT += --enable-systemd
+        BLUEZ5_UTILS_DEPENDENCIES += systemd
+else
+        BLUEZ5_UTILS_CONF_OPT += --disable-systemd
+endif
+
+$(eval $(autotools-package))
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH v4] bluez5_utils: new package
  2014-03-21  9:53           ` [Buildroot] [PATCH v4] " Marcin Bis
@ 2014-03-21 11:08             ` Jerzy Grzegorek
  2014-03-21 11:42               ` Gustavo Zacarias
  0 siblings, 1 reply; 20+ messages in thread
From: Jerzy Grzegorek @ 2014-03-21 11:08 UTC (permalink / raw)
  To: buildroot


Hi Marcin,

> This patch adds Bluez 5.x.
> API is not backwards compatible with BlueZ 4.x
>
> BlueZ utils will use systemd and/or udev if enabled.
> Contains a hook for installing GATT support tool, wchich is always
> build but not installed by default.
>
> Signed-off-by: Marcin Bis <marcin@bis.org.pl>
> ---
>   package/Config.in                    |    1 +
>   package/bluez5_utils/Config.in       |   51 ++++++++++++++++++++++++++++++++
>   package/bluez5_utils/bluez5_utils.mk |   54 ++++++++++++++++++++++++++++++++++
>   3 files changed, 106 insertions(+)
>   create mode 100644 package/bluez5_utils/Config.in
>   create mode 100644 package/bluez5_utils/bluez5_utils.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 8986734..357a96c 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -867,6 +867,7 @@ source "package/axel/Config.in"
>   source "package/bcusdk/Config.in"
>   source "package/bind/Config.in"
>   source "package/bluez_utils/Config.in"
> +source "package/bluez5_utils/Config.in"

Add it in alphabetical order.

>   source "package/bmon/Config.in"
>   source "package/boa/Config.in"
>   source "package/bridge-utils/Config.in"
> diff --git a/package/bluez5_utils/Config.in b/package/bluez5_utils/Config.in
> new file mode 100644
> index 0000000..c721fff
> --- /dev/null
> +++ b/package/bluez5_utils/Config.in
> @@ -0,0 +1,51 @@
> +config BR2_PACKAGE_BLUEZ5_UTILS
> +	bool "bluez-utils 5.x"
> +	depends on !BR2_avr32
> +	depends on BR2_USE_WCHAR # libglib2
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
> +	depends on BR2_USE_MMU # dbus
> +	depends on !BR2_PACKAGE_BLUEZ_UTILS # conflicts with 4.x version
> +	select BR2_PACKAGE_DBUS
> +	select BR2_PACKAGE_LIBGLIB2
> +	select BR2_PACKAGE_LIBICAL
> +	select BR2_PACKAGE_READLINE
> +	help
> +	  bluez utils version 5.x
> +
> +	  With this release BlueZ only supports the new Bluetooth Management
> +	  kernel interface (introduced in Linux 3.4).
> +	  For Low Energy support at least kernel version 3.5 is needed.
> +
> +	  The API is not backwards compatible with BlueZ 4.
> +
> +	  Bluez utils will use systemd and/or udev if enabled.
> +
> +	  http://www.bluez.org
> +	  http://www.kernel.org/pub/linux/bluetooth
> +
> +if BR2_PACKAGE_BLUEZ5_UTILS
> +
> +config BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL
> +	bool "build experimental plugins"
> +	help
> +	  Build BlueZ 5.x experimental plugins (SAP, NFC, ...).
> +
> +config BR2_PACKAGE_BLUEZ5_UTILS_TEST
> +	bool "enable test"
> +	help
> +	  Enable test.
> +
> +config BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL
> +	bool "install GATT tool"
> +	help
> +	  Generic Attribute Profile (GATT) support. This provides profile
> +	  discovery and description services for Bluetooth Low Energy.
> +	  This will install the gatttool utility.
> +
> +	  It is always build with BlueZ 5.x, but upstream choose not to install
> +	  it by default.
> +
> +endif
> +
> +comment "bluez5-utils needs a toolchain w/ wchar, threads"
> +	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
> new file mode 100644
> index 0000000..6cc61cf
> --- /dev/null
> +++ b/package/bluez5_utils/bluez5_utils.mk
> @@ -0,0 +1,54 @@
> +################################################################################
> +#
> +# bluez5_utils
> +#
> +################################################################################
> +
> +BLUEZ5_UTILS_VERSION = 5.16
> +BLUEZ5_UTILS_SOURCE = bluez-$(BLUEZ5_UTILS_VERSION).tar.xz
> +BLUEZ5_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
> +BLUEZ5_UTILS_INSTALL_STAGING = YES
> +BLUEZ5_UTILS_DEPENDENCIES = dbus libglib2 libical readline
> +BLUEZ5_UTILS_CONF_OPT = --enable-tools --enable-library
> +BLUEZ5_UTILS_LICENSE = GPLv2+ LGPLv2.1+
> +BLUEZ5_UTILS_LICENSE_FILES = COPYING COPYING.LIB
> +
> +# experimental plugins
> +ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL),y)
> +	BLUEZ5_UTILS_CONF_OPT += --enable-experimental
> +else
> +	BLUEZ5_UTILS_CONF_OPT += --disable-experimental
> +endif
> +
> +# install gatttool (For some reason upstream choose not to do it by default)
> +ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL),y)
> +define BLUEZ5_UTILS_INSTALL_GATTTOOL
> +	$(INSTALL) -D -m 0755 $(@D)/attrib/gatttool $(TARGET_DIR)/usr/bin
> +endef
> +	BLUEZ5_UTILS_POST_INSTALL_TARGET_HOOKS += BLUEZ5_UTILS_INSTALL_GATTTOOL

This leading tab is unnecessary.

Regards,
Jerzy

> +endif
> +
> +# enable test
> +ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_TEST),y)
> +	BLUEZ5_UTILS_CONF_OPT += --enable-test
> +else
> +	BLUEZ5_UTILS_CONF_OPT += --disable-test
> +endif
> +
> +# use udev if available
> +ifeq ($(BR2_PACKAGE_UDEV),y)
> +        BLUEZ5_UTILS_CONF_OPT += --enable-udev
> +        BLUEZ5_UTILS_DEPENDENCIES += udev
> +else
> +        BLUEZ5_UTILS_CONF_OPT += --disable-udev
> +endif
> +
> +# integrate with systemd if available
> +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> +        BLUEZ5_UTILS_CONF_OPT += --enable-systemd
> +        BLUEZ5_UTILS_DEPENDENCIES += systemd
> +else
> +        BLUEZ5_UTILS_CONF_OPT += --disable-systemd
> +endif
> +
> +$(eval $(autotools-package))

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH v4] bluez5_utils: new package
  2014-03-21 11:08             ` Jerzy Grzegorek
@ 2014-03-21 11:42               ` Gustavo Zacarias
  2014-03-21 16:45                 ` Jerzy Grzegorek
  0 siblings, 1 reply; 20+ messages in thread
From: Gustavo Zacarias @ 2014-03-21 11:42 UTC (permalink / raw)
  To: buildroot

On 03/21/2014 08:08 AM, Jerzy Grzegorek wrote:

>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -867,6 +867,7 @@ source "package/axel/Config.in"
>>   source "package/bcusdk/Config.in"
>>   source "package/bind/Config.in"
>>   source "package/bluez_utils/Config.in"
>> +source "package/bluez5_utils/Config.in"
> 
> Add it in alphabetical order.

Hmm? bluez5 > bluez, and we care about visual name there (how it shows
up in *config).
Regards.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH v4] bluez5_utils: new package
  2014-03-21 11:42               ` Gustavo Zacarias
@ 2014-03-21 16:45                 ` Jerzy Grzegorek
  2014-03-21 16:50                   ` Gustavo Zacarias
  2014-03-21 16:55                   ` [Buildroot] [PATCH v4] " Gustavo Zacarias
  0 siblings, 2 replies; 20+ messages in thread
From: Jerzy Grzegorek @ 2014-03-21 16:45 UTC (permalink / raw)
  To: buildroot


Hi Gustavo,

> On 03/21/2014 08:08 AM, Jerzy Grzegorek wrote:
>
>>> --- a/package/Config.in
>>> +++ b/package/Config.in
>>> @@ -867,6 +867,7 @@ source "package/axel/Config.in"
>>>    source "package/bcusdk/Config.in"
>>>    source "package/bind/Config.in"
>>>    source "package/bluez_utils/Config.in"
>>> +source "package/bluez5_utils/Config.in"
>> Add it in alphabetical order.
> Hmm? bluez5 > bluez, and we care about visual name there (how it shows
> up in *config).

Don't compare bluez5 with bluez.
Compare bluez5_utils with bluez_utils.

Regards,
Jerzy

> Regards.
>
>

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH v4] bluez5_utils: new package
  2014-03-21 16:45                 ` Jerzy Grzegorek
@ 2014-03-21 16:50                   ` Gustavo Zacarias
  2014-03-23 23:10                     ` Jerzy Grzegorek
  2014-03-21 16:55                   ` [Buildroot] [PATCH v4] " Gustavo Zacarias
  1 sibling, 1 reply; 20+ messages in thread
From: Gustavo Zacarias @ 2014-03-21 16:50 UTC (permalink / raw)
  To: buildroot

On 03/21/2014 01:45 PM, Jerzy Grzegorek wrote:

>> Hmm? bluez5 > bluez, and we care about visual name there (how it shows
>> up in *config).
> 
> Don't compare bluez5 with bluez.
> Compare bluez5_utils with bluez_utils.
> 
> Regards,
> Jerzy

I know how sort works, i'm talking of common sense in this case.
python is before python3, samba is before samba4 and so on, so in the
bluez case the same would hold up, it's about context, not sort with lang=C.
Regards.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH v4] bluez5_utils: new package
  2014-03-21 16:45                 ` Jerzy Grzegorek
  2014-03-21 16:50                   ` Gustavo Zacarias
@ 2014-03-21 16:55                   ` Gustavo Zacarias
  1 sibling, 0 replies; 20+ messages in thread
From: Gustavo Zacarias @ 2014-03-21 16:55 UTC (permalink / raw)
  To: buildroot

On 03/21/2014 01:45 PM, Jerzy Grzegorek wrote:
>> Hmm? bluez5 > bluez, and we care about visual name there (how it shows
>> up in *config).
> 
> Don't compare bluez5 with bluez.
> Compare bluez5_utils with bluez_utils.
> 
> Regards,
> Jerzy

Let me put it in exmaples, what if i make/add packages named bluezbeam,
bluezhack and a dozen more?
Regards.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH v4] bluez5_utils: new package
  2014-03-21 16:50                   ` Gustavo Zacarias
@ 2014-03-23 23:10                     ` Jerzy Grzegorek
  2014-03-31  8:55                       ` Marcin Bis
  2014-03-31  8:58                       ` [Buildroot] [PATCH v5] " Marcin Bis
  0 siblings, 2 replies; 20+ messages in thread
From: Jerzy Grzegorek @ 2014-03-23 23:10 UTC (permalink / raw)
  To: buildroot


Hi Gustavo, Marcin,

> On 03/21/2014 01:45 PM, Jerzy Grzegorek wrote:
>
>>> Hmm? bluez5 > bluez, and we care about visual name there (how it shows
>>> up in *config).
>> Don't compare bluez5 with bluez.
>> Compare bluez5_utils with bluez_utils.
>>
>> Regards,
>> Jerzy
> I know how sort works, i'm talking of common sense in this case.
> python is before python3, samba is before samba4 and so on, so in the
> bluez case the same would hold up, it's about context, not sort with lang=C.
> Regards.

Gustavo:  Ah, yes, right. Sorry for this and thanks for your clarification.
Marcin:  Sorry for the noise. Just don't take my comment into consideration.

Regards,
Jerzy

>
>

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH v4] bluez5_utils: new package
  2014-03-23 23:10                     ` Jerzy Grzegorek
@ 2014-03-31  8:55                       ` Marcin Bis
  2014-03-31  8:58                       ` [Buildroot] [PATCH v5] " Marcin Bis
  1 sibling, 0 replies; 20+ messages in thread
From: Marcin Bis @ 2014-03-31  8:55 UTC (permalink / raw)
  To: buildroot

Hi Jerzy, Gustavo

> Gustavo:  Ah, yes, right. Sorry for this and thanks for your clarification.
> Marcin:  Sorry for the noise. Just don't take my comment into consideration.

I am resending v5 of the patch.
- Order of packages in Config.in - not changed
- Unnecessary. leading tab removed.
- I added a comment, so bluez5_utils will not completely disappear
from menuconfig if bluez_utils is selected.

--
 Marcin Bis

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH v5] bluez5_utils: new package
  2014-03-23 23:10                     ` Jerzy Grzegorek
  2014-03-31  8:55                       ` Marcin Bis
@ 2014-03-31  8:58                       ` Marcin Bis
  2014-04-03 20:00                         ` Thomas Petazzoni
  2014-08-02 11:08                         ` Thomas Petazzoni
  1 sibling, 2 replies; 20+ messages in thread
From: Marcin Bis @ 2014-03-31  8:58 UTC (permalink / raw)
  To: buildroot

This patch adds Bluez 5.x.
API is not backwards compatible with BlueZ 4.x

BlueZ utils will use systemd and/or udev if enabled.
Contains a hook for installing GATT support tool, wchich is always
build but not installed by default.

Signed-off-by: Marcin Bis <marcin@bis.org.pl>
---
 package/Config.in                    |    1 +
 package/bluez5_utils/Config.in       |   54 ++++++++++++++++++++++++++++++++++
 package/bluez5_utils/bluez5_utils.mk |   54 ++++++++++++++++++++++++++++++++++
 3 files changed, 109 insertions(+)
 create mode 100644 package/bluez5_utils/Config.in
 create mode 100644 package/bluez5_utils/bluez5_utils.mk

diff --git a/package/Config.in b/package/Config.in
index e816603..0be90f6 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -876,6 +876,7 @@ source "package/axel/Config.in"
 source "package/bcusdk/Config.in"
 source "package/bind/Config.in"
 source "package/bluez_utils/Config.in"
+source "package/bluez5_utils/Config.in"
 source "package/bmon/Config.in"
 source "package/boa/Config.in"
 source "package/bridge-utils/Config.in"
diff --git a/package/bluez5_utils/Config.in b/package/bluez5_utils/Config.in
new file mode 100644
index 0000000..809dd8a
--- /dev/null
+++ b/package/bluez5_utils/Config.in
@@ -0,0 +1,54 @@
+config BR2_PACKAGE_BLUEZ5_UTILS
+	bool "bluez-utils 5.x"
+	depends on !BR2_avr32
+	depends on BR2_USE_WCHAR # libglib2
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
+	depends on BR2_USE_MMU # dbus
+	depends on !BR2_PACKAGE_BLUEZ_UTILS # conflicts with 4.x version
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBICAL
+	select BR2_PACKAGE_READLINE
+	help
+	  bluez utils version 5.x
+
+	  With this release BlueZ only supports the new Bluetooth Management
+	  kernel interface (introduced in Linux 3.4).
+	  For Low Energy support at least kernel version 3.5 is needed.
+
+	  The API is not backwards compatible with BlueZ 4.
+
+	  Bluez utils will use systemd and/or udev if enabled.
+
+	  http://www.bluez.org
+	  http://www.kernel.org/pub/linux/bluetooth
+
+if BR2_PACKAGE_BLUEZ5_UTILS
+
+config BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL
+	bool "build experimental plugins"
+	help
+	  Build BlueZ 5.x experimental plugins (SAP, NFC, ...).
+
+config BR2_PACKAGE_BLUEZ5_UTILS_TEST
+	bool "enable test"
+	help
+	  Enable test.
+
+config BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL
+	bool "install GATT tool"
+	help
+	  Generic Attribute Profile (GATT) support. This provides profile
+	  discovery and description services for Bluetooth Low Energy.
+	  This will install the gatttool utility.
+
+	  It is always build with BlueZ 5.x, but upstream choose not to install
+	  it by default.
+
+endif
+
+comment "bluez5-utils needs a toolchain w/ wchar, threads"
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "bluez5-utils conflicts with older bluez-utils version"
+	depends on BR2_PACKAGE_BLUEZ_UTILS
diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
new file mode 100644
index 0000000..85cbb43
--- /dev/null
+++ b/package/bluez5_utils/bluez5_utils.mk
@@ -0,0 +1,54 @@
+################################################################################
+#
+# bluez5_utils
+#
+################################################################################
+
+BLUEZ5_UTILS_VERSION = 5.17
+BLUEZ5_UTILS_SOURCE = bluez-$(BLUEZ5_UTILS_VERSION).tar.xz
+BLUEZ5_UTILS_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
+BLUEZ5_UTILS_INSTALL_STAGING = YES
+BLUEZ5_UTILS_DEPENDENCIES = dbus libglib2 libical readline
+BLUEZ5_UTILS_CONF_OPT = --enable-tools --enable-library
+BLUEZ5_UTILS_LICENSE = GPLv2+ LGPLv2.1+
+BLUEZ5_UTILS_LICENSE_FILES = COPYING COPYING.LIB
+
+# experimental plugins
+ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_EXPERIMENTAL),y)
+	BLUEZ5_UTILS_CONF_OPT += --enable-experimental
+else
+	BLUEZ5_UTILS_CONF_OPT += --disable-experimental
+endif
+
+# install gatttool (For some reason upstream choose not to do it by default)
+ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL),y)
+define BLUEZ5_UTILS_INSTALL_GATTTOOL
+	$(INSTALL) -D -m 0755 $(@D)/attrib/gatttool $(TARGET_DIR)/usr/bin
+endef
+BLUEZ5_UTILS_POST_INSTALL_TARGET_HOOKS += BLUEZ5_UTILS_INSTALL_GATTTOOL
+endif
+
+# enable test
+ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_TEST),y)
+	BLUEZ5_UTILS_CONF_OPT += --enable-test
+else
+	BLUEZ5_UTILS_CONF_OPT += --disable-test
+endif
+
+# use udev if available
+ifeq ($(BR2_PACKAGE_UDEV),y)
+        BLUEZ5_UTILS_CONF_OPT += --enable-udev
+        BLUEZ5_UTILS_DEPENDENCIES += udev
+else
+        BLUEZ5_UTILS_CONF_OPT += --disable-udev
+endif
+
+# integrate with systemd if available
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+        BLUEZ5_UTILS_CONF_OPT += --enable-systemd
+        BLUEZ5_UTILS_DEPENDENCIES += systemd
+else
+        BLUEZ5_UTILS_CONF_OPT += --disable-systemd
+endif
+
+$(eval $(autotools-package))
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH v5] bluez5_utils: new package
  2014-03-31  8:58                       ` [Buildroot] [PATCH v5] " Marcin Bis
@ 2014-04-03 20:00                         ` Thomas Petazzoni
  2014-04-04  9:03                           ` Marcin Bis
  2014-08-02 11:08                         ` Thomas Petazzoni
  1 sibling, 1 reply; 20+ messages in thread
From: Thomas Petazzoni @ 2014-04-03 20:00 UTC (permalink / raw)
  To: buildroot

Dear Marcin Bis,

On Mon, 31 Mar 2014 10:58:00 +0200, Marcin Bis wrote:
> This patch adds Bluez 5.x.
> API is not backwards compatible with BlueZ 4.x

... so it is packaged as a separate package.

> BlueZ utils will use systemd and/or udev if enabled.
> Contains a hook for installing GATT support tool, wchich is always

which

> build but not installed by default.

build -> built


> diff --git a/package/bluez5_utils/Config.in b/package/bluez5_utils/Config.in
> new file mode 100644
> index 0000000..809dd8a
> --- /dev/null
> +++ b/package/bluez5_utils/Config.in
> @@ -0,0 +1,54 @@
> +config BR2_PACKAGE_BLUEZ5_UTILS
> +	bool "bluez-utils 5.x"
> +	depends on !BR2_avr32
> +	depends on BR2_USE_WCHAR # libglib2
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
> +	depends on BR2_USE_MMU # dbus
> +	depends on !BR2_PACKAGE_BLUEZ_UTILS # conflicts with 4.x version
> +	select BR2_PACKAGE_DBUS
> +	select BR2_PACKAGE_LIBGLIB2
> +	select BR2_PACKAGE_LIBICAL
> +	select BR2_PACKAGE_READLINE
> +	help
> +	  bluez utils version 5.x
> +
> +	  With this release BlueZ only supports the new Bluetooth Management
> +	  kernel interface (introduced in Linux 3.4).

Does it need kernel headers >= 3.4 ?


> +# install gatttool (For some reason upstream choose not to do it by default)
> +ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL),y)
> +define BLUEZ5_UTILS_INSTALL_GATTTOOL
> +	$(INSTALL) -D -m 0755 $(@D)/attrib/gatttool $(TARGET_DIR)/usr/bin

The destination path should be a full path, i.e:

	$(TARGET_DIR)/usr/bin/gatttool

> +# use udev if available
> +ifeq ($(BR2_PACKAGE_UDEV),y)

You should instead rely on BR2_PACKAGE_HAS_UDEV, so that it works with
both eudev, or the udev built into systemd.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH v5] bluez5_utils: new package
  2014-04-03 20:00                         ` Thomas Petazzoni
@ 2014-04-04  9:03                           ` Marcin Bis
  0 siblings, 0 replies; 20+ messages in thread
From: Marcin Bis @ 2014-04-04  9:03 UTC (permalink / raw)
  To: buildroot

Hi Thomas

On Thu, Apr 3, 2014 at 10:00 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Marcin Bis,

>> diff --git a/package/bluez5_utils/Config.in b/package/bluez5_utils/Config.in
>> new file mode 100644
>> index 0000000..809dd8a
>> --- /dev/null
>> +++ b/package/bluez5_utils/Config.in
>> @@ -0,0 +1,54 @@
>> +config BR2_PACKAGE_BLUEZ5_UTILS
>> +     bool "bluez-utils 5.x"
>> +     depends on !BR2_avr32
>> +     depends on BR2_USE_WCHAR # libglib2
>> +     depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
>> +     depends on BR2_USE_MMU # dbus
>> +     depends on !BR2_PACKAGE_BLUEZ_UTILS # conflicts with 4.x version
>> +     select BR2_PACKAGE_DBUS
>> +     select BR2_PACKAGE_LIBGLIB2
>> +     select BR2_PACKAGE_LIBICAL
>> +     select BR2_PACKAGE_READLINE
>> +     help
>> +       bluez utils version 5.x
>> +
>> +       With this release BlueZ only supports the new Bluetooth Management
>> +       kernel interface (introduced in Linux 3.4).
>
> Does it need kernel headers >= 3.4 ?

I am checking this.
It seems that it needs kernel >= 3.4 for BLE.
In older kernels BLE wont work, but older Bluetooth spec. should.

>> +# install gatttool (For some reason upstream choose not to do it by default)
>> +ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_GATTTOOL),y)
>> +define BLUEZ5_UTILS_INSTALL_GATTTOOL
>> +     $(INSTALL) -D -m 0755 $(@D)/attrib/gatttool $(TARGET_DIR)/usr/bin
>
> The destination path should be a full path, i.e:
>
>         $(TARGET_DIR)/usr/bin/gatttool
OK

>> +# use udev if available
>> +ifeq ($(BR2_PACKAGE_UDEV),y)
>
> You should instead rely on BR2_PACKAGE_HAS_UDEV, so that it works with
> both eudev, or the udev built into systemd.
OK

I will fix it over the weekend.

--
 Marcin Bis

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Buildroot] [PATCH v5] bluez5_utils: new package
  2014-03-31  8:58                       ` [Buildroot] [PATCH v5] " Marcin Bis
  2014-04-03 20:00                         ` Thomas Petazzoni
@ 2014-08-02 11:08                         ` Thomas Petazzoni
  1 sibling, 0 replies; 20+ messages in thread
From: Thomas Petazzoni @ 2014-08-02 11:08 UTC (permalink / raw)
  To: buildroot

Dear Marcin Bis,

On Mon, 31 Mar 2014 10:58:00 +0200, Marcin Bis wrote:
> This patch adds Bluez 5.x.
> API is not backwards compatible with BlueZ 4.x
> 
> BlueZ utils will use systemd and/or udev if enabled.
> Contains a hook for installing GATT support tool, wchich is always
> build but not installed by default.
> 
> Signed-off-by: Marcin Bis <marcin@bis.org.pl>
> ---
>  package/Config.in                    |    1 +
>  package/bluez5_utils/Config.in       |   54 ++++++++++++++++++++++++++++++++++
>  package/bluez5_utils/bluez5_utils.mk |   54 ++++++++++++++++++++++++++++++++++
>  3 files changed, 109 insertions(+)
>  create mode 100644 package/bluez5_utils/Config.in
>  create mode 100644 package/bluez5_utils/bluez5_utils.mk

I've applied your patch, after making a number of changes:

    [Thomas:
     - Add dependency on 3.4 kernel headers
     - Add options for OBEX support and client support, to make the
       libical and readline dependencies optional.
     - Rewrap Config.in help text.
     - Adapt indentation in .mk file.
     - Bump to version 5.21.
     - Use BR2_PACKAGE_HAS_UDEV instead of BR2_PACKAGE_UDEV.]

It would be great if you could test the latest master and confirm that
it works for you.

Thanks a lot for this contribution!

Thomas Petazzoni
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2014-08-02 11:08 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-04 12:59 [Buildroot] [PATCH] bluez5_utils: new package Marcin Bis
2013-11-04 16:06 ` Thomas De Schampheleire
2013-11-04 21:34   ` [Buildroot] [PATCH v2] " Marcin Bis
2014-03-04 21:38     ` Yann E. MORIN
2014-03-20 13:48       ` [Buildroot] [PATCH v3] " Marcin Bis
2014-03-20 18:21         ` Thomas Petazzoni
2014-03-20 19:28         ` Jerzy Grzegorek
2014-03-21  9:48           ` Marcin Bis
2014-03-21  9:53           ` [Buildroot] [PATCH v4] " Marcin Bis
2014-03-21 11:08             ` Jerzy Grzegorek
2014-03-21 11:42               ` Gustavo Zacarias
2014-03-21 16:45                 ` Jerzy Grzegorek
2014-03-21 16:50                   ` Gustavo Zacarias
2014-03-23 23:10                     ` Jerzy Grzegorek
2014-03-31  8:55                       ` Marcin Bis
2014-03-31  8:58                       ` [Buildroot] [PATCH v5] " Marcin Bis
2014-04-03 20:00                         ` Thomas Petazzoni
2014-04-04  9:03                           ` Marcin Bis
2014-08-02 11:08                         ` Thomas Petazzoni
2014-03-21 16:55                   ` [Buildroot] [PATCH v4] " Gustavo Zacarias

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.