From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Usf8=5Z=kvack.org=owner-linux-mm@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 93993C2D0EA
	for <linux-mm@archiver.kernel.org>; Thu,  9 Apr 2020 07:46:47 +0000 (UTC)
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by mail.kernel.org (Postfix) with ESMTP id 50C742075E
	for <linux-mm@archiver.kernel.org>; Thu,  9 Apr 2020 07:46:47 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="rRc/jGlE"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50C742075E
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix)
	id D984E8E000E; Thu,  9 Apr 2020 03:46:46 -0400 (EDT)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id D21808E0006; Thu,  9 Apr 2020 03:46:46 -0400 (EDT)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id BE9878E000E; Thu,  9 Apr 2020 03:46:46 -0400 (EDT)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209])
	by kanga.kvack.org (Postfix) with ESMTP id B00B38E0006
	for <linux-mm@kvack.org>; Thu,  9 Apr 2020 03:46:46 -0400 (EDT)
Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay05.hostedemail.com (Postfix) with ESMTP id 884FE181AC9CC
	for <linux-mm@kvack.org>; Thu,  9 Apr 2020 07:46:46 +0000 (UTC)
X-FDA: 76687534812.20.soap89_3b1a0347e7d1b
X-HE-Tag: soap89_3b1a0347e7d1b
X-Filterd-Recvd-Size: 3814
Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64])
	by imf45.hostedemail.com (Postfix) with ESMTP
	for <linux-mm@kvack.org>; Thu,  9 Apr 2020 07:46:45 +0000 (UTC)
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
	id <B5e8ed2ae0000>; Thu, 09 Apr 2020 00:45:50 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 09 Apr 2020 00:46:43 -0700
X-PGP-Universal: processed;
	by hqpgpgate101.nvidia.com on Thu, 09 Apr 2020 00:46:43 -0700
Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL111.nvidia.com
 (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 9 Apr
 2020 07:46:43 +0000
Received: from [10.2.50.223] (10.124.1.5) by DRHQMAIL107.nvidia.com
 (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 9 Apr 2020
 07:46:42 +0000
Subject: Re: [patch 043/155] mm/gup: track FOLL_PIN pages
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
CC: <imbrenda@linux.ibm.com>, <jack@suse.cz>, <jglisse@redhat.com>, "Andrew
 Morton" <akpm@linux-foundation.org>, <corbet@lwn.net>,
	<dan.j.williams@intel.com>, <david@fromorbit.com>, <hch@infradead.org>,
	<ira.weiny@intel.com>, <jgg@ziepe.ca>, <kirill.shutemov@linux.intel.com>,
	<linux-mm@kvack.org>, <mhocko@suse.com>, <mike.kravetz@oracle.com>,
	<shuah@kernel.org>, <torvalds@linux-foundation.org>, <vbabka@suse.cz>,
	<viro@zeniv.linux.org.uk>, <willy@infradead.org>
References: <20200402040529.wHKICHtvB%akpm@linux-foundation.org>
 <acb17a53-d6fa-170f-b69a-ea2c525b5e6a@I-love.SAKURA.ne.jp>
 <2d45b8b7-ecbc-298f-5124-cb635dd3928a@nvidia.com>
 <8bde6675-6cd4-c25e-059a-beeb54c6b0c1@i-love.sakura.ne.jp>
X-Nvconfidentiality: public
From: John Hubbard <jhubbard@nvidia.com>
Message-ID: <532a133b-cb18-a635-0e07-53b8d8082f87@nvidia.com>
Date: Thu, 9 Apr 2020 00:46:42 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <8bde6675-6cd4-c25e-059a-beeb54c6b0c1@i-love.sakura.ne.jp>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 DRHQMAIL107.nvidia.com (10.27.9.16)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
	t=1586418350; bh=zgehM9q6uYaagzmU4u0RXNeWnRQqXY7U9QtntbVZv84=;
	h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From:
	 Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
	 X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
	 Content-Transfer-Encoding;
	b=rRc/jGlE/2vTuAucabSnfdRwzGD2x8i6GJy9rxRR4BGTQVjQxMR5UKcbAviO7RUy/
	 IjWXYWQ+CevUx7fkRQ9zjmgCo7dd37bWl+walDJ+SYu3zoyWjAvClGZSqXG4ZG13lt
	 fj/sIsVRwA3tKQDDMgEMgU8C/PQmXClXftgRJxGSOnQDw5mrm9j2KopbIdrI1pLYB8
	 0nc3/PzhzCzZ+9OQGNB8cEqLeI53EZ7Mdqeo92OFhwx52jHNglTzYrRTQYgUoJ3v4w
	 WpbmOz30DuuiFawhaZU79e8VuaKDYRZ3lXwqqq7HmTKX6Lf6VSvdmcAV0WEn9ZAvyB
	 SrBwKRZfFeQhA==
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

On 4/9/20 12:20 AM, Tetsuo Handa wrote:
> Hello.
> 
> On 2020/04/09 15:38, John Hubbard wrote:
>> Also, if you happen to know if anything is calling pin_user_page*() and/or unpin_user_page*(), that
>> is extra credit. :)
> 
> Ah, I got it. I can see that only nr_foll_pin_released is increasing after I hit WARN_ON(),
> and indeed AKARI is calling unpin_user_page() when put_user() should be used.
> 
> https://osdn.net/projects/akari/scm/svn/blobs/head/trunk/akari/permission.c line 1480
> 
> Sorry for the noise. Thank you.
> 

Thanks for the quick investigation, it's a relief to hear that. :)

thanks,
-- 
John Hubbard
NVIDIA