All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Horia Geantă" <horia.geanta@freescale.com>
To: Yashpal Dutta <yashpal.dutta@freescale.com>
Cc: Ben Hutchings <ben@decadent.org.uk>,
	<linux-crypto@vger.kernel.org>, <vakul@freescale.com>,
	<ruchika.gupta@freescale.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH v3] crypto: caam - power management support for caam job-ring
Date: Mon, 24 Mar 2014 14:33:24 +0200	[thread overview]
Message-ID: <53302614.7040804@freescale.com> (raw)
In-Reply-To: <1395505456.2770.70.camel@deadeye.wl.decadent.org.uk>

On 3/22/2014 6:24 PM, Ben Hutchings wrote:
> On Fri, 2014-03-21 at 00:35 +0545, Yashpal Dutta wrote:
>> Job ring is suspended gracefully and resume afresh.
>>
>> Both Sleep (where device will remain powered-on) and Deep-sleep (where
>> device will be powered-down are handled gracefully. Persistance sessions
>> are not supported across deep-sleep.
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Yashpal Dutta <yashpal.dutta@freescale.com>
>> ---
>>   drivers/crypto/caam/intern.h |   2 +
>>   drivers/crypto/caam/jr.c     | 257 +++++++++++++++++++++++++++++++------------
>>   2 files changed, 190 insertions(+), 69 deletions(-)
> [...]
>
> This is too big for stable; is a simpler fix possible?
>

Besides size, I'd also question whether this is a bug fix or a feature.
 From Documentation/stable_kernel_rules.txt:
  - It must fix a problem that causes a build error (but not for things
    marked CONFIG_BROKEN), an oops, a hang, data corruption, a real
    security issue, or some "oh, that's not good" issue.  In short,
something critical.

On top of that - does it apply cleanly && has it been tested with 
-stable kernels?

Regards,
Horia

      parent reply	other threads:[~2014-03-24 12:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-20 18:50 [PATCH v3] crypto: caam - power management support for caam job-ring Yashpal Dutta
2014-03-21  5:54 ` Ruchika Gupta
2014-03-22 16:24 ` Ben Hutchings
2014-03-22 17:35   ` yashpal.dutta
2014-03-24 12:33   ` Horia Geantă [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53302614.7040804@freescale.com \
    --to=horia.geanta@freescale.com \
    --cc=ben@decadent.org.uk \
    --cc=linux-crypto@vger.kernel.org \
    --cc=ruchika.gupta@freescale.com \
    --cc=stable@vger.kernel.org \
    --cc=vakul@freescale.com \
    --cc=yashpal.dutta@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.